cgroups.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: 周泰宇 <zhoutaiyu@kuaishou.com>
To: Yu Kuai <yukuai1@huaweicloud.com>, "tj@kernel.org" <tj@kernel.org>
Cc: "josef@toxicpanda.com" <josef@toxicpanda.com>,
	"axboe@kernel.dk" <axboe@kernel.dk>,
	"cgroups@vger.kernel.org" <cgroups@vger.kernel.org>,
	"linux-block@vger.kernel.org" <linux-block@vger.kernel.org>,
	"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
	"yukuai (C)" <yukuai3@huawei.com>
Subject: Re: [PATCH] blk-throttle: fix repeat limit on bio with BIO_BPS_THROTTLED
Date: Tue, 23 Apr 2024 02:29:41 +0000	[thread overview]
Message-ID: <6ed23c45113b4ba48477030402295d07@kuaishou.com> (raw)
In-Reply-To: <283462e4-c2d7-8d70-bb0f-61db62a86e02@huaweicloud.com>

Hi,

> If you really want to fix this, you must come up with a solution with
> the respect of FIFO rules, breaking it like this patch is not something
> we'll accept, breaking fairness and some other flaws.

Ok, I see. Thank you so much for the feedback.

  reply	other threads:[~2024-04-23  2:29 UTC|newest]

Thread overview: 9+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2024-04-19 12:07 [PATCH] blk-throttle: fix repeat limit on bio with BIO_BPS_THROTTLED zhoutaiyu
2024-04-20  1:48 ` Yu Kuai
2024-04-22  3:33   ` 周泰宇
2024-04-22  3:47     ` Yu Kuai
2024-04-22 17:39       ` tj
2024-04-23  1:50         ` Yu Kuai
2024-04-23  2:29           ` 周泰宇 [this message]
2024-04-22  9:42     ` Yu Kuai
2024-04-22 13:05       ` 周泰宇

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=6ed23c45113b4ba48477030402295d07@kuaishou.com \
    --to=zhoutaiyu@kuaishou.com \
    --cc=axboe@kernel.dk \
    --cc=cgroups@vger.kernel.org \
    --cc=josef@toxicpanda.com \
    --cc=linux-block@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=tj@kernel.org \
    --cc=yukuai1@huaweicloud.com \
    --cc=yukuai3@huawei.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).