From: Jens Axboe <axboe@kernel.dk>
To: Tejun Heo <tj@kernel.org>, Josef Bacik <josef@toxicpanda.com>,
Waiman Long <longman@redhat.com>
Cc: cgroups@vger.kernel.org, linux-block@vger.kernel.org,
linux-kernel@vger.kernel.org,
Dan Schatzberg <schatzberg.dan@gmail.com>,
Ming Lei <ming.lei@redhat.com>
Subject: Re: [PATCH] blk-cgroup: Properly propagate the iostat update up the hierarchy
Date: Wed, 15 May 2024 20:21:14 -0600 [thread overview]
Message-ID: <171582607425.11025.1197820625337989209.b4-ty@kernel.dk> (raw)
In-Reply-To: <20240515143059.276677-1-longman@redhat.com>
On Wed, 15 May 2024 10:30:59 -0400, Waiman Long wrote:
> During a cgroup_rstat_flush() call, the lowest level of nodes are flushed
> first before their parents. Since commit 3b8cc6298724 ("blk-cgroup:
> Optimize blkcg_rstat_flush()"), iostat propagation was still done to
> the parent. Grandparent, however, may not get the iostat update if the
> parent has no blkg_iostat_set queued in its lhead lockless list.
>
> Fix this iostat propagation problem by queuing the parent's global
> blkg->iostat into one of its percpu lockless lists to make sure that
> the delta will always be propagated up to the grandparent and so on
> toward the root blkcg.
>
> [...]
Applied, thanks!
[1/1] blk-cgroup: Properly propagate the iostat update up the hierarchy
commit: 9d230c09964e6e18c8f6e4f0d41ee90eef45ec1c
Best regards,
--
Jens Axboe
prev parent reply other threads:[~2024-05-16 2:21 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-05-15 14:30 [PATCH] blk-cgroup: Properly propagate the iostat update up the hierarchy Waiman Long
2024-05-15 14:35 ` Waiman Long
2024-05-15 16:58 ` Dan Schatzberg
2024-05-15 17:00 ` Tejun Heo
2024-05-16 1:13 ` Ming Lei
2024-05-16 2:21 ` Jens Axboe [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=171582607425.11025.1197820625337989209.b4-ty@kernel.dk \
--to=axboe@kernel.dk \
--cc=cgroups@vger.kernel.org \
--cc=josef@toxicpanda.com \
--cc=linux-block@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=longman@redhat.com \
--cc=ming.lei@redhat.com \
--cc=schatzberg.dan@gmail.com \
--cc=tj@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).