From: Jens Axboe <axboe@kernel.dk>
To: tj@kernel.org, josef@toxicpanda.com, linan666@huaweicloud.com
Cc: cgroups@vger.kernel.org, linux-block@vger.kernel.org,
linux-kernel@vger.kernel.org, yukuai3@huawei.com,
yi.zhang@huawei.com, houtao1@huawei.com, yangerkun@huawei.com
Subject: Re: [PATCH v2] blk-iocost: do not WARNING if iocg has already offlined
Date: Fri, 19 Apr 2024 08:07:59 -0600 [thread overview]
Message-ID: <171353567968.448662.8909505678465861389.b4-ty@kernel.dk> (raw)
In-Reply-To: <20240419093257.3004211-1-linan666@huaweicloud.com>
On Fri, 19 Apr 2024 17:32:57 +0800, linan666@huaweicloud.com wrote:
> In iocg_pay_debt(), warn is triggered if 'active_list' is empty, which
> is intended to confirm iocg is avitve when it has debt. However, warn
> can be triggered during a blkcg or disk is being removed, as
> iocg_waitq_timer_fn() is awakened at that time.
>
> WARNING: CPU: 0 PID: 2344971 at block/blk-iocost.c:1402 iocg_pay_debt+0x14c/0x190
> Call trace:
> iocg_pay_debt+0x14c/0x190
> iocg_kick_waitq+0x438/0x4c0
> iocg_waitq_timer_fn+0xd8/0x130
> __run_hrtimer+0x144/0x45c
> __hrtimer_run_queues+0x16c/0x244
> hrtimer_interrupt+0x2cc/0x7b0
> ps: This issue was got in linux 5.10, but it also exists in the mainline.
>
> [...]
Applied, thanks!
[1/1] blk-iocost: do not WARNING if iocg has already offlined
commit: 01bc4fda9ea0a6b52f12326486f07a4910666cf6
Best regards,
--
Jens Axboe
prev parent reply other threads:[~2024-04-19 14:08 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-04-19 9:32 [PATCH v2] blk-iocost: do not WARNING if iocg has already offlined linan666
2024-04-19 14:07 ` Jens Axboe [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=171353567968.448662.8909505678465861389.b4-ty@kernel.dk \
--to=axboe@kernel.dk \
--cc=cgroups@vger.kernel.org \
--cc=houtao1@huawei.com \
--cc=josef@toxicpanda.com \
--cc=linan666@huaweicloud.com \
--cc=linux-block@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=tj@kernel.org \
--cc=yangerkun@huawei.com \
--cc=yi.zhang@huawei.com \
--cc=yukuai3@huawei.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).