From: Jens Axboe <axboe@kernel.dk>
To: linux-kernel@vger.kernel.org, Rik van Riel <riel@surriel.com>
Cc: kernel-team@meta.com, Tejun Heo <tj@kernel.org>,
Josef Bacik <josef@toxicpanda.com>,
cgroups@vger.kernel.org, linux-block@vger.kernel.org
Subject: Re: [PATCH] blk-iocost: avoid out of bounds shift
Date: Fri, 05 Apr 2024 20:07:51 -0600 [thread overview]
Message-ID: <171236927113.2455316.5665277976518467416.b4-ty@kernel.dk> (raw)
In-Reply-To: <20240404123253.0f58010f@imladris.surriel.com>
On Thu, 04 Apr 2024 12:32:53 -0400, Rik van Riel wrote:
> UBSAN catches undefined behavior in blk-iocost, where sometimes
> iocg->delay is shifted right by a number that is too large,
> resulting in undefined behavior on some architectures.
>
> [ 186.556576] ------------[ cut here ]------------
> UBSAN: shift-out-of-bounds in block/blk-iocost.c:1366:23
> shift exponent 64 is too large for 64-bit type 'u64' (aka 'unsigned long long')
> CPU: 16 PID: 0 Comm: swapper/16 Tainted: G S E N 6.9.0-0_fbk700_debug_rc2_kbuilder_0_gc85af715cac0 #1
> Hardware name: Quanta Twin Lakes MP/Twin Lakes Passive MP, BIOS F09_3A23 12/08/2020
> Call Trace:
> <IRQ>
> dump_stack_lvl+0x8f/0xe0
> __ubsan_handle_shift_out_of_bounds+0x22c/0x280
> iocg_kick_delay+0x30b/0x310
> ioc_timer_fn+0x2fb/0x1f80
> __run_timer_base+0x1b6/0x250
> ...
>
> [...]
Applied, thanks!
[1/1] blk-iocost: avoid out of bounds shift
commit: beaa51b36012fad5a4d3c18b88a617aea7a9b96d
Best regards,
--
Jens Axboe
prev parent reply other threads:[~2024-04-06 2:07 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-04-04 16:32 [PATCH] blk-iocost: avoid out of bounds shift Rik van Riel
2024-04-04 16:51 ` Tejun Heo
2024-04-06 2:07 ` Jens Axboe [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=171236927113.2455316.5665277976518467416.b4-ty@kernel.dk \
--to=axboe@kernel.dk \
--cc=cgroups@vger.kernel.org \
--cc=josef@toxicpanda.com \
--cc=kernel-team@meta.com \
--cc=linux-block@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=riel@surriel.com \
--cc=tj@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).