CEPH-Devel archive mirror
 help / color / mirror / Atom feed
From: Xiubo Li <xiubli@redhat.com>
To: kernel test robot <lkp@intel.com>
Cc: oe-kbuild-all@lists.linux.dev, ceph-devel@vger.kernel.org
Subject: Re: [ceph-client:testing 5/17] include/linux/kern_levels.h:5:25: warning: format '%s' expects argument of type 'char *', but argument 5 has type 'u32' {aka 'unsigned int'}
Date: Fri, 10 Nov 2023 08:45:00 +0800	[thread overview]
Message-ID: <b91a9c36-3709-0449-3c89-aa733cfe67d4@redhat.com> (raw)
In-Reply-To: <202311100323.X2ldielo-lkp@intel.com>

Thanks for reporting this. I fixed the testing branch.

Cheers.

- Xiubo

On 11/10/23 04:10, kernel test robot wrote:
> tree:   https://github.com/ceph/ceph-client.git testing
> head:   df68d14f678dc8f70ab1dc9cb4f1257af7b7d91b
> commit: c67942de8d2ccb3f1a8d1b87908f679be5a9d6a3 [5/17] [DO NOT MERGE] ceph: BUG if MDS changed truncate_seq with client caps still outstanding
> config: i386-randconfig-006-20231110 (https://download.01.org/0day-ci/archive/20231110/202311100323.X2ldielo-lkp@intel.com/config)
> compiler: gcc-12 (Debian 12.2.0-14) 12.2.0
> reproduce (this is a W=1 build): (https://download.01.org/0day-ci/archive/20231110/202311100323.X2ldielo-lkp@intel.com/reproduce)
>
> If you fix the issue in a separate patch/commit (i.e. not just a new version of
> the same patch/commit), kindly add following tags
> | Reported-by: kernel test robot <lkp@intel.com>
> | Closes: https://lore.kernel.org/oe-kbuild-all/202311100323.X2ldielo-lkp@intel.com/
>
> All warnings (new ones prefixed by >>):
>
>           |         ^~~~~~
>     fs/ceph/inode.c:789:33: note: in expansion of macro 'pr_err_client'
>       789 |                                 pr_err_client(" truncate_seq %u -> %u\n",
>           |                                 ^~~~~~~~~~~~~
>     include/linux/kern_levels.h:5:25: warning: format '%llu' expects a matching 'long long unsigned int' argument [-Wformat=]
>         5 | #define KERN_SOH        "\001"          /* ASCII Start Of Header */
>           |                         ^~~~~~
>     include/linux/printk.h:427:25: note: in definition of macro 'printk_index_wrap'
>       427 |                 _p_func(_fmt, ##__VA_ARGS__);                           \
>           |                         ^~~~
>     include/linux/printk.h:498:9: note: in expansion of macro 'printk'
>       498 |         printk(KERN_ERR pr_fmt(fmt), ##__VA_ARGS__)
>           |         ^~~~~~
>     include/linux/kern_levels.h:11:25: note: in expansion of macro 'KERN_SOH'
>        11 | #define KERN_ERR        KERN_SOH "3"    /* error conditions */
>           |                         ^~~~~~~~
>     include/linux/printk.h:498:16: note: in expansion of macro 'KERN_ERR'
>       498 |         printk(KERN_ERR pr_fmt(fmt), ##__VA_ARGS__)
>           |                ^~~~~~~~
>     include/linux/ceph/ceph_debug.h:68:9: note: in expansion of macro 'pr_err'
>        68 |         pr_err("[%pU %llu]: " fmt, &client->fsid,                       \
>           |         ^~~~~~
>     fs/ceph/inode.c:789:33: note: in expansion of macro 'pr_err_client'
>       789 |                                 pr_err_client(" truncate_seq %u -> %u\n",
>           |                                 ^~~~~~~~~~~~~
>     fs/ceph/inode.c:791:72: error: expected ')' before 'isize'
>       791 |                                 pr_err_client("  size %lld -> %llu\n", isize, size);
>           |                                                                        ^~~~~
>     include/linux/printk.h:427:25: note: in definition of macro 'printk_index_wrap'
>       427 |                 _p_func(_fmt, ##__VA_ARGS__);                           \
>           |                         ^~~~
>     include/linux/printk.h:498:9: note: in expansion of macro 'printk'
>       498 |         printk(KERN_ERR pr_fmt(fmt), ##__VA_ARGS__)
>           |         ^~~~~~
>     include/linux/printk.h:498:25: note: in expansion of macro 'pr_fmt'
>       498 |         printk(KERN_ERR pr_fmt(fmt), ##__VA_ARGS__)
>           |                         ^~~~~~
>     include/linux/ceph/ceph_debug.h:68:9: note: in expansion of macro 'pr_err'
>        68 |         pr_err("[%pU %llu]: " fmt, &client->fsid,                       \
>           |         ^~~~~~
>     fs/ceph/inode.c:791:33: note: in expansion of macro 'pr_err_client'
>       791 |                                 pr_err_client("  size %lld -> %llu\n", isize, size);
>           |                                 ^~~~~~~~~~~~~
>     include/linux/printk.h:427:24: note: to match this '('
>       427 |                 _p_func(_fmt, ##__VA_ARGS__);                           \
>           |                        ^
>     include/linux/printk.h:455:26: note: in expansion of macro 'printk_index_wrap'
>       455 | #define printk(fmt, ...) printk_index_wrap(_printk, fmt, ##__VA_ARGS__)
>           |                          ^~~~~~~~~~~~~~~~~
>     include/linux/printk.h:498:9: note: in expansion of macro 'printk'
>       498 |         printk(KERN_ERR pr_fmt(fmt), ##__VA_ARGS__)
>           |         ^~~~~~
>     include/linux/ceph/ceph_debug.h:68:9: note: in expansion of macro 'pr_err'
>        68 |         pr_err("[%pU %llu]: " fmt, &client->fsid,                       \
>           |         ^~~~~~
>     fs/ceph/inode.c:791:33: note: in expansion of macro 'pr_err_client'
>       791 |                                 pr_err_client("  size %lld -> %llu\n", isize, size);
>           |                                 ^~~~~~~~~~~~~
>     include/linux/kern_levels.h:5:25: warning: format '%p' expects a matching 'void *' argument [-Wformat=]
>         5 | #define KERN_SOH        "\001"          /* ASCII Start Of Header */
>           |                         ^~~~~~
>     include/linux/printk.h:427:25: note: in definition of macro 'printk_index_wrap'
>       427 |                 _p_func(_fmt, ##__VA_ARGS__);                           \
>           |                         ^~~~
>     include/linux/printk.h:498:9: note: in expansion of macro 'printk'
>       498 |         printk(KERN_ERR pr_fmt(fmt), ##__VA_ARGS__)
>           |         ^~~~~~
>     include/linux/kern_levels.h:11:25: note: in expansion of macro 'KERN_SOH'
>        11 | #define KERN_ERR        KERN_SOH "3"    /* error conditions */
>           |                         ^~~~~~~~
>     include/linux/printk.h:498:16: note: in expansion of macro 'KERN_ERR'
>       498 |         printk(KERN_ERR pr_fmt(fmt), ##__VA_ARGS__)
>           |                ^~~~~~~~
>     include/linux/ceph/ceph_debug.h:68:9: note: in expansion of macro 'pr_err'
>        68 |         pr_err("[%pU %llu]: " fmt, &client->fsid,                       \
>           |         ^~~~~~
>     fs/ceph/inode.c:791:33: note: in expansion of macro 'pr_err_client'
>       791 |                                 pr_err_client("  size %lld -> %llu\n", isize, size);
>           |                                 ^~~~~~~~~~~~~
>     include/linux/kern_levels.h:5:25: warning: format '%llu' expects a matching 'long long unsigned int' argument [-Wformat=]
>         5 | #define KERN_SOH        "\001"          /* ASCII Start Of Header */
>           |                         ^~~~~~
>     include/linux/printk.h:427:25: note: in definition of macro 'printk_index_wrap'
>       427 |                 _p_func(_fmt, ##__VA_ARGS__);                           \
>           |                         ^~~~
>     include/linux/printk.h:498:9: note: in expansion of macro 'printk'
>       498 |         printk(KERN_ERR pr_fmt(fmt), ##__VA_ARGS__)
>           |         ^~~~~~
>     include/linux/kern_levels.h:11:25: note: in expansion of macro 'KERN_SOH'
>        11 | #define KERN_ERR        KERN_SOH "3"    /* error conditions */
>           |                         ^~~~~~~~
>     include/linux/printk.h:498:16: note: in expansion of macro 'KERN_ERR'
>       498 |         printk(KERN_ERR pr_fmt(fmt), ##__VA_ARGS__)
>           |                ^~~~~~~~
>     include/linux/ceph/ceph_debug.h:68:9: note: in expansion of macro 'pr_err'
>        68 |         pr_err("[%pU %llu]: " fmt, &client->fsid,                       \
>           |         ^~~~~~
>     fs/ceph/inode.c:791:33: note: in expansion of macro 'pr_err_client'
>       791 |                                 pr_err_client("  size %lld -> %llu\n", isize, size);
>           |                                 ^~~~~~~~~~~~~
>>> include/linux/kern_levels.h:5:25: warning: format '%s' expects argument of type 'char *', but argument 5 has type 'u32' {aka 'unsigned int'} [-Wformat=]
>         5 | #define KERN_SOH        "\001"          /* ASCII Start Of Header */
>           |                         ^~~~~~
>     include/linux/printk.h:427:25: note: in definition of macro 'printk_index_wrap'
>       427 |                 _p_func(_fmt, ##__VA_ARGS__);                           \
>           |                         ^~~~
>     include/linux/printk.h:129:17: note: in expansion of macro 'printk'
>       129 |                 printk(fmt, ##__VA_ARGS__);             \
>           |                 ^~~~~~
>     include/linux/printk.h:585:9: note: in expansion of macro 'no_printk'
>       585 |         no_printk(KERN_DEBUG pr_fmt(fmt), ##__VA_ARGS__)
>           |         ^~~~~~~~~
>     include/linux/kern_levels.h:15:25: note: in expansion of macro 'KERN_SOH'
>        15 | #define KERN_DEBUG      KERN_SOH "7"    /* debug-level messages */
>           |                         ^~~~~~~~
>     include/linux/printk.h:585:19: note: in expansion of macro 'KERN_DEBUG'
>       585 |         no_printk(KERN_DEBUG pr_fmt(fmt), ##__VA_ARGS__)
>           |                   ^~~~~~~~~~
>     include/linux/ceph/ceph_debug.h:50:9: note: in expansion of macro 'pr_debug'
>        50 |         pr_debug(" [%pU %llu] %s: " fmt, &client->fsid,                 \
>           |         ^~~~~~~~
>     fs/ceph/inode.c:794:25: note: in expansion of macro 'doutc'
>       794 |                         doutc(cl, "%s truncate_seq %u -> %u\n",
>           |                         ^~~~~
>>> include/linux/kern_levels.h:5:25: warning: format '%u' expects a matching 'unsigned int' argument [-Wformat=]
>         5 | #define KERN_SOH        "\001"          /* ASCII Start Of Header */
>           |                         ^~~~~~
>     include/linux/printk.h:427:25: note: in definition of macro 'printk_index_wrap'
>       427 |                 _p_func(_fmt, ##__VA_ARGS__);                           \
>           |                         ^~~~
>     include/linux/printk.h:129:17: note: in expansion of macro 'printk'
>       129 |                 printk(fmt, ##__VA_ARGS__);             \
>           |                 ^~~~~~
>     include/linux/printk.h:585:9: note: in expansion of macro 'no_printk'
>       585 |         no_printk(KERN_DEBUG pr_fmt(fmt), ##__VA_ARGS__)
>           |         ^~~~~~~~~
>     include/linux/kern_levels.h:15:25: note: in expansion of macro 'KERN_SOH'
>        15 | #define KERN_DEBUG      KERN_SOH "7"    /* debug-level messages */
>           |                         ^~~~~~~~
>     include/linux/printk.h:585:19: note: in expansion of macro 'KERN_DEBUG'
>       585 |         no_printk(KERN_DEBUG pr_fmt(fmt), ##__VA_ARGS__)
>           |                   ^~~~~~~~~~
>     include/linux/ceph/ceph_debug.h:50:9: note: in expansion of macro 'pr_debug'
>        50 |         pr_debug(" [%pU %llu] %s: " fmt, &client->fsid,                 \
>           |         ^~~~~~~~
>     fs/ceph/inode.c:794:25: note: in expansion of macro 'doutc'
>       794 |                         doutc(cl, "%s truncate_seq %u -> %u\n",
>           |                         ^~~~~
>
>
> vim +5 include/linux/kern_levels.h
>
> 314ba3520e513a Joe Perches 2012-07-30  4
> 04d2c8c83d0e3a Joe Perches 2012-07-30 @5  #define KERN_SOH	"\001"		/* ASCII Start Of Header */
> 04d2c8c83d0e3a Joe Perches 2012-07-30  6  #define KERN_SOH_ASCII	'\001'
> 04d2c8c83d0e3a Joe Perches 2012-07-30  7
>
> :::::: The code at line 5 was first introduced by commit
> :::::: 04d2c8c83d0e3ac5f78aeede51babb3236200112 printk: convert the format for KERN_<LEVEL> to a 2 byte pattern
>
> :::::: TO: Joe Perches <joe@perches.com>
> :::::: CC: Linus Torvalds <torvalds@linux-foundation.org>
>


      reply	other threads:[~2023-11-10  0:45 UTC|newest]

Thread overview: 2+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2023-11-09 20:10 [ceph-client:testing 5/17] include/linux/kern_levels.h:5:25: warning: format '%s' expects argument of type 'char *', but argument 5 has type 'u32' {aka 'unsigned int'} kernel test robot
2023-11-10  0:45 ` Xiubo Li [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=b91a9c36-3709-0449-3c89-aa733cfe67d4@redhat.com \
    --to=xiubli@redhat.com \
    --cc=ceph-devel@vger.kernel.org \
    --cc=lkp@intel.com \
    --cc=oe-kbuild-all@lists.linux.dev \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).