From: Ilya Dryomov <idryomov@gmail.com>
To: Xiubo Li <xiubli@redhat.com>
Cc: Eric Biggers <ebiggers@kernel.org>,
ceph-devel@vger.kernel.org, linux-fscrypt@vger.kernel.org,
stable@vger.kernel.org
Subject: Re: [PATCH] ceph: select FS_ENCRYPTION_ALGS if FS_ENCRYPTION
Date: Thu, 23 Nov 2023 21:46:13 +0100 [thread overview]
Message-ID: <CAOi1vP89X18T3oPWqhQqkpN-MY2LJJAhX2ms-OFTaV7dn8G8Zg@mail.gmail.com> (raw)
In-Reply-To: <9df30dc2-bc1c-b0fc-156f-baad37def05b@redhat.com>
On Thu, Nov 23, 2023 at 5:32 AM Xiubo Li <xiubli@redhat.com> wrote:
>
>
> On 11/23/23 11:08, Eric Biggers wrote:
> > From: Eric Biggers <ebiggers@google.com>
> >
> > The kconfig options for filesystems that support FS_ENCRYPTION are
> > supposed to select FS_ENCRYPTION_ALGS. This is needed to ensure that
> > required crypto algorithms get enabled as loadable modules or builtin as
> > is appropriate for the set of enabled filesystems. Do this for CEPH_FS
> > so that there aren't any missing algorithms if someone happens to have
> > CEPH_FS as their only enabled filesystem that supports encryption.
> >
> > Fixes: f061feda6c54 ("ceph: add fscrypt ioctls and ceph.fscrypt.auth vxattr")
> > Cc: stable@vger.kernel.org
> > Signed-off-by: Eric Biggers <ebiggers@google.com>
> > ---
> > fs/ceph/Kconfig | 1 +
> > 1 file changed, 1 insertion(+)
> >
> > diff --git a/fs/ceph/Kconfig b/fs/ceph/Kconfig
> > index 94df854147d35..7249d70e1a43f 100644
> > --- a/fs/ceph/Kconfig
> > +++ b/fs/ceph/Kconfig
> > @@ -1,19 +1,20 @@
> > # SPDX-License-Identifier: GPL-2.0-only
> > config CEPH_FS
> > tristate "Ceph distributed file system"
> > depends on INET
> > select CEPH_LIB
> > select LIBCRC32C
> > select CRYPTO_AES
> > select CRYPTO
> > select NETFS_SUPPORT
> > + select FS_ENCRYPTION_ALGS if FS_ENCRYPTION
> > default n
> > help
> > Choose Y or M here to include support for mounting the
> > experimental Ceph distributed file system. Ceph is an extremely
> > scalable file system designed to provide high performance,
> > reliable access to petabytes of storage.
> >
> > More information at https://ceph.io/.
> >
> > If unsure, say N.
> >
> > base-commit: 9b6de136b5f0158c60844f85286a593cb70fb364
>
> Thanks Eric. This looks good to me.
>
> Reviewed-by: Xiubo Li <xiubli@redhat.com>
Applied.
Thanks,
Ilya
prev parent reply other threads:[~2023-11-23 20:46 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-11-23 3:08 [PATCH] ceph: select FS_ENCRYPTION_ALGS if FS_ENCRYPTION Eric Biggers
2023-11-23 4:32 ` Xiubo Li
2023-11-23 20:46 ` Ilya Dryomov [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=CAOi1vP89X18T3oPWqhQqkpN-MY2LJJAhX2ms-OFTaV7dn8G8Zg@mail.gmail.com \
--to=idryomov@gmail.com \
--cc=ceph-devel@vger.kernel.org \
--cc=ebiggers@kernel.org \
--cc=linux-fscrypt@vger.kernel.org \
--cc=stable@vger.kernel.org \
--cc=xiubli@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).