From: Xiubo Li <xiubli@redhat.com>
To: Eric Biggers <ebiggers@kernel.org>
Cc: linux-fscrypt@vger.kernel.org, tytso@mit.edu, jaegeuk@kernel.org,
linux-kernel@vger.kernel.org, idryomov@gmail.com,
ceph-devel@vger.kernel.org, jlayton@kernel.org,
vshankar@redhat.com, mchangir@redhat.com
Subject: Re: [PATCH v2] fscrypt: to make sure the inode->i_blkbits is correctly set
Date: Thu, 1 Feb 2024 10:59:35 +0800 [thread overview]
Message-ID: <2fccdb02-3b66-40b9-a0d7-a79fe7c5580a@redhat.com> (raw)
In-Reply-To: <20240201024828.GA1526@sol.localdomain>
On 2/1/24 10:48, Eric Biggers wrote:
> On Thu, Feb 01, 2024 at 08:35:25AM +0800, xiubli@redhat.com wrote:
>> From: Xiubo Li <xiubli@redhat.com>
>>
>> The inode->i_blkbits should be already set before calling
>> fscrypt_get_encryption_info() and it will use this to setup the
>> ci_data_unit_bits later.
>>
>> URL: https://tracker.ceph.com/issues/64035
>> Signed-off-by: Xiubo Li <xiubli@redhat.com>
> Thanks, applied. I adjusted the commit message to make it clear what the patch
> actually does:
>
> commit 5befc19caec93f0088595b4d28baf10658c27a0f
> Author: Xiubo Li <xiubli@redhat.com>
> Date: Thu Feb 1 08:35:25 2024 +0800
>
> fscrypt: explicitly require that inode->i_blkbits be set
>
> Document that fscrypt_prepare_new_inode() requires inode->i_blkbits to
> be set, and make it WARN if it's not. This would have made the CephFS
> bug https://tracker.ceph.com/issues/64035 a bit easier to debug.
>
> Signed-off-by: Xiubo Li <xiubli@redhat.com>
> Link: https://lore.kernel.org/r/20240201003525.1788594-1-xiubli@redhat.com
> Signed-off-by: Eric Biggers <ebiggers@google.com>
>
Ack, thanks Eric.
- Xiubo
prev parent reply other threads:[~2024-02-01 2:59 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-02-01 0:35 [PATCH v2] fscrypt: to make sure the inode->i_blkbits is correctly set xiubli
2024-02-01 2:48 ` Eric Biggers
2024-02-01 2:59 ` Xiubo Li [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=2fccdb02-3b66-40b9-a0d7-a79fe7c5580a@redhat.com \
--to=xiubli@redhat.com \
--cc=ceph-devel@vger.kernel.org \
--cc=ebiggers@kernel.org \
--cc=idryomov@gmail.com \
--cc=jaegeuk@kernel.org \
--cc=jlayton@kernel.org \
--cc=linux-fscrypt@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=mchangir@redhat.com \
--cc=tytso@mit.edu \
--cc=vshankar@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).