CEPH-Devel archive mirror
 help / color / mirror / Atom feed
From: Xiubo Li <xiubli@redhat.com>
To: Sebastian Hasler <sebastian.hasler@sec.uni-stuttgart.de>
Cc: ceph-devel@vger.kernel.org
Subject: Re: [PATCH] ceph: fail the open_by_handle_at() if the dentry is being unlinked
Date: Tue, 12 Sep 2023 20:51:50 +0800	[thread overview]
Message-ID: <27e9617d-ef66-8110-f082-04ad29805a16@redhat.com> (raw)
In-Reply-To: <a9b51955-0f27-d802-4716-988af03a25e9@sec.uni-stuttgart.de>


On 9/11/23 18:07, Sebastian Hasler wrote:
> On 11/09/2023 05:21, Xiubo Li wrote:
>
>> "This will generally not work if the file has  a  link  count of 
>> zero  (files  created  with  O_TMPFILE and without O_EXCL are an 
>> exception)."
> In this sentence, "generally" probably means "typically", so it 
> depends on the specific file system's behavior. I don't know the 
> CephFS behavior in this case. However, at least files created with 
> O_TMPFILE are an exception. Does CephFS support creating files with 
> O_TMPFILE? Such files can (and often will) go from the unlinked and 
> open state to the linked and closed state.
>
Hmm, yeah. I didn't see anywhere is disallowing to create with 
O_TMPFILE. Let me have a look at this case carefully later.

Thanks very much for your reporting Sebastian.

- Xiubo



      reply	other threads:[~2023-09-12 12:52 UTC|newest]

Thread overview: 8+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2022-08-04  8:06 [PATCH] ceph: fail the open_by_handle_at() if the dentry is being unlinked xiubli
2022-08-04 16:25 ` Jeff Layton
2023-09-06 16:58 ` Sebastian Hasler
2023-09-07  2:05   ` Xiubo Li
2023-09-07 11:57     ` Sebastian Hasler
2023-09-11  3:21       ` Xiubo Li
2023-09-11 10:07         ` Sebastian Hasler
2023-09-12 12:51           ` Xiubo Li [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=27e9617d-ef66-8110-f082-04ad29805a16@redhat.com \
    --to=xiubli@redhat.com \
    --cc=ceph-devel@vger.kernel.org \
    --cc=sebastian.hasler@sec.uni-stuttgart.de \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).