From: Christian Brauner <brauner@kernel.org>
To: Linux regressions mailing list <regressions@lists.linux.dev>
Cc: David Howells <dhowells@redhat.com>,
Christian Brauner <christian@brauner.io>,
Eric Van Hensbergen <ericvh@kernel.org>,
Dominique Martinet <asmadeus@codewreck.org>,
Jeff Layton <jlayton@kernel.org>,
Matthew Wilcox <willy@infradead.org>,
netfs@lists.linux.dev, linux-afs@lists.infradead.org,
linux-cifs@vger.kernel.org, linux-nfs@vger.kernel.org,
ceph-devel@vger.kernel.org, v9fs@lists.linux.dev,
linux-erofs@lists.ozlabs.org, linux-fsdevel@vger.kernel.org,
linux-mm@kvack.org, linux-kernel@vger.kernel.org,
linux_oss@crudebyte.com
Subject: Re: [PATCH 2/2] netfs: Fix missing zero-length check in unbuffered write
Date: Tue, 20 Feb 2024 10:51:26 +0100 [thread overview]
Message-ID: <20240220-autoteile-enthoben-a9a16739b2b9@brauner> (raw)
In-Reply-To: <960e015a-ec2e-42c2-bd9e-4aa47ab4ef2a@leemhuis.info>
On Mon, Feb 19, 2024 at 09:38:33AM +0100, Linux regression tracking (Thorsten Leemhuis) wrote:
> On 29.01.24 10:49, David Howells wrote:
> > Fix netfs_unbuffered_write_iter() to return immediately if
> > generic_write_checks() returns 0, indicating there's nothing to write.
> > Note that netfs_file_write_iter() already does this.
> >
> > Also, whilst we're at it, put in checks for the size being zero before we
> > even take the locks. Note that generic_write_checks() can still reduce the
> > size to zero, so we still need that check.
> >
> > Without this, a warning similar to the following is logged to dmesg:
> >
> > netfs: Zero-sized write [R=1b6da]
> >
> > and the syscall fails with EIO, e.g.:
> >
> > /sbin/ldconfig.real: Writing of cache extension data failed: Input/output error
> >
> > This can be reproduced on 9p by:
> >
> > xfs_io -f -c 'pwrite 0 0' /xfstest.test/foo
> >
> > Fixes: 153a9961b551 ("netfs: Implement unbuffered/DIO write support")
> > Reported-by: Eric Van Hensbergen <ericvh@kernel.org>
> > Link: https://lore.kernel.org/r/ZbQUU6QKmIftKsmo@FV7GG9FTHL/
>
> David, thx for fixing Eric's regression, which I'm tracking.
>
> Christian, just wondering: that patch afaics is sitting in vfs.netfs for
> about three weeks now -- is that intentional or did it maybe fell
> through the cracks somehow?
I've moved it to vfs.fixes now and will send later this week. Thanks for
the reminder!
next prev parent reply other threads:[~2024-02-20 9:51 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-01-29 9:49 [PATCH 0/2] netfs: Miscellaneous fixes David Howells
2024-01-29 9:49 ` [PATCH 1/2] netfs: Fix i_dio_count leak on DIO read past i_size David Howells
2024-01-29 12:41 ` Jeff Layton
2024-01-29 9:49 ` [PATCH 2/2] netfs: Fix missing zero-length check in unbuffered write David Howells
2024-01-29 12:43 ` Jeff Layton
2024-01-30 21:57 ` Dominique Martinet
2024-02-19 8:38 ` Linux regression tracking (Thorsten Leemhuis)
2024-02-20 9:51 ` Christian Brauner [this message]
2024-01-29 13:53 ` [PATCH 0/2] netfs: Miscellaneous fixes Christian Brauner
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20240220-autoteile-enthoben-a9a16739b2b9@brauner \
--to=brauner@kernel.org \
--cc=asmadeus@codewreck.org \
--cc=ceph-devel@vger.kernel.org \
--cc=christian@brauner.io \
--cc=dhowells@redhat.com \
--cc=ericvh@kernel.org \
--cc=jlayton@kernel.org \
--cc=linux-afs@lists.infradead.org \
--cc=linux-cifs@vger.kernel.org \
--cc=linux-erofs@lists.ozlabs.org \
--cc=linux-fsdevel@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mm@kvack.org \
--cc=linux-nfs@vger.kernel.org \
--cc=linux_oss@crudebyte.com \
--cc=netfs@lists.linux.dev \
--cc=regressions@lists.linux.dev \
--cc=v9fs@lists.linux.dev \
--cc=willy@infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).