From: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
To: Max Kellermann <max.kellermann@ionos.com>
Cc: Jens Axboe <axboe@kernel.dk>,
"Rafael J. Wysocki" <rafael@kernel.org>,
Ilya Dryomov <idryomov@gmail.com>,
Dongsheng Yang <dongsheng.yang@easystack.cn>,
Dmitry Torokhov <dmitry.torokhov@gmail.com>,
Bjorn Helgaas <bhelgaas@google.com>,
Rodolfo Giometti <giometti@enneenne.com>,
Alessandro Zummo <a.zummo@towertech.it>,
Alexandre Belloni <alexandre.belloni@bootlin.com>,
Jiri Slaby <jirislaby@kernel.org>, Mark Fasheh <mark@fasheh.com>,
Joel Becker <jlbec@evilplan.org>,
Joseph Qi <joseph.qi@linux.alibaba.com>,
Andrew Morton <akpm@linux-foundation.org>,
linux-block@vger.kernel.org, linux-kernel@vger.kernel.org,
ceph-devel@vger.kernel.org, linux-input@vger.kernel.org,
linux-pci@vger.kernel.org, linux-rtc@vger.kernel.org,
linux-serial@vger.kernel.org, ocfs2-devel@lists.linux.dev,
linux-mm@kvack.org
Subject: Re: [PATCH 7/7] block, drivers: make lots of attribute_group globals const
Date: Mon, 9 Oct 2023 19:30:12 +0200 [thread overview]
Message-ID: <2023100944-sandpit-bronco-3db4@gregkh> (raw)
In-Reply-To: <20231009165741.746184-7-max.kellermann@ionos.com>
On Mon, Oct 09, 2023 at 06:57:40PM +0200, Max Kellermann wrote:
> This moves those variables to the ".rodata" section which reduces the
> kernel size a bit and protects the variables by putting them on
> read-only pages at runtime.
The kernel size should still be the same overall, you are just moving
pointers from one section to another, right?
If not, what are the numbers, show them please.
But step back, are you SURE you can make these attribute group pointers
const? They are modified by some subsystems by adding or removing items
from the lists, so why does the core need to change for that?
thanks,
greg k-h
prev parent reply other threads:[~2023-10-09 17:30 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <20231009165741.746184-1-max.kellermann@ionos.com>
2023-10-09 16:57 ` [PATCH 7/7] block, drivers: make lots of attribute_group globals const Max Kellermann
2023-10-09 17:30 ` Greg Kroah-Hartman [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=2023100944-sandpit-bronco-3db4@gregkh \
--to=gregkh@linuxfoundation.org \
--cc=a.zummo@towertech.it \
--cc=akpm@linux-foundation.org \
--cc=alexandre.belloni@bootlin.com \
--cc=axboe@kernel.dk \
--cc=bhelgaas@google.com \
--cc=ceph-devel@vger.kernel.org \
--cc=dmitry.torokhov@gmail.com \
--cc=dongsheng.yang@easystack.cn \
--cc=giometti@enneenne.com \
--cc=idryomov@gmail.com \
--cc=jirislaby@kernel.org \
--cc=jlbec@evilplan.org \
--cc=joseph.qi@linux.alibaba.com \
--cc=linux-block@vger.kernel.org \
--cc=linux-input@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mm@kvack.org \
--cc=linux-pci@vger.kernel.org \
--cc=linux-rtc@vger.kernel.org \
--cc=linux-serial@vger.kernel.org \
--cc=mark@fasheh.com \
--cc=max.kellermann@ionos.com \
--cc=ocfs2-devel@lists.linux.dev \
--cc=rafael@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).