From: Ilya Dryomov <idryomov@gmail.com>
To: ceph-devel@vger.kernel.org
Cc: Dongsheng Yang <dongsheng.yang@easystack.cn>
Subject: [PATCH 0/4] rbd: fix a deadlock around header_rwsem and lock_rwsem
Date: Mon, 25 Sep 2023 21:40:30 +0200 [thread overview]
Message-ID: <20230925194036.197899-1-idryomov@gmail.com> (raw)
Hello,
This fixes a deadlock which can occur when a watch error is hit while
the RBD driver is still recovering from a previous watch error. This
lock cycle was discovered during some performance tests.
Thanks,
Ilya
Ilya Dryomov (4):
rbd: move rbd_dev_refresh() definition
rbd: decouple header read-in from updating rbd_dev->header
rbd: decouple parent info read-in from updating rbd_dev
rbd: take header_rwsem in rbd_dev_refresh() only when updating
drivers/block/rbd.c | 412 ++++++++++++++++++++++++--------------------
1 file changed, 225 insertions(+), 187 deletions(-)
--
2.41.0
next reply other threads:[~2023-09-25 19:41 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-09-25 19:40 Ilya Dryomov [this message]
2023-09-25 19:40 ` [PATCH 1/4] rbd: move rbd_dev_refresh() definition Ilya Dryomov
2023-09-25 19:40 ` [PATCH 2/4] rbd: decouple header read-in from updating rbd_dev->header Ilya Dryomov
2023-09-25 19:40 ` [PATCH 3/4] rbd: decouple parent info read-in from updating rbd_dev Ilya Dryomov
2023-09-25 19:40 ` [PATCH 4/4] rbd: take header_rwsem in rbd_dev_refresh() only when updating Ilya Dryomov
2023-09-26 8:23 ` Dongsheng Yang
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20230925194036.197899-1-idryomov@gmail.com \
--to=idryomov@gmail.com \
--cc=ceph-devel@vger.kernel.org \
--cc=dongsheng.yang@easystack.cn \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).