From: David Gibson <david@gibson.dropbear.id.au>
To: Ian Zimmerman <itz@very.loosely.org>
Cc: Ccan Mailinglist <ccan@lists.ozlabs.org>
Subject: Re: make check fails in coroutine module
Date: Tue, 26 Mar 2019 15:31:29 +1100 [thread overview]
Message-ID: <20190326043129.GP9393@umbus.fritz.box> (raw)
In-Reply-To: <20190317223944.rebtzvfszp63qrze@matica.foolinux.mooo.com>
[-- Attachment #1.1: Type: text/plain, Size: 1776 bytes --]
On Sun, Mar 17, 2019 at 03:39:44PM -0700, Ian Zimmerman wrote:
> cc -g3 -ggdb -Wall -Wstrict-prototypes -Wold-style-definition -Wundef -Wmissing-prototypes -Wmissing-declarations -Wpointer-arith -Wwrite-strings -DCCAN_STR_DEBUG=1 -I. -MMD -MP -MFccan/coroutine/coroutine.o.d -MTccan/coroutine/coroutine.o -c ccan/coroutine/coroutine.c -o ccan/coroutine/coroutine.o
> tools/ccanlint/ccanlint -s --deps-fail-ignore ccan/coroutine/ && touch ccan/coroutine/.ok
> coroutine: Module's run and api tests pass (tests_pass): FAIL (+0/3)
> /home/itz/git/ccan/ccan/coroutine/test/api-2.c:1..10
> ok 1 - coroutine_stack_check(stack1, NULL) == stack1
> ok 2 - coroutine_stack_size(stack1) == bufsz - COROUTINE_STK_OVERHEAD
> ok 3 - coroutine_stack_check(stack2, NULL) == stack2
> ok 4 - coroutine_stack_size(stack2) == bufsz - COROUTINE_STK_OVERHEAD
> sh: line 1: 24908 Segmentation fault (core dumped) valgrind -q --leak-check=full --log-fd=3 /tmp/ccanlint-24709.1804289383/api-2 3> /tmp/ccanlint-24709.1804289383/api-2.valgrind-log
>
> ... more (use -vv to see them all)
> coroutine: Total score: 35/43 FAIL!
> make: *** [Makefile:78: ccan/coroutine/.ok] Error 1
>
> Perhaps it is relevant that the configurator check causing the segfault
> - as discussed in the other thread - is HAVE_POINTER_SAFE_MAKECONTEXT
> which, I believe, is only used by coroutine module.
>
> Platform: x86_64, Fedora 28, gcc 8.3.1, glibc 2.27. I didn't set any
> special build flags or anything.
Urgh, yeah, it's broken. Finding time to debug and fix it is proving
difficult.
--
David Gibson | I'll have my music baroque, and my code
david AT gibson.dropbear.id.au | minimalist, thank you. NOT _the_ _other_
| _way_ _around_!
http://www.ozlabs.org/~dgibson
[-- Attachment #1.2: signature.asc --]
[-- Type: application/pgp-signature, Size: 833 bytes --]
[-- Attachment #2: Type: text/plain, Size: 127 bytes --]
_______________________________________________
ccan mailing list
ccan@lists.ozlabs.org
https://lists.ozlabs.org/listinfo/ccan
next prev parent reply other threads:[~2019-03-26 4:40 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-03-17 22:39 make check fails in coroutine module Ian Zimmerman
2019-03-26 4:31 ` David Gibson [this message]
2019-03-26 19:58 ` Ian Zimmerman
2019-03-27 12:08 ` David Gibson
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20190326043129.GP9393@umbus.fritz.box \
--to=david@gibson.dropbear.id.au \
--cc=ccan@lists.ozlabs.org \
--cc=itz@very.loosely.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).