From: Kevin Locke <kevin@kevinlocke.name>
To: David Gibson <david@gibson.dropbear.id.au>
Cc: ccan@lists.ozlabs.org
Subject: Re: dgraph, tlist, tcon: MSVC error due to array of flexible structs
Date: Tue, 1 Aug 2017 23:38:22 -0600 [thread overview]
Message-ID: <20170802053822.jnwbadhcaztgborr@kevinolos> (raw)
In-Reply-To: <20170801052205.GO2652@umbus.fritz.box>
On Tue, 2017-08-01 at 15:22 +1000, David Gibson wrote:
> On Thu, Sep 22, 2016 at 10:31:16PM -0600, Kevin Locke wrote:
>> [...]
>>
>> The issue is that MSVC supports flexible array members, but does not
>> support arrays of structs with flexible array members. My
>> understanding is that such support is not required by C99 or C11, but
>> I don't know whether such support is common beyond Clang/GCC.
>>
>> Is there any interest in supporting such compilers? If so, I can see
>> a few potential fixes:
>>
>> [...]
>>
>> 3. Change TLIST to use TCON_WRAP? I don't understand TLIST/TCON well
>> enough to know if this is really an option. Hopefully an expert can
>> weigh in here.
>
> I've now done this for tlist and several other modules, we should have
> a much better chance of compiling on windows.
Great stuff! Thanks for all of your work to make the changes!
As soon as I get a chance I'll take another look at building with MSVC
and see what hurdles exist and how feasible it might be to get the
ccan tools compiling.
--
Cheers, | kevin@kevinlocke.name | XMPP: kevin@kevinlocke.name
Kevin | https://kevinlocke.name | IRC: kevinoid on freenode
_______________________________________________
ccan mailing list
ccan@lists.ozlabs.org
https://lists.ozlabs.org/listinfo/ccan
prev parent reply other threads:[~2017-08-02 5:47 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-09-23 4:31 dgraph, tlist, tcon: MSVC error due to array of flexible structs Kevin Locke
2016-09-27 4:45 ` David Gibson
2016-09-28 2:10 ` Rusty Russell
2016-09-28 3:12 ` David Gibson
2017-08-01 5:22 ` David Gibson
2017-08-02 5:38 ` Kevin Locke [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20170802053822.jnwbadhcaztgborr@kevinolos \
--to=kevin@kevinlocke.name \
--cc=ccan@lists.ozlabs.org \
--cc=david@gibson.dropbear.id.au \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).