From: David Gibson <david@gibson.dropbear.id.au>
To: Rusty Russell <rusty@rustcorp.com.au>
Cc: ccan@lists.ozlabs.org, rusty@rustcoorp.com.au
Subject: Re: [PATCH 4/4] Correctly include dependencies for nested modules
Date: Mon, 2 May 2016 13:33:42 +0400 [thread overview]
Message-ID: <20160502093342.GA2313@littlecatz> (raw)
In-Reply-To: <87fuu25qy9.fsf@rustcorp.com.au>
[-- Attachment #1.1: Type: text/plain, Size: 667 bytes --]
On Sun, May 01, 2016 at 02:12:54PM +0930, Paul 'Rusty' Russell wrote:
> David Gibson <david@gibson.dropbear.id.au> writes:
> > Currently we pull auto-generated dependencies into the Makefile with
> > include ccan/*/*.d. That will omit any .d files from nested modules,
> > meaning things might not be correctly rebuilt there.
> >
> > Correct this by using the list of modules instead of a 1-level wildcard.
>
> Thanks, these look great, please apply.
Done.
--
David Gibson | I'll have my music baroque, and my code
david AT gibson.dropbear.id.au | minimalist, thank you. NOT _the_ _other_
| _way_ _around_!
http://www.ozlabs.org/~dgibson
[-- Attachment #1.2: signature.asc --]
[-- Type: application/pgp-signature, Size: 819 bytes --]
[-- Attachment #2: Type: text/plain, Size: 127 bytes --]
_______________________________________________
ccan mailing list
ccan@lists.ozlabs.org
https://lists.ozlabs.org/listinfo/ccan
prev parent reply other threads:[~2016-05-02 9:34 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-04-30 8:01 [PATCH 0/4] Cleanups to ccan build David Gibson
2016-04-30 8:01 ` [PATCH 1/4] Add missing files to make clean David Gibson
2016-04-30 8:01 ` [PATCH 2/4] Clean up use of 'rm' in Makefiles David Gibson
2016-04-30 8:01 ` [PATCH 3/4] Exclude system headers from .d files David Gibson
2016-04-30 8:01 ` [PATCH 4/4] Correctly include dependencies for nested modules David Gibson
2016-05-01 4:42 ` Rusty Russell
2016-05-02 9:33 ` David Gibson [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20160502093342.GA2313@littlecatz \
--to=david@gibson.dropbear.id.au \
--cc=ccan@lists.ozlabs.org \
--cc=rusty@rustcoorp.com.au \
--cc=rusty@rustcorp.com.au \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).