From: David Gibson <david@gibson.dropbear.id.au>
To: Dan Good <dan@dancancode.com>
Cc: ccan <ccan@lists.ozlabs.org>
Subject: Re: altstack causing travis-ci failures
Date: Sun, 27 Mar 2016 15:39:28 +1100 [thread overview]
Message-ID: <20160327043928.GA15156@voom.fritz.box> (raw)
In-Reply-To: <CACNkOJPk7O27tKdOxoF9BipEfN=hKHkgA-9=mztyVku_mbePsA@mail.gmail.com>
[-- Attachment #1.1: Type: text/plain, Size: 2022 bytes --]
On Fri, Mar 25, 2016 at 10:06:51PM +0000, Dan Good wrote:
> David did some remarkable investigation into it about a month ago. The
> code has always worked on the Red Hat based distros I use, and David
> patched it to work for Ubuntu 12.04; so it seems unlikely to me that any
> real person would be affected. I suppose I'll try to talk to the Travis
> people about the specifics of their environment.
Yeah, working out why it is failing under Travis is a real pain. I'm
actually tempted to add altstack to MODS_EXCLUDE so it doesn't break
the travis builds any more. It's kind of nasty, but then all the
things in MODS_EXCLUDE are a bit nasty.
> On Fri, Mar 25, 2016 at 10:14 AM Andrew Jeffery <andrew@aj.id.au> wrote:
>
> > Hey Dan,
> >
> > I'm seeing a ccanlint failure for altstack on Travis-CI, e.g[1]:
> >
> > ...
> > tools/ccanlint/ccanlint --deps-fail-ignore -s ccan/aga
> > tools/ccanlint/ccanlint --deps-fail-ignore -s ccan/agar
> > agar: Total score: 36/38
> > tools/ccanlint/ccanlint --deps-fail-ignore -s ccan/altstack
> > altstack: Total score: 31/36 FAIL!
> > make: *** [summary-check-altstack] Error 1
> > tools/ccanlint/ccanlint --deps-fail-ignore -s ccan/antithread
> > aga: Total score: 48/50
> > ...
> >
> > FWIW I haven't had this happen when running `make check` on my machine.
> > I ended up pushing the changes I was testing as the failure wasn't
> > related and wasn't something I could trigger locally (the commit tested
> > above is currently at the tip of master), but thought it would be
> > useful to highlight that something strange appears to be happening with
> > the altstack module, at least on Travis-CI.
> >
> > Cheers,
> >
> > Andrew
> >
> > [1] https://travis-ci.org/amboar/ccan/jobs/118466416#L534
--
David Gibson | I'll have my music baroque, and my code
david AT gibson.dropbear.id.au | minimalist, thank you. NOT _the_ _other_
| _way_ _around_!
http://www.ozlabs.org/~dgibson
[-- Attachment #1.2: signature.asc --]
[-- Type: application/pgp-signature, Size: 819 bytes --]
[-- Attachment #2: Type: text/plain, Size: 127 bytes --]
_______________________________________________
ccan mailing list
ccan@lists.ozlabs.org
https://lists.ozlabs.org/listinfo/ccan
prev parent reply other threads:[~2016-03-27 9:10 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-03-25 14:14 altstack causing travis-ci failures Andrew Jeffery
2016-03-25 22:06 ` Dan Good
2016-03-27 4:39 ` David Gibson [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20160327043928.GA15156@voom.fritz.box \
--to=david@gibson.dropbear.id.au \
--cc=ccan@lists.ozlabs.org \
--cc=dan@dancancode.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).