From: "Emilio G. Cota" <cota@braap.org>
To: ccan@lists.ozlabs.org
Subject: [PATCH] time: add timemono_since
Date: Tue, 27 Sep 2016 17:57:53 -0400 [thread overview]
Message-ID: <1475013473-18813-1-git-send-email-cota@braap.org> (raw)
time_mono()'s documentation references time_since(), which is nowhere
to be found.
A possible fix would be to just remove that stale reference.
Instead, this patch adds timemono_since(), which hopefully
captures the meaning of the original time_since().
Signed-off-by: Emilio G. Cota <cota@braap.org>
---
ccan/time/test/run-monotonic.c | 3 ++-
ccan/time/time.h | 13 ++++++++++++-
2 files changed, 14 insertions(+), 2 deletions(-)
diff --git a/ccan/time/test/run-monotonic.c b/ccan/time/test/run-monotonic.c
index ed70f3d..787ca68 100644
--- a/ccan/time/test/run-monotonic.c
+++ b/ccan/time/test/run-monotonic.c
@@ -7,7 +7,7 @@ int main(void)
struct timemono t1, t2;
struct timerel t3;
- plan_tests(2);
+ plan_tests(3);
/* Test time_mono */
t1 = time_mono();
@@ -19,6 +19,7 @@ int main(void)
t3.ts.tv_nsec = 0;
ok1(time_less(timemono_between(t1, t2), t3));
+ ok1(time_less(timemono_since(t1), t3));
return exit_status();
}
diff --git a/ccan/time/time.h b/ccan/time/time.h
index 5c916f4..54d92c5 100644
--- a/ccan/time/time.h
+++ b/ccan/time/time.h
@@ -127,7 +127,7 @@ struct timeabs time_now(void);
* This value is only really useful for measuring time intervals.
*
* See also:
- * time_since()
+ * timemono_since()
*/
struct timemono time_mono(void);
@@ -321,6 +321,17 @@ static inline struct timerel timemono_between(struct timemono recent,
}
/**
+ * timemono_since - elapsed monotonic time since @old
+ * @old: a monotonic time from the past.
+ */
+static inline struct timerel timemono_since(struct timemono old)
+{
+ struct timemono now = time_mono();
+
+ return timemono_between(now, old);
+}
+
+/**
* timeabs_sub - subtract a relative time from an absolute time
* @abs: the absolute time.
* @rel: the relative time.
--
2.5.0
_______________________________________________
ccan mailing list
ccan@lists.ozlabs.org
https://lists.ozlabs.org/listinfo/ccan
next reply other threads:[~2016-09-27 21:57 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-09-27 21:57 Emilio G. Cota [this message]
2016-09-28 1:26 ` [PATCH] time: add timemono_since David Gibson
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1475013473-18813-1-git-send-email-cota@braap.org \
--to=cota@braap.org \
--cc=ccan@lists.ozlabs.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).