From: Peter Korsgaard <peter@korsgaard.com>
To: "Yann E. MORIN" <yann.morin.1998@free.fr>
Cc: Petr Vorel <petr.vorel@gmail.com>,
Robert Marko <robimarko@gmail.com>,
buildroot@buildroot.org
Subject: Re: [Buildroot] [PATCH v2 1/1] kconfig/lxdialog: fix check() with GCC14
Date: Wed, 15 May 2024 15:22:30 +0200 [thread overview]
Message-ID: <8734qjryzt.fsf@dell.be.48ers.dk> (raw)
In-Reply-To: <ZjEx5n1J7XH2Or2Q@landeda> (Yann E. MORIN's message of "Tue, 30 Apr 2024 20:01:10 +0200")
>>>>> "Yann" == Yann E MORIN <yann.morin.1998@free.fr> writes:
> Robert, All,
> On 2024-04-08 23:16 +0200, Robert Marko spake thusly:
>> GCC14 now treats implicit int types as error so when check() from
>> check-lxdialog.sh is called to check whether we can link against ncurses
>> it will fail silently and the help text indicating to install ncurses is
>> printed.
>>
>> However, this is not due to missing ncurses but once the stderr redirect
>> to /dev/null is removed we can see the root cause:
>> <stdin>:2:1: error: return type defaults to ‘int’ [-Wimplicit-int]
>>
>> So, in order for menuconfig to work with GCC14 lets just specify the
>> return type of main() as int.
> I've also added a little note that there is no commit from the kernel
> tree that we can backport, because the kernel tree no longer has that
> script.
>> Signed-off-by: Robert Marko <robimarko@gmail.com>
>> Reviewed-by: Petr Vorel <petr.vorel@gmail.com>
>> Tested-by: Petr Vorel <petr.vorel@gmail.com>
> Applied to master with the little note abouve added, thanks.
Committed to 2024.02.x, thanks.
--
Bye, Peter Korsgaard
_______________________________________________
buildroot mailing list
buildroot@buildroot.org
https://lists.buildroot.org/mailman/listinfo/buildroot
prev parent reply other threads:[~2024-05-15 13:22 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-04-08 21:16 [Buildroot] [PATCH v2 1/1] kconfig/lxdialog: fix check() with GCC14 Robert Marko
2024-04-08 22:45 ` Petr Vorel
2024-04-30 18:01 ` Yann E. MORIN
2024-05-15 13:22 ` Peter Korsgaard [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=8734qjryzt.fsf@dell.be.48ers.dk \
--to=peter@korsgaard.com \
--cc=buildroot@buildroot.org \
--cc=petr.vorel@gmail.com \
--cc=robimarko@gmail.com \
--cc=yann.morin.1998@free.fr \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).