* [Buildroot] [PATCH 31/35] package/x265: fixes SITE since upstream repo was moved @ 2021-06-08 20:24 Edmundo Ferreira 2021-07-22 21:07 ` Thomas Petazzoni 0 siblings, 1 reply; 4+ messages in thread From: Edmundo Ferreira @ 2021-06-08 20:24 UTC (permalink / raw To: buildroot From: Edmundo Ferreira <fc.edmundo@gmail.com> Signed-off-by: Edmundo Ferreira <fc.edmundo@gmail.com> --- package/x265/x265.mk | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/package/x265/x265.mk b/package/x265/x265.mk index 872753eea8..2704360626 100644 --- a/package/x265/x265.mk +++ b/package/x265/x265.mk @@ -6,7 +6,7 @@ X265_VERSION = 3.3 X265_SOURCE = x265_$(X265_VERSION).tar.gz -X265_SITE = https://bitbucket.org/multicoreware/x265/downloads +X265_SITE = https://bitbucket.org/multicoreware/x265_git/downloads X265_LICENSE = GPL-2.0+ X265_LICENSE_FILES = COPYING X265_CPE_ID_VENDOR = multicorewareinc -- 2.31.1 ^ permalink raw reply related [flat|nested] 4+ messages in thread
* Re: [Buildroot] [PATCH 31/35] package/x265: fixes SITE since upstream repo was moved 2021-06-08 20:24 [Buildroot] [PATCH 31/35] package/x265: fixes SITE since upstream repo was moved Edmundo Ferreira @ 2021-07-22 21:07 ` Thomas Petazzoni 2021-07-22 21:52 ` Edmundo Ferreira 0 siblings, 1 reply; 4+ messages in thread From: Thomas Petazzoni @ 2021-07-22 21:07 UTC (permalink / raw To: Edmundo Ferreira; +Cc: Bernd Kuhls, Thijs Vermeir, buildroot Hello Edmundo, On Tue, 8 Jun 2021 22:24:34 +0200 Edmundo Ferreira <fc.edmundo@gmail.com> wrote: > From: Edmundo Ferreira <fc.edmundo@gmail.com> > > Signed-off-by: Edmundo Ferreira <fc.edmundo@gmail.com> Thanks a lot for your patch. There is indeed an issue as the current URL gives a 404. However, your patch doesn't fix it really: the hash of the tarball downloaded from this new URL is different, and so it gets rejected, and we fallback to sources.buildroot.net. See: >>> x265 3.3 Downloading wget --passive-ftp -nd -t 3 -O '/home/thomas/projets/buildroot/output/build/.x265_3.3.tar.gz.YfSH95/output' 'https://bitbucket.org/multicoreware/x265_git/downloads/x265_3.3.tar.gz' --2021-07-22 23:02:55-- https://bitbucket.org/multicoreware/x265_git/downloads/x265_3.3.tar.gz Resolving bitbucket.org (bitbucket.org)... 2406:da00:ff00::34cc:ea4a, 2406:da00:ff00::22c3:9b0a, 2406:da00:ff00::22c2:513, ... Connecting to bitbucket.org (bitbucket.org)|2406:da00:ff00::34cc:ea4a|:443... connected. HTTP request sent, awaiting response... 302 Found Location: https://bbuseruploads.s3.amazonaws.com/c105f477-2003-4e12-80e5-06858cf7e40b/downloads/4247de9f-1484-4e31-b9b8-f69a505230de/x265_3.3.tar.gz?Signature=GAYCnXeWIBn3w2FX%2FLeQnQ%2Bi2c8%3D&Expires=1626989576&AWSAccessKeyId=AKIA6KOSE3BNJRRFUUX6&versionId=s9fflFgseT2OEPm_eT1G33eu3G8q_RJ5&response-content-disposition=attachment%3B%20filename%3D%22x265_3.3.tar.gz%22&response-content-encoding=None [following] --2021-07-22 23:02:56-- https://bbuseruploads.s3.amazonaws.com/c105f477-2003-4e12-80e5-06858cf7e40b/downloads/4247de9f-1484-4e31-b9b8-f69a505230de/x265_3.3.tar.gz?Signature=GAYCnXeWIBn3w2FX%2FLeQnQ%2Bi2c8%3D&Expires=1626989576&AWSAccessKeyId=AKIA6KOSE3BNJRRFUUX6&versionId=s9fflFgseT2OEPm_eT1G33eu3G8q_RJ5&response-content-disposition=attachment%3B%20filename%3D%22x265_3.3.tar.gz%22&response-content-encoding=None Resolving bbuseruploads.s3.amazonaws.com (bbuseruploads.s3.amazonaws.com)... 52.216.98.243 Connecting to bbuseruploads.s3.amazonaws.com (bbuseruploads.s3.amazonaws.com)|52.216.98.243|:443... connected. HTTP request sent, awaiting response... 200 OK Length: 1508513 (1,4M) [application/x-gzip] Saving to: ‘/home/thomas/projets/buildroot/output/build/.x265_3.3.tar.gz.YfSH95/output’ /home/thomas/projets/buildroo 100%[===============================================>] 1,44M 930KB/s in 1,6s 2021-07-22 23:02:59 (930 KB/s) - ‘/home/thomas/projets/buildroot/output/build/.x265_3.3.tar.gz.YfSH95/output’ saved [1508513/1508513] ERROR: x265_3.3.tar.gz has wrong md5 hash: ERROR: expected: 0c8c747b59b5411dea8cf557554636c1 ERROR: got : be6ea7a139b01fa6f2614d5c1197492d ERROR: Incomplete download, or man-in-the-middle (MITM) attack wget --passive-ftp -nd -t 3 -O '/home/thomas/projets/buildroot/output/build/.x265_3.3.tar.gz.N9OBTM/output' 'http://sources.buildroot.net/x265/x265_3.3.tar.gz' --2021-07-22 23:02:59-- http://sources.buildroot.net/x265/x265_3.3.tar.gz Resolving sources.buildroot.net (sources.buildroot.net)... 2606:4700:20::681a:125, 2606:4700:20::681a:25, 2606:4700:20::ac43:4838, ... Connecting to sources.buildroot.net (sources.buildroot.net)|2606:4700:20::681a:125|:80... connected. HTTP request sent, awaiting response... 200 OK Length: 1438685 (1,4M) [application/x-gtar-compressed] Saving to: ‘/home/thomas/projets/buildroot/output/build/.x265_3.3.tar.gz.N9OBTM/output’ /home/thomas/projets/buildroo 100%[===============================================>] 1,37M 1,12MB/s in 1,2s 2021-07-22 23:03:00 (1,12 MB/s) - ‘/home/thomas/projets/buildroot/output/build/.x265_3.3.tar.gz.N9OBTM/output’ saved [1438685/1438685] x265_3.3.tar.gz: OK (md5: 0c8c747b59b5411dea8cf557554636c1) x265_3.3.tar.gz: OK (sha256: f26e148ed1f4dfb33fd1eb3ff5e60e08078d1b2017e88bcbb045b3fb58300b9c) Could you have a look? We can't simply change the hash, because that would mean the tarball cached on sources.buildroot.net is no longer valid. And we cannot delete it, as it would break older Buildroot releases, which use the current hash for the x265 tarball. Usually, the easiest path is to update the URL *and* do a version bump at the same time. Best regards, Thomas -- Thomas Petazzoni, co-owner and CEO, Bootlin Embedded Linux and Kernel engineering https://bootlin.com _______________________________________________ buildroot mailing list buildroot@busybox.net http://lists.busybox.net/mailman/listinfo/buildroot ^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: [Buildroot] [PATCH 31/35] package/x265: fixes SITE since upstream repo was moved 2021-07-22 21:07 ` Thomas Petazzoni @ 2021-07-22 21:52 ` Edmundo Ferreira 2021-07-23 6:45 ` Thomas Petazzoni 0 siblings, 1 reply; 4+ messages in thread From: Edmundo Ferreira @ 2021-07-22 21:52 UTC (permalink / raw To: Thomas Petazzoni; +Cc: Bernd Kuhls, Thijs Vermeir, buildroot [-- Attachment #1.1: Type: text/plain, Size: 4998 bytes --] Sure I'll check for a version bump on the new URL. Sorry for that. I didn't take into consideration the caching of the packages in sources.buildroot.com. As for the hash being wrong that is strange since I have that patch and our gitlab pipelines are fine. Maybe I'm being victim of our own package cache. I'll investigate and let you know ASAP. Best regards Ed On Thu, Jul 22, 2021, 23:07 Thomas Petazzoni <thomas.petazzoni@bootlin.com> wrote: > Hello Edmundo, > > On Tue, 8 Jun 2021 22:24:34 +0200 > Edmundo Ferreira <fc.edmundo@gmail.com> wrote: > > > From: Edmundo Ferreira <fc.edmundo@gmail.com> > > > > Signed-off-by: Edmundo Ferreira <fc.edmundo@gmail.com> > > Thanks a lot for your patch. There is indeed an issue as the current > URL gives a 404. However, your patch doesn't fix it really: the hash of > the tarball downloaded from this new URL is different, and so it gets > rejected, and we fallback to sources.buildroot.net. See: > > >>> x265 3.3 Downloading > wget --passive-ftp -nd -t 3 -O > '/home/thomas/projets/buildroot/output/build/.x265_3.3.tar.gz.YfSH95/output' > 'https://bitbucket.org/multicoreware/x265_git/downloads/x265_3.3.tar.gz' > --2021-07-22 23:02:55-- > https://bitbucket.org/multicoreware/x265_git/downloads/x265_3.3.tar.gz > Resolving bitbucket.org (bitbucket.org)... 2406:da00:ff00::34cc:ea4a, > 2406:da00:ff00::22c3:9b0a, 2406:da00:ff00::22c2:513, ... > Connecting to bitbucket.org (bitbucket.org)|2406:da00:ff00::34cc:ea4a|:443... > connected. > HTTP request sent, awaiting response... 302 Found > Location: > https://bbuseruploads.s3.amazonaws.com/c105f477-2003-4e12-80e5-06858cf7e40b/downloads/4247de9f-1484-4e31-b9b8-f69a505230de/x265_3.3.tar.gz?Signature=GAYCnXeWIBn3w2FX%2FLeQnQ%2Bi2c8%3D&Expires=1626989576&AWSAccessKeyId=AKIA6KOSE3BNJRRFUUX6&versionId=s9fflFgseT2OEPm_eT1G33eu3G8q_RJ5&response-content-disposition=attachment%3B%20filename%3D%22x265_3.3.tar.gz%22&response-content-encoding=None > [following] > --2021-07-22 23:02:56-- > https://bbuseruploads.s3.amazonaws.com/c105f477-2003-4e12-80e5-06858cf7e40b/downloads/4247de9f-1484-4e31-b9b8-f69a505230de/x265_3.3.tar.gz?Signature=GAYCnXeWIBn3w2FX%2FLeQnQ%2Bi2c8%3D&Expires=1626989576&AWSAccessKeyId=AKIA6KOSE3BNJRRFUUX6&versionId=s9fflFgseT2OEPm_eT1G33eu3G8q_RJ5&response-content-disposition=attachment%3B%20filename%3D%22x265_3.3.tar.gz%22&response-content-encoding=None > Resolving bbuseruploads.s3.amazonaws.com (bbuseruploads.s3.amazonaws.com)... > 52.216.98.243 > Connecting to bbuseruploads.s3.amazonaws.com ( > bbuseruploads.s3.amazonaws.com)|52.216.98.243|:443... connected. > HTTP request sent, awaiting response... 200 OK > Length: 1508513 (1,4M) [application/x-gzip] > Saving to: > ‘/home/thomas/projets/buildroot/output/build/.x265_3.3.tar.gz.YfSH95/output’ > > /home/thomas/projets/buildroo > 100%[===============================================>] 1,44M 930KB/s > in 1,6s > > 2021-07-22 23:02:59 (930 KB/s) - > ‘/home/thomas/projets/buildroot/output/build/.x265_3.3.tar.gz.YfSH95/output’ > saved [1508513/1508513] > > ERROR: x265_3.3.tar.gz has wrong md5 hash: > ERROR: expected: 0c8c747b59b5411dea8cf557554636c1 > ERROR: got : be6ea7a139b01fa6f2614d5c1197492d > ERROR: Incomplete download, or man-in-the-middle (MITM) attack > wget --passive-ftp -nd -t 3 -O > '/home/thomas/projets/buildroot/output/build/.x265_3.3.tar.gz.N9OBTM/output' > 'http://sources.buildroot.net/x265/x265_3.3.tar.gz' > --2021-07-22 23:02:59-- http://sources.buildroot.net/x265/x265_3.3.tar.gz > Resolving sources.buildroot.net (sources.buildroot.net)... > 2606:4700:20::681a:125, 2606:4700:20::681a:25, 2606:4700:20::ac43:4838, ... > Connecting to sources.buildroot.net (sources.buildroot.net)|2606:4700:20::681a:125|:80... > connected. > HTTP request sent, awaiting response... 200 OK > Length: 1438685 (1,4M) [application/x-gtar-compressed] > Saving to: > ‘/home/thomas/projets/buildroot/output/build/.x265_3.3.tar.gz.N9OBTM/output’ > > /home/thomas/projets/buildroo > 100%[===============================================>] 1,37M 1,12MB/s > in 1,2s > > 2021-07-22 23:03:00 (1,12 MB/s) - > ‘/home/thomas/projets/buildroot/output/build/.x265_3.3.tar.gz.N9OBTM/output’ > saved [1438685/1438685] > > x265_3.3.tar.gz: OK (md5: 0c8c747b59b5411dea8cf557554636c1) > x265_3.3.tar.gz: OK (sha256: > f26e148ed1f4dfb33fd1eb3ff5e60e08078d1b2017e88bcbb045b3fb58300b9c) > > Could you have a look? We can't simply change the hash, because that > would mean the tarball cached on sources.buildroot.net is no longer > valid. And we cannot delete it, as it would break older Buildroot > releases, which use the current hash for the x265 tarball. > > Usually, the easiest path is to update the URL *and* do a version bump > at the same time. > > Best regards, > > Thomas > -- > Thomas Petazzoni, co-owner and CEO, Bootlin > Embedded Linux and Kernel engineering > https://bootlin.com > [-- Attachment #1.2: Type: text/html, Size: 9052 bytes --] [-- Attachment #2: Type: text/plain, Size: 145 bytes --] _______________________________________________ buildroot mailing list buildroot@busybox.net http://lists.busybox.net/mailman/listinfo/buildroot ^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: [Buildroot] [PATCH 31/35] package/x265: fixes SITE since upstream repo was moved 2021-07-22 21:52 ` Edmundo Ferreira @ 2021-07-23 6:45 ` Thomas Petazzoni 0 siblings, 0 replies; 4+ messages in thread From: Thomas Petazzoni @ 2021-07-23 6:45 UTC (permalink / raw To: Edmundo Ferreira; +Cc: Bernd Kuhls, Thijs Vermeir, buildroot Hello Edmundo, On Thu, 22 Jul 2021 23:52:05 +0200 Edmundo Ferreira <fc.edmundo@gmail.com> wrote: > Sure I'll check for a version bump on the new URL. > > Sorry for that. I didn't take into consideration the caching of the > packages in sources.buildroot.com. > > As for the hash being wrong that is strange since I have that patch and our > gitlab pipelines are fine. Maybe I'm being victim of our own package cache. Probably not, check carefully your logs: just like me, you're probably falling back to sources.buildroot.net, because the hash in package/x265/x265.hash doesn't watch what you are downloading from the new location. Best regards, Thomas -- Thomas Petazzoni, co-owner and CEO, Bootlin Embedded Linux and Kernel engineering https://bootlin.com _______________________________________________ buildroot mailing list buildroot@busybox.net http://lists.busybox.net/mailman/listinfo/buildroot ^ permalink raw reply [flat|nested] 4+ messages in thread
end of thread, other threads:[~2021-07-23 6:45 UTC | newest] Thread overview: 4+ messages (download: mbox.gz follow: Atom feed -- links below jump to the message on this page -- 2021-06-08 20:24 [Buildroot] [PATCH 31/35] package/x265: fixes SITE since upstream repo was moved Edmundo Ferreira 2021-07-22 21:07 ` Thomas Petazzoni 2021-07-22 21:52 ` Edmundo Ferreira 2021-07-23 6:45 ` Thomas Petazzoni
This is a public inbox, see mirroring instructions for how to clone and mirror all data and code used for this inbox; as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).