* [Buildroot] [PATCH v2, 1/2] package/libkrb5: add openssl optional dependency
@ 2021-06-13 9:10 Fabrice Fontaine
2021-06-13 9:10 ` [Buildroot] [PATCH v2, 2/2] package/libkrb5: requires DES, MD4 and RC4 support in openssl Fabrice Fontaine
2021-06-13 16:08 ` [Buildroot] [PATCH v2, 1/2] package/libkrb5: add openssl optional dependency Yann E. MORIN
0 siblings, 2 replies; 6+ messages in thread
From: Fabrice Fontaine @ 2021-06-13 9:10 UTC (permalink / raw
To: buildroot
openssl is an optional dependency which is enabled by default since at
least 2007 and
https://github.com/krb5/krb5/commit/4c17f25c0f106ec8e3aad2cee4e7a24f66b5a65d
Signed-off-by: Fabrice Fontaine <fontaine.fabrice@gmail.com>
---
Changes v1 -> v2 (after review of Yann E. Morin):
- Add openssl optional dependency
package/libkrb5/libkrb5.mk | 15 +++++++++++++++
1 file changed, 15 insertions(+)
diff --git a/package/libkrb5/libkrb5.mk b/package/libkrb5/libkrb5.mk
index e4f3fa4186..794cedd33c 100644
--- a/package/libkrb5/libkrb5.mk
+++ b/package/libkrb5/libkrb5.mk
@@ -41,6 +41,21 @@ else
LIBKRB5_CONF_OPTS += --without-ldap
endif
+ifeq ($(BR2_PACKAGE_OPENSSL),y)
+LIBKRB5_CONF_OPTS += \
+ --enable-pkinit \
+ --with-crypto-impl=openssl \
+ --with-spake-openssl \
+ --with-tls-impl=openssl
+LIBKRB5_DEPENDENCIES += openssl
+else
+LIBKRB5_CONF_OPTS += \
+ --disable-pkinit \
+ --with-crypto-impl=builtin \
+ --without-spake-openssl \
+ --without-tls-impl
+endif
+
ifeq ($(BR2_PACKAGE_LIBEDIT),y)
LIBKRB5_CONF_OPTS += --with-libedit
LIBKRB5_DEPENDENCIES += host-pkgconf libedit
--
2.30.2
^ permalink raw reply related [flat|nested] 6+ messages in thread
* [Buildroot] [PATCH v2, 2/2] package/libkrb5: requires DES, MD4 and RC4 support in openssl
2021-06-13 9:10 [Buildroot] [PATCH v2, 1/2] package/libkrb5: add openssl optional dependency Fabrice Fontaine
@ 2021-06-13 9:10 ` Fabrice Fontaine
2021-06-13 16:08 ` [Buildroot] [PATCH v2, 1/2] package/libkrb5: add openssl optional dependency Yann E. MORIN
1 sibling, 0 replies; 6+ messages in thread
From: Fabrice Fontaine @ 2021-06-13 9:10 UTC (permalink / raw
To: buildroot
Enable DES, MD4 and RC4 in openssl to fix build failure raised since
commit a83d41867c8d69a77d5cd0a665aa216af5340359
Fixes:
- http://autobuild.buildroot.org/results/d73b477bd2064aee076f9debfd8d3346c63ba657
Signed-off-by: Fabrice Fontaine <fontaine.fabrice@gmail.com>
---
package/libkrb5/Config.in | 3 +++
1 file changed, 3 insertions(+)
diff --git a/package/libkrb5/Config.in b/package/libkrb5/Config.in
index 2e24c87229..3357d4ad04 100644
--- a/package/libkrb5/Config.in
+++ b/package/libkrb5/Config.in
@@ -3,6 +3,9 @@ config BR2_PACKAGE_LIBKRB5
# needs fork()
depends on BR2_USE_MMU
depends on !BR2_STATIC_LIBS
+ select BR2_PACKAGE_LIBOPENSSL_ENABLE_DES if BR2_PACKAGE_LIBOPENSSL
+ select BR2_PACKAGE_LIBOPENSSL_ENABLE_MD4 if BR2_PACKAGE_LIBOPENSSL
+ select BR2_PACKAGE_LIBOPENSSL_ENABLE_RC4 if BR2_PACKAGE_LIBOPENSSL
help
Kerberos is a system for authenticating users and services
on a network. Kerberos is a trusted third-party service.
--
2.30.2
^ permalink raw reply related [flat|nested] 6+ messages in thread
* [Buildroot] [PATCH v2, 1/2] package/libkrb5: add openssl optional dependency
2021-06-13 9:10 [Buildroot] [PATCH v2, 1/2] package/libkrb5: add openssl optional dependency Fabrice Fontaine
2021-06-13 9:10 ` [Buildroot] [PATCH v2, 2/2] package/libkrb5: requires DES, MD4 and RC4 support in openssl Fabrice Fontaine
@ 2021-06-13 16:08 ` Yann E. MORIN
2021-06-13 16:41 ` Fabrice Fontaine
1 sibling, 1 reply; 6+ messages in thread
From: Yann E. MORIN @ 2021-06-13 16:08 UTC (permalink / raw
To: buildroot
Fabrice, All,
On 2021-06-13 11:10 +0200, Fabrice Fontaine spake thusly:
> openssl is an optional dependency which is enabled by default since at
> least 2007 and
> https://github.com/krb5/krb5/commit/4c17f25c0f106ec8e3aad2cee4e7a24f66b5a65d
>
> Signed-off-by: Fabrice Fontaine <fontaine.fabrice@gmail.com>
Applied to master, thanks.
I squashed the two commits together, because selecting the openssl
options is really just part of fixing the openssl dependency of libkrb5.
Thank you! :-)
Regards,
Yann E. MORIN.
> ---
> Changes v1 -> v2 (after review of Yann E. Morin):
> - Add openssl optional dependency
>
> package/libkrb5/libkrb5.mk | 15 +++++++++++++++
> 1 file changed, 15 insertions(+)
>
> diff --git a/package/libkrb5/libkrb5.mk b/package/libkrb5/libkrb5.mk
> index e4f3fa4186..794cedd33c 100644
> --- a/package/libkrb5/libkrb5.mk
> +++ b/package/libkrb5/libkrb5.mk
> @@ -41,6 +41,21 @@ else
> LIBKRB5_CONF_OPTS += --without-ldap
> endif
>
> +ifeq ($(BR2_PACKAGE_OPENSSL),y)
> +LIBKRB5_CONF_OPTS += \
> + --enable-pkinit \
> + --with-crypto-impl=openssl \
> + --with-spake-openssl \
> + --with-tls-impl=openssl
> +LIBKRB5_DEPENDENCIES += openssl
> +else
> +LIBKRB5_CONF_OPTS += \
> + --disable-pkinit \
> + --with-crypto-impl=builtin \
> + --without-spake-openssl \
> + --without-tls-impl
> +endif
> +
> ifeq ($(BR2_PACKAGE_LIBEDIT),y)
> LIBKRB5_CONF_OPTS += --with-libedit
> LIBKRB5_DEPENDENCIES += host-pkgconf libedit
> --
> 2.30.2
>
> _______________________________________________
> buildroot mailing list
> buildroot at busybox.net
> http://lists.busybox.net/mailman/listinfo/buildroot
--
.-----------------.--------------------.------------------.--------------------.
| Yann E. MORIN | Real-Time Embedded | /"\ ASCII RIBBON | Erics' conspiracy: |
| +33 662 376 056 | Software Designer | \ / CAMPAIGN | ___ |
| +33 561 099 427 `------------.-------: X AGAINST | \e/ There is no |
| http://ymorin.is-a-geek.org/ | _/*\_ | / \ HTML MAIL | v conspiracy. |
'------------------------------^-------^------------------^--------------------'
^ permalink raw reply [flat|nested] 6+ messages in thread
* [Buildroot] [PATCH v2, 1/2] package/libkrb5: add openssl optional dependency
2021-06-13 16:08 ` [Buildroot] [PATCH v2, 1/2] package/libkrb5: add openssl optional dependency Yann E. MORIN
@ 2021-06-13 16:41 ` Fabrice Fontaine
2021-06-13 20:02 ` Yann E. MORIN
0 siblings, 1 reply; 6+ messages in thread
From: Fabrice Fontaine @ 2021-06-13 16:41 UTC (permalink / raw
To: buildroot
Hi Yann,
Le dim. 13 juin 2021 ? 18:08, Yann E. MORIN <yann.morin.1998@free.fr> a ?crit :
>
> Fabrice, All,
>
> On 2021-06-13 11:10 +0200, Fabrice Fontaine spake thusly:
> > openssl is an optional dependency which is enabled by default since at
> > least 2007 and
> > https://github.com/krb5/krb5/commit/4c17f25c0f106ec8e3aad2cee4e7a24f66b5a65d
> >
> > Signed-off-by: Fabrice Fontaine <fontaine.fabrice@gmail.com>
>
> Applied to master, thanks.
>
> I squashed the two commits together, because selecting the openssl
> options is really just part of fixing the openssl dependency of libkrb5.
Perhaps, it would have been better to keep them separate as Peter will
probably only want to backport the first patch to 2020.xx and 2021.xx
branches?
>
> Thank you! :-)
>
> Regards,
> Yann E. MORIN.
>
> > ---
> > Changes v1 -> v2 (after review of Yann E. Morin):
> > - Add openssl optional dependency
> >
> > package/libkrb5/libkrb5.mk | 15 +++++++++++++++
> > 1 file changed, 15 insertions(+)
> >
> > diff --git a/package/libkrb5/libkrb5.mk b/package/libkrb5/libkrb5.mk
> > index e4f3fa4186..794cedd33c 100644
> > --- a/package/libkrb5/libkrb5.mk
> > +++ b/package/libkrb5/libkrb5.mk
> > @@ -41,6 +41,21 @@ else
> > LIBKRB5_CONF_OPTS += --without-ldap
> > endif
> >
> > +ifeq ($(BR2_PACKAGE_OPENSSL),y)
> > +LIBKRB5_CONF_OPTS += \
> > + --enable-pkinit \
> > + --with-crypto-impl=openssl \
> > + --with-spake-openssl \
> > + --with-tls-impl=openssl
> > +LIBKRB5_DEPENDENCIES += openssl
> > +else
> > +LIBKRB5_CONF_OPTS += \
> > + --disable-pkinit \
> > + --with-crypto-impl=builtin \
> > + --without-spake-openssl \
> > + --without-tls-impl
> > +endif
> > +
> > ifeq ($(BR2_PACKAGE_LIBEDIT),y)
> > LIBKRB5_CONF_OPTS += --with-libedit
> > LIBKRB5_DEPENDENCIES += host-pkgconf libedit
> > --
> > 2.30.2
> >
> > _______________________________________________
> > buildroot mailing list
> > buildroot at busybox.net
> > http://lists.busybox.net/mailman/listinfo/buildroot
>
> --
> .-----------------.--------------------.------------------.--------------------.
> | Yann E. MORIN | Real-Time Embedded | /"\ ASCII RIBBON | Erics' conspiracy: |
> | +33 662 376 056 | Software Designer | \ / CAMPAIGN | ___ |
> | +33 561 099 427 `------------.-------: X AGAINST | \e/ There is no |
> | http://ymorin.is-a-geek.org/ | _/*\_ | / \ HTML MAIL | v conspiracy. |
> '------------------------------^-------^------------------^--------------------'
Best Regards,
Fabrice
^ permalink raw reply [flat|nested] 6+ messages in thread
* [Buildroot] [PATCH v2, 1/2] package/libkrb5: add openssl optional dependency
2021-06-13 16:41 ` Fabrice Fontaine
@ 2021-06-13 20:02 ` Yann E. MORIN
2021-06-21 19:08 ` Peter Korsgaard
0 siblings, 1 reply; 6+ messages in thread
From: Yann E. MORIN @ 2021-06-13 20:02 UTC (permalink / raw
To: buildroot
Fabrice, All,
On 2021-06-13 18:41 +0200, Fabrice Fontaine spake thusly:
> Le dim. 13 juin 2021 ? 18:08, Yann E. MORIN <yann.morin.1998@free.fr> a ?crit :
> > On 2021-06-13 11:10 +0200, Fabrice Fontaine spake thusly:
> > > openssl is an optional dependency which is enabled by default since at
> > > least 2007 and
> > > https://github.com/krb5/krb5/commit/4c17f25c0f106ec8e3aad2cee4e7a24f66b5a65d
> > >
> > > Signed-off-by: Fabrice Fontaine <fontaine.fabrice@gmail.com>
> > I squashed the two commits together, because selecting the openssl
> > options is really just part of fixing the openssl dependency of libkrb5.
> Perhaps, it would have been better to keep them separate as Peter will
> probably only want to backport the first patch to 2020.xx and 2021.xx
> branches?
That's true.
However, semantically, I still believe the two patches should really
have been one, because if we don't select the options when we explicitly
add the openssl depenency, then we are still introducing a failure.
And I don't think that it is unreasonable to expect that some commits
have to be adapted when backported.
Regards,
Yann E. MORIN.
--
.-----------------.--------------------.------------------.--------------------.
| Yann E. MORIN | Real-Time Embedded | /"\ ASCII RIBBON | Erics' conspiracy: |
| +33 662 376 056 | Software Designer | \ / CAMPAIGN | ___ |
| +33 561 099 427 `------------.-------: X AGAINST | \e/ There is no |
| http://ymorin.is-a-geek.org/ | _/*\_ | / \ HTML MAIL | v conspiracy. |
'------------------------------^-------^------------------^--------------------'
^ permalink raw reply [flat|nested] 6+ messages in thread
* [Buildroot] [PATCH v2, 1/2] package/libkrb5: add openssl optional dependency
2021-06-13 20:02 ` Yann E. MORIN
@ 2021-06-21 19:08 ` Peter Korsgaard
0 siblings, 0 replies; 6+ messages in thread
From: Peter Korsgaard @ 2021-06-21 19:08 UTC (permalink / raw
To: buildroot
>>>>> "Yann" == Yann E MORIN <yann.morin.1998@free.fr> writes:
> Fabrice, All,
> On 2021-06-13 18:41 +0200, Fabrice Fontaine spake thusly:
>> Le dim. 13 juin 2021 ? 18:08, Yann E. MORIN <yann.morin.1998@free.fr> a ?crit :
>> > On 2021-06-13 11:10 +0200, Fabrice Fontaine spake thusly:
>> > > openssl is an optional dependency which is enabled by default since at
>> > > least 2007 and
>> > > https://github.com/krb5/krb5/commit/4c17f25c0f106ec8e3aad2cee4e7a24f66b5a65d
>> > >
>> > > Signed-off-by: Fabrice Fontaine <fontaine.fabrice@gmail.com>
>> > I squashed the two commits together, because selecting the openssl
>> > options is really just part of fixing the openssl dependency of libkrb5.
>> Perhaps, it would have been better to keep them separate as Peter will
>> probably only want to backport the first patch to 2020.xx and 2021.xx
>> branches?
> That's true.
> However, semantically, I still believe the two patches should really
> have been one, because if we don't select the options when we explicitly
> add the openssl depenency, then we are still introducing a failure.
> And I don't think that it is unreasonable to expect that some commits
> have to be adapted when backported.
Indeed. Committed to 2021.02.x and 2021.05.x, after dropping the openssl
options - thanks.
--
Bye, Peter Korsgaard
^ permalink raw reply [flat|nested] 6+ messages in thread
end of thread, other threads:[~2021-06-21 19:08 UTC | newest]
Thread overview: 6+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2021-06-13 9:10 [Buildroot] [PATCH v2, 1/2] package/libkrb5: add openssl optional dependency Fabrice Fontaine
2021-06-13 9:10 ` [Buildroot] [PATCH v2, 2/2] package/libkrb5: requires DES, MD4 and RC4 support in openssl Fabrice Fontaine
2021-06-13 16:08 ` [Buildroot] [PATCH v2, 1/2] package/libkrb5: add openssl optional dependency Yann E. MORIN
2021-06-13 16:41 ` Fabrice Fontaine
2021-06-13 20:02 ` Yann E. MORIN
2021-06-21 19:08 ` Peter Korsgaard
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).