From: Hangbin Liu <liuhangbin@gmail.com>
To: Nikolay Aleksandrov <razor@blackwall.org>
Cc: netdev@vger.kernel.org, kuba@kernel.org, roopa@nvidia.com,
bridge@lists.linux.dev, edumazet@google.com, pabeni@redhat.com
Subject: Re: [PATCH net] selftests: net: bridge: increase IGMP/MLD exclude timeout membership interval
Date: Tue, 14 May 2024 20:18:57 +0800 [thread overview]
Message-ID: <ZkNWsR04SdTpjWRZ@Laptop-X1> (raw)
In-Reply-To: <186278b5-b2d5-408e-8d89-8cdff6efe41a@blackwall.org>
On Tue, May 14, 2024 at 10:46:15AM +0300, Nikolay Aleksandrov wrote:
> >> diff --git a/tools/testing/selftests/net/forwarding/bridge_mld.sh b/tools/testing/selftests/net/forwarding/bridge_mld.sh
> >> index e2b9ff773c6b..f84ab2e65754 100755
> >> --- a/tools/testing/selftests/net/forwarding/bridge_mld.sh
> >> +++ b/tools/testing/selftests/net/forwarding/bridge_mld.sh
> >>
> >> $MZ $h1 -c 1 $MZPKT_ALLOW2 -q
> >> - sleep 3
> >> + sleep 5
> >> bridge -j -d -s mdb show dev br0 \
> >> | jq -e ".[].mdb[] | \
> >> select(.grp == \"$TEST_GROUP\" and \
> >
> > Maybe use a slow_wait to check the result?
> >
> > Thanks
> > Hangbin
>
> What would it improve? The wait is exact, we know how many seconds
> exactly so a plain sleep is enough and easier to backport if this
> is applied to -net.
I just afraid it fails on debug kernel with this exact time. If you think
the time is enough. I'm OK with it.
Thanks
Hangbin
next prev parent reply other threads:[~2024-05-14 12:19 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-05-13 10:52 [PATCH net] selftests: net: bridge: increase IGMP/MLD exclude timeout membership interval Nikolay Aleksandrov
2024-05-14 0:42 ` Hangbin Liu
2024-05-14 7:46 ` Nikolay Aleksandrov
2024-05-14 12:18 ` Hangbin Liu [this message]
2024-05-15 10:50 ` patchwork-bot+netdevbpf
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=ZkNWsR04SdTpjWRZ@Laptop-X1 \
--to=liuhangbin@gmail.com \
--cc=bridge@lists.linux.dev \
--cc=edumazet@google.com \
--cc=kuba@kernel.org \
--cc=netdev@vger.kernel.org \
--cc=pabeni@redhat.com \
--cc=razor@blackwall.org \
--cc=roopa@nvidia.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).