From: Simon Horman <simon.horman@corigine.com>
To: Nikolay Aleksandrov <razor@blackwall.org>
Cc: netdev@vger.kernel.org, bridge@lists.linux-foundation.org,
Abaci Robot <abaci@linux.alibaba.com>,
linux-kernel@vger.kernel.org, edumazet@google.com,
Yang Li <yang.lee@linux.alibaba.com>,
roopa@nvidia.com, kuba@kernel.org, pabeni@redhat.com,
davem@davemloft.net
Subject: Re: [Bridge] [PATCH -next] net: bridge: clean up one inconsistent indenting
Date: Wed, 8 Feb 2023 14:44:53 +0100 [thread overview]
Message-ID: <Y+OnVfu/3ot3Rk7f@corigine.com> (raw)
In-Reply-To: <4e9705d5-c6f7-0b08-6e45-b19bae1d248d@blackwall.org>
On Wed, Feb 08, 2023 at 02:31:39PM +0100, Nikolay Aleksandrov wrote:
> On 2/8/23 15:30, Nikolay Aleksandrov wrote:
> > On 2/8/23 15:04, Simon Horman wrote:
> > > On Wed, Feb 08, 2023 at 08:56:26AM +0800, Yang Li wrote:
> > > > ./net/bridge/br_netlink_tunnel.c:317:4-27: code aligned with
> > > > following code on line 318
> > > >
> > > > Reported-by: Abaci Robot <abaci@linux.alibaba.com>
> > > > Link: https://bugzilla.openanolis.cn/show_bug.cgi?id=3977
> > > > Signed-off-by: Yang Li <yang.lee@linux.alibaba.com>
> > >
> > > As you may need to respin this:
> > >
> > > Assuming this is targeting net-next, which seems likely to me,
> > > the subject should denote that. Something like this:
> > >
> > > [PATCH net-next] net: bridge: clean up one inconsistent indenting
> > >
> > > > ---
> > > > net/bridge/br_netlink_tunnel.c | 2 +-
> > > > 1 file changed, 1 insertion(+), 1 deletion(-)
> > > >
> > > > diff --git a/net/bridge/br_netlink_tunnel.c
> > > > b/net/bridge/br_netlink_tunnel.c
> > > > index 17abf092f7ca..eff949bfdd83 100644
> > > > --- a/net/bridge/br_netlink_tunnel.c
> > > > +++ b/net/bridge/br_netlink_tunnel.c
> > > > @@ -315,7 +315,7 @@ int br_process_vlan_tunnel_info(const struct
> > > > net_bridge *br,
> > > > if (curr_change)
> > > > *changed = curr_change;
> > > > - __vlan_tunnel_handle_range(p, &v_start, &v_end, v,
> > > > + __vlan_tunnel_handle_range(p, &v_start, &v_end, v,
> > > > curr_change);
> > >
> > > I think you also need to adjust the line immediately above.
> >
> > You meant below, right? :) i.e. "curr_change)", that seems to get
> > misaligned after the change and needs to be adjusted as well.
> >
>
> Oh I need coffee, I somehow was thinking about the line being changed
> instead of literally the line above your statement. :))
No problem. We are talking about the same line :)
> Anyway, ack.
prev parent reply other threads:[~2023-02-08 13:44 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-02-08 0:56 [Bridge] [PATCH -next] net: bridge: clean up one inconsistent indenting Yang Li
2023-02-08 11:49 ` Nikolay Aleksandrov
2023-02-08 13:04 ` Simon Horman
2023-02-08 13:30 ` Nikolay Aleksandrov
2023-02-08 13:31 ` Nikolay Aleksandrov
2023-02-08 13:44 ` Simon Horman [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=Y+OnVfu/3ot3Rk7f@corigine.com \
--to=simon.horman@corigine.com \
--cc=abaci@linux.alibaba.com \
--cc=bridge@lists.linux-foundation.org \
--cc=davem@davemloft.net \
--cc=edumazet@google.com \
--cc=kuba@kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=netdev@vger.kernel.org \
--cc=pabeni@redhat.com \
--cc=razor@blackwall.org \
--cc=roopa@nvidia.com \
--cc=yang.lee@linux.alibaba.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).