From: Date Huang <tjjh89017@hotmail.com>
To: Jiri Pirko <jiri@resnulli.us>
Cc: roopa@nvidia.com, razor@blackwall.org, netdev@vger.kernel.org,
bridge@lists.linux-foundation.org
Subject: Re: [PATCH] bridge: vlan: fix compressvlans manpage and usage
Date: Fri, 22 Mar 2024 20:33:06 +0800 [thread overview]
Message-ID: <MAZP287MB0503ED9A05F83485CABD2513E4312@MAZP287MB0503.INDP287.PROD.OUTLOOK.COM> (raw)
In-Reply-To: <Zf1SH2ZVfBG6O2EE@nanopsycho>
Hi Jiri
On 3/22/2024 5:40 PM, Jiri Pirko wrote:
> Fri, Mar 22, 2024 at 09:56:29AM CET, tjjh89017@hotmail.com wrote:
>> Add the missing 'compressvlans' to man page.
>> Fix the incorrect short opt for compressvlans and color
>> in usage.
>
> Split to 2 patches please.
>
> Please fix your prefix to be in format "[patch iproute2-next] xxx"
> to properly indicate the target project and tree.
Thank you, I will update this in v2.
>
>
>>
>> Signed-off-by: Date Huang <tjjh89017@hotmail.com>
>> ---
>> bridge/bridge.c | 2 +-
>> man/man8/bridge.8 | 5 +++++
>> 2 files changed, 6 insertions(+), 1 deletion(-)
>>
>> diff --git a/bridge/bridge.c b/bridge/bridge.c
>> index f4805092..345f5b5f 100644
>> --- a/bridge/bridge.c
>> +++ b/bridge/bridge.c
>> @@ -39,7 +39,7 @@ static void usage(void)
>> "where OBJECT := { link | fdb | mdb | vlan | vni | monitor }\n"
>> " OPTIONS := { -V[ersion] | -s[tatistics] | -d[etails] |\n"
>> " -o[neline] | -t[imestamp] | -n[etns] name |\n"
>> -" -c[ompressvlans] -color -p[retty] -j[son] }\n");
>> +" -compressvlans -c[olor] -p[retty] -j[son] }\n");
>
> From how I read the code, shouldn't this be rather:
> " -com[pressvlans] -c[olor] -p[retty] -j[son] }\n");
> ?
Agree with you, I will update it in v2.
>
>> exit(-1);
>> }
>>
>> diff --git a/man/man8/bridge.8 b/man/man8/bridge.8
>> index eeea4073..9a023227 100644
>> --- a/man/man8/bridge.8
>> +++ b/man/man8/bridge.8
>> @@ -22,6 +22,7 @@ bridge \- show / manipulate bridge addresses and devices
>> \fB\-s\fR[\fItatistics\fR] |
>> \fB\-n\fR[\fIetns\fR] name |
>> \fB\-b\fR[\fIatch\fR] filename |
>> +\fB\-compressvlans |
>> \fB\-c\fR[\fIolor\fR] |
>> \fB\-p\fR[\fIretty\fR] |
>> \fB\-j\fR[\fIson\fR] |
>> @@ -345,6 +346,10 @@ Don't terminate bridge command on errors in batch mode.
>> If there were any errors during execution of the commands, the application
>> return code will be non zero.
>>
>> +.TP
>> +.BR \-compressvlans
>> +Show compressed vlan list
>> +
>> .TP
>> .BR \-c [ color ][ = { always | auto | never }
>> Configure color output. If parameter is omitted or
>> --
>> 2.34.1
>>
>>
Thanks,
Date
prev parent reply other threads:[~2024-03-22 12:33 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-03-22 8:56 [PATCH] bridge: vlan: fix compressvlans manpage and usage Date Huang
2024-03-22 9:25 ` Nikolay Aleksandrov
2024-03-22 12:32 ` Date Huang
2024-03-22 9:40 ` Jiri Pirko
2024-03-22 12:33 ` Date Huang [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=MAZP287MB0503ED9A05F83485CABD2513E4312@MAZP287MB0503.INDP287.PROD.OUTLOOK.COM \
--to=tjjh89017@hotmail.com \
--cc=bridge@lists.linux-foundation.org \
--cc=jiri@resnulli.us \
--cc=netdev@vger.kernel.org \
--cc=razor@blackwall.org \
--cc=roopa@nvidia.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).