From: Elad Nachman <enachman@marvell.com>
To: Ido Schimmel <idosch@nvidia.com>,
"netdev@vger.kernel.org" <netdev@vger.kernel.org>,
"bridge@lists.linux-foundation.org"
<bridge@lists.linux-foundation.org>
Cc: "petrm@nvidia.com" <petrm@nvidia.com>,
"jiri@resnulli.us" <jiri@resnulli.us>,
"taspelund@nvidia.com" <taspelund@nvidia.com>,
"xiyou.wangcong@gmail.com" <xiyou.wangcong@gmail.com>,
"razor@blackwall.org" <razor@blackwall.org>,
"jhs@mojatatu.com" <jhs@mojatatu.com>,
"edumazet@google.com" <edumazet@google.com>,
"roopa@nvidia.com" <roopa@nvidia.com>,
"kuba@kernel.org" <kuba@kernel.org>,
"pabeni@redhat.com" <pabeni@redhat.com>,
"davem@davemloft.net" <davem@davemloft.net>
Subject: Re: [Bridge] [EXT] [RFC PATCH net-next 3/5] flow_offload: Reject matching on layer 2 miss
Date: Wed, 10 May 2023 09:57:36 +0000 [thread overview]
Message-ID: <BN9PR18MB42515532FEB4A498D39AB073DB779@BN9PR18MB4251.namprd18.prod.outlook.com> (raw)
In-Reply-To: <20230509070446.246088-4-idosch@nvidia.com>
> -----Original Message-----
> From: Ido Schimmel <idosch@nvidia.com>
> Sent: Tuesday, May 9, 2023 10:05 AM
> To: netdev@vger.kernel.org; bridge@lists.linux-foundation.org
> Cc: davem@davemloft.net; kuba@kernel.org; pabeni@redhat.com;
> edumazet@google.com; razor@blackwall.org; roopa@nvidia.com;
> jhs@mojatatu.com; xiyou.wangcong@gmail.com; jiri@resnulli.us;
> petrm@nvidia.com; taspelund@nvidia.com; Ido Schimmel
> <idosch@nvidia.com>
> Subject: [EXT] [RFC PATCH net-next 3/5] flow_offload: Reject matching on
> layer 2 miss
>
> External Email
>
> ----------------------------------------------------------------------
> Adjust drivers that support the 'FLOW_DISSECTOR_KEY_META' key to reject
> filters that try to match on the newly added layer 2 miss option. Add an
> extack message to clearly communicate the failure reason to user space.
>
> Example:
>
> # tc filter add dev swp1 egress pref 1 proto all flower skip_sw l2_miss true
> action drop
> Error: mlxsw_spectrum: Can't match on "l2_miss".
> We have an error talking to the kernel
>
> Signed-off-by: Ido Schimmel <idosch@nvidia.com>
> ---
> .../net/ethernet/marvell/prestera/prestera_flower.c | 6 ++++++
> drivers/net/ethernet/mellanox/mlx5/core/en_tc.c | 6 ++++++
> drivers/net/ethernet/mellanox/mlxsw/spectrum_flower.c | 6 ++++++
> drivers/net/ethernet/mscc/ocelot_flower.c | 10 ++++++++++
> 4 files changed, 28 insertions(+)
>
> diff --git a/drivers/net/ethernet/marvell/prestera/prestera_flower.c
> b/drivers/net/ethernet/marvell/prestera/prestera_flower.c
> index 91a478b75cbf..3e20e71b0f81 100644
> --- a/drivers/net/ethernet/marvell/prestera/prestera_flower.c
> +++ b/drivers/net/ethernet/marvell/prestera/prestera_flower.c
> @@ -148,6 +148,12 @@ static int prestera_flower_parse_meta(struct
> prestera_acl_rule *rule,
> __be16 key, mask;
>
> flow_rule_match_meta(f_rule, &match);
> +
> + if (match.mask->l2_miss) {
> + NL_SET_ERR_MSG_MOD(f->common.extack, "Can't match on
> \"l2_miss\"");
> + return -EOPNOTSUPP;
> + }
> +
> if (match.mask->ingress_ifindex != 0xFFFFFFFF) {
> NL_SET_ERR_MSG_MOD(f->common.extack,
> "Unsupported ingress ifindex mask"); diff --
> git a/drivers/net/ethernet/mellanox/mlx5/core/en_tc.c
> b/drivers/net/ethernet/mellanox/mlx5/core/en_tc.c
> index 728b82ce4031..516653568330 100644
> --- a/drivers/net/ethernet/mellanox/mlx5/core/en_tc.c
> +++ b/drivers/net/ethernet/mellanox/mlx5/core/en_tc.c
> @@ -2586,6 +2586,12 @@ static int mlx5e_flower_parse_meta(struct
> net_device *filter_dev,
> return 0;
>
> flow_rule_match_meta(rule, &match);
> +
> + if (match.mask->l2_miss) {
> + NL_SET_ERR_MSG_MOD(f->common.extack, "Can't match on
> \"l2_miss\"");
> + return -EOPNOTSUPP;
> + }
> +
> if (!match.mask->ingress_ifindex)
> return 0;
>
> diff --git a/drivers/net/ethernet/mellanox/mlxsw/spectrum_flower.c
> b/drivers/net/ethernet/mellanox/mlxsw/spectrum_flower.c
> index 594cdcb90b3d..6fec9223250b 100644
> --- a/drivers/net/ethernet/mellanox/mlxsw/spectrum_flower.c
> +++ b/drivers/net/ethernet/mellanox/mlxsw/spectrum_flower.c
> @@ -294,6 +294,12 @@ static int mlxsw_sp_flower_parse_meta(struct
> mlxsw_sp_acl_rule_info *rulei,
> return 0;
>
> flow_rule_match_meta(rule, &match);
> +
> + if (match.mask->l2_miss) {
> + NL_SET_ERR_MSG_MOD(f->common.extack, "Can't match on
> \"l2_miss\"");
> + return -EOPNOTSUPP;
> + }
> +
> if (match.mask->ingress_ifindex != 0xFFFFFFFF) {
> NL_SET_ERR_MSG_MOD(f->common.extack, "Unsupported
> ingress ifindex mask");
> return -EINVAL;
> diff --git a/drivers/net/ethernet/mscc/ocelot_flower.c
> b/drivers/net/ethernet/mscc/ocelot_flower.c
> index ee052404eb55..e0916afcddfb 100644
> --- a/drivers/net/ethernet/mscc/ocelot_flower.c
> +++ b/drivers/net/ethernet/mscc/ocelot_flower.c
> @@ -592,6 +592,16 @@ ocelot_flower_parse_key(struct ocelot *ocelot, int
> port, bool ingress,
> return -EOPNOTSUPP;
> }
>
> + if (flow_rule_match_key(rule, FLOW_DISSECTOR_KEY_META)) {
> + struct flow_match_meta match;
> +
> + flow_rule_match_meta(rule, &match);
> + if (match.mask->l2_miss) {
> + NL_SET_ERR_MSG_MOD(extack, "Can't match on
> \"l2_miss\"");
> + return -EOPNOTSUPP;
> + }
> + }
> +
> /* For VCAP ES0 (egress rewriter) we can match on the ingress port
> */
> if (!ingress) {
> ret = ocelot_flower_parse_indev(ocelot, port, f, filter);
> --
> 2.40.1
>
I have reviewed the prestera part. Looks straightforward enough.
Acked-by: Elad Nachman <enachman@marvell.com>
next prev parent reply other threads:[~2023-05-10 9:57 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-05-09 7:04 [Bridge] [RFC PATCH net-next 0/5] Add layer 2 miss indication and filtering Ido Schimmel
2023-05-09 7:04 ` [Bridge] [RFC PATCH net-next 1/5] skbuff: bridge: Add layer 2 miss indication Ido Schimmel
2023-05-09 7:04 ` [Bridge] [RFC PATCH net-next 2/5] net/sched: flower: Allow matching on layer 2 miss Ido Schimmel
2023-05-09 7:04 ` [Bridge] [RFC PATCH net-next 3/5] flow_offload: Reject " Ido Schimmel
2023-05-10 9:57 ` Elad Nachman [this message]
2023-05-09 7:04 ` [Bridge] [RFC PATCH net-next 4/5] mlxsw: spectrum_flower: Add ability to match " Ido Schimmel
2023-05-09 7:04 ` [Bridge] [RFC PATCH net-next 5/5] selftests: forwarding: Add layer 2 miss test cases Ido Schimmel
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=BN9PR18MB42515532FEB4A498D39AB073DB779@BN9PR18MB4251.namprd18.prod.outlook.com \
--to=enachman@marvell.com \
--cc=bridge@lists.linux-foundation.org \
--cc=davem@davemloft.net \
--cc=edumazet@google.com \
--cc=idosch@nvidia.com \
--cc=jhs@mojatatu.com \
--cc=jiri@resnulli.us \
--cc=kuba@kernel.org \
--cc=netdev@vger.kernel.org \
--cc=pabeni@redhat.com \
--cc=petrm@nvidia.com \
--cc=razor@blackwall.org \
--cc=roopa@nvidia.com \
--cc=taspelund@nvidia.com \
--cc=xiyou.wangcong@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).