From: Nikolay Aleksandrov <razor@blackwall.org>
To: Arnd Bergmann <arnd@kernel.org>,
netdev@vger.kernel.org, "David S. Miller" <davem@davemloft.net>,
Eric Dumazet <edumazet@google.com>,
Jakub Kicinski <kuba@kernel.org>, Paolo Abeni <pabeni@redhat.com>
Cc: bridge@lists.linux-foundation.org, linux-kernel@vger.kernel.org,
Arnd Bergmann <arnd@arndb.de>, Roopa Prabhu <roopa@nvidia.com>
Subject: Re: [Bridge] [PATCH 3/4] bridge: always declare tunnel functions
Date: Wed, 17 May 2023 10:33:03 +0300 [thread overview]
Message-ID: <63f12ee5-bd7d-a734-af98-e99196d84441@blackwall.org> (raw)
In-Reply-To: <20230516194625.549249-3-arnd@kernel.org>
On 16/05/2023 22:45, Arnd Bergmann wrote:
> From: Arnd Bergmann <arnd@arndb.de>
>
> When CONFIG_BRIDGE_VLAN_FILTERING is disabled, two functions are still
> defined but have no prototype or caller. This causes a W=1 warning for
> the missing prototypes:
>
> net/bridge/br_netlink_tunnel.c:29:6: error: no previous prototype for 'vlan_tunid_inrange' [-Werror=missing-prototypes]
> net/bridge/br_netlink_tunnel.c:199:5: error: no previous prototype for 'br_vlan_tunnel_info' [-Werror=missing-prototypes]
>
> The functions are already contitional on CONFIG_BRIDGE_VLAN_FILTERING,
> and I coulnd't easily figure out the right set of #ifdefs, so just
> move the declarations out of the #ifdef to avoid the warning,
> at a small cost in code size over a more elaborate fix.
>
> Signed-off-by: Arnd Bergmann <arnd@arndb.de>
> ---
> net/bridge/br_private_tunnel.h | 8 ++++----
> 1 file changed, 4 insertions(+), 4 deletions(-)
>
This should be for -net.
Fixes: 188c67dd1906 ("net: bridge: vlan options: add support for tunnel id dumping")
Fixes: 569da0822808 ("net: bridge: vlan options: add support for tunnel mapping set/del")
Acked-by: Nikolay Aleksandrov <razor@blackwall.org>
Thanks,
Nik
prev parent reply other threads:[~2023-05-17 7:33 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <20230516194625.549249-1-arnd@kernel.org>
2023-05-16 19:45 ` [Bridge] [PATCH 3/4] bridge: always declare tunnel functions Arnd Bergmann
2023-05-17 7:33 ` Nikolay Aleksandrov [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=63f12ee5-bd7d-a734-af98-e99196d84441@blackwall.org \
--to=razor@blackwall.org \
--cc=arnd@arndb.de \
--cc=arnd@kernel.org \
--cc=bridge@lists.linux-foundation.org \
--cc=davem@davemloft.net \
--cc=edumazet@google.com \
--cc=kuba@kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=netdev@vger.kernel.org \
--cc=pabeni@redhat.com \
--cc=roopa@nvidia.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).