From: Nikolay Aleksandrov <razor@blackwall.org>
To: Amit Cohen <amcohen@nvidia.com>, netdev@vger.kernel.org
Cc: mlxsw@nvidia.com, dsahern@kernel.org,
bridge@lists.linux-foundation.org, idosch@nvidia.com,
linux-kselftest@vger.kernel.org, roopa@nvidia.com,
kuba@kernel.org, pabeni@redhat.com, shuah@kernel.org,
davem@davemloft.net
Subject: Re: [Bridge] [PATCH net-next 00/11] Extend VXLAN driver to support FDB flushing
Date: Tue, 10 Oct 2023 21:50:42 +0300 [thread overview]
Message-ID: <4bf848f2-94a6-d941-645b-42309def1900@blackwall.org> (raw)
In-Reply-To: <20231009100618.2911374-1-amcohen@nvidia.com>
On 10/9/23 13:06, Amit Cohen wrote:
> The merge commit 92716869375b ("Merge branch 'br-flush-filtering'") added
> support for FDB flushing in bridge driver. Extend VXLAN driver to support
> FDB flushing also. Add support for filtering by fields which are relevant
> for VXLAN FDBs:
> * Source VNI
> * Nexthop ID
> * 'router' flag
> * Destination VNI
> * Destination Port
> * Destination IP
>
> Without this set, flush for VXLAN device fails:
> $ bridge fdb flush dev vx10
> RTNETLINK answers: Operation not supported
>
> With this set, such flush works with the relevant arguments, for example:
> $ bridge fdb flush dev vx10 vni 5000 dst 193.2.2.1
> < flush all vx10 entries with VNI 5000 and destination IP 193.2.2.1>
>
> Some preparations are required, handle them before adding flushing support
> in VXLAN driver. See more details in commit messages.
>
> Patch set overview:
> Patch #1 prepares flush policy to be used by VXLAN driver
> Patches #2-#3 are preparations in VXLAN driver
> Patch #4 adds an initial support for flushing in VXLAN driver
> Patches #5-#9 add support for filtering by several attributes
> Patch #10 adds a test for FDB flush with VXLAN
> Patch #11 extends the test to check FDB flush with bridge
>
> Amit Cohen (11):
> net: Handle bulk delete policy in bridge driver
> vxlan: vxlan_core: Make vxlan_flush() more generic for future use
> vxlan: vxlan_core: Do not skip default entry in vxlan_flush() by
> default
> vxlan: vxlan_core: Add support for FDB flush
> vxlan: vxlan_core: Support FDB flushing by source VNI
> vxlan: vxlan_core: Support FDB flushing by nexthop ID
> vxlan: vxlan_core: Support FDB flushing by destination VNI
> vxlan: vxlan_core: Support FDB flushing by destination port
> vxlan: vxlan_core: Support FDB flushing by destination IP
> selftests: Add test cases for FDB flush with VXLAN device
> selftests: fdb_flush: Add test cases for FDB flush with bridge device
>
> drivers/net/vxlan/vxlan_core.c | 207 +++++-
> include/linux/netdevice.h | 8 +-
> net/bridge/br_fdb.c | 29 +-
> net/bridge/br_private.h | 3 +-
> net/core/rtnetlink.c | 27 +-
> tools/testing/selftests/net/Makefile | 1 +
> tools/testing/selftests/net/fdb_flush.sh | 812 +++++++++++++++++++++++
> 7 files changed, 1049 insertions(+), 38 deletions(-)
> create mode 100755 tools/testing/selftests/net/fdb_flush.sh
>
Nice use of the flush api. :)
The set looks good to me. For the set:
Acked-by: Nikolay Aleksandrov <razor@blackwall.org>
next prev parent reply other threads:[~2023-10-10 18:50 UTC|newest]
Thread overview: 15+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-10-09 10:06 [Bridge] [PATCH net-next 00/11] Extend VXLAN driver to support FDB flushing Amit Cohen
2023-10-09 10:06 ` [Bridge] [PATCH net-next 01/11] net: Handle bulk delete policy in bridge driver Amit Cohen
2023-10-09 10:06 ` [Bridge] [PATCH net-next 02/11] vxlan: vxlan_core: Make vxlan_flush() more generic for future use Amit Cohen
2023-10-09 10:06 ` [Bridge] [PATCH net-next 03/11] vxlan: vxlan_core: Do not skip default entry in vxlan_flush() by default Amit Cohen
2023-10-09 10:06 ` [Bridge] [PATCH net-next 04/11] vxlan: vxlan_core: Add support for FDB flush Amit Cohen
2023-10-09 10:06 ` [Bridge] [PATCH net-next 05/11] vxlan: vxlan_core: Support FDB flushing by source VNI Amit Cohen
2023-10-09 10:06 ` [Bridge] [PATCH net-next 06/11] vxlan: vxlan_core: Support FDB flushing by nexthop ID Amit Cohen
2023-10-09 10:06 ` [Bridge] [PATCH net-next 07/11] vxlan: vxlan_core: Support FDB flushing by destination VNI Amit Cohen
2023-10-09 10:06 ` [Bridge] [PATCH net-next 08/11] vxlan: vxlan_core: Support FDB flushing by destination port Amit Cohen
2023-10-09 10:06 ` [Bridge] [PATCH net-next 09/11] vxlan: vxlan_core: Support FDB flushing by destination IP Amit Cohen
2023-10-09 10:06 ` [Bridge] [PATCH net-next 10/11] selftests: Add test cases for FDB flush with VXLAN device Amit Cohen
2023-10-09 10:06 ` [Bridge] [PATCH net-next 11/11] selftests: fdb_flush: Add test cases for FDB flush with bridge device Amit Cohen
2023-10-10 19:11 ` Scott Wadkins
2023-10-10 18:50 ` Nikolay Aleksandrov [this message]
2023-10-13 9:10 ` [Bridge] [PATCH net-next 00/11] Extend VXLAN driver to support FDB flushing patchwork-bot+netdevbpf
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4bf848f2-94a6-d941-645b-42309def1900@blackwall.org \
--to=razor@blackwall.org \
--cc=amcohen@nvidia.com \
--cc=bridge@lists.linux-foundation.org \
--cc=davem@davemloft.net \
--cc=dsahern@kernel.org \
--cc=idosch@nvidia.com \
--cc=kuba@kernel.org \
--cc=linux-kselftest@vger.kernel.org \
--cc=mlxsw@nvidia.com \
--cc=netdev@vger.kernel.org \
--cc=pabeni@redhat.com \
--cc=roopa@nvidia.com \
--cc=shuah@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).