From: Jakub Kicinski <kuba@kernel.org>
To: "Linus Lüssing" <linus.luessing@c0d3.blue>
Cc: netdev@vger.kernel.org, bridge@lists.linux.dev,
b.a.t.m.a.n@lists.open-mesh.org, linux-kernel@vger.kernel.org,
Roopa Prabhu <roopa@nvidia.com>,
Nikolay Aleksandrov <razor@blackwall.org>,
"David S . Miller" <davem@davemloft.net>,
Eric Dumazet <edumazet@google.com>,
Paolo Abeni <pabeni@redhat.com>
Subject: Re: [PATCH net] bridge: mcast: fix disabled snooping after long uptime
Date: Fri, 26 Jan 2024 17:27:20 -0800 [thread overview]
Message-ID: <20240126172720.716689b6@kernel.org> (raw)
In-Reply-To: <20240126143607.5649-1-linus.luessing@c0d3.blue>
On Fri, 26 Jan 2024 15:36:07 +0100 Linus Lüssing wrote:
> +static inline void br_multicast_query_delay_expired(struct timer_list *t)
> +{
> +}
nit: let's drop the inline, if it's to suppress a compiler warning
under some configurations - it's better to put an explicit #ifdef
around it.
--
pw-bot: cr
prev parent reply other threads:[~2024-01-27 1:27 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-01-26 14:36 [PATCH net] bridge: mcast: fix disabled snooping after long uptime Linus Lüssing
2024-01-27 1:27 ` Jakub Kicinski [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20240126172720.716689b6@kernel.org \
--to=kuba@kernel.org \
--cc=b.a.t.m.a.n@lists.open-mesh.org \
--cc=bridge@lists.linux.dev \
--cc=davem@davemloft.net \
--cc=edumazet@google.com \
--cc=linus.luessing@c0d3.blue \
--cc=linux-kernel@vger.kernel.org \
--cc=netdev@vger.kernel.org \
--cc=pabeni@redhat.com \
--cc=razor@blackwall.org \
--cc=roopa@nvidia.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).