From: Pavel Tikhomirov <ptikhomirov@virtuozzo.com>
To: "David S. Miller" <davem@davemloft.net>,
Eric Dumazet <edumazet@google.com>,
Jakub Kicinski <kuba@kernel.org>, Paolo Abeni <pabeni@redhat.com>,
Florian Westphal <fw@strlen.de>, David Ahern <dsahern@kernel.org>,
Jozsef Kadlecsik <kadlec@netfilter.org>,
Kees Cook <keescook@chromium.org>,
Nikolay Aleksandrov <razor@blackwall.org>,
Pablo Neira Ayuso <pablo@netfilter.org>,
Roopa Prabhu <roopa@nvidia.com>
Cc: netdev@vger.kernel.org, linux-kernel@vger.kernel.org,
netfilter-devel@vger.kernel.org, coreteam@netfilter.org,
bridge@lists.linux.dev, kernel@openvz.org,
Pavel Tikhomirov <ptikhomirov@virtuozzo.com>
Subject: [PATCH v3 0/4] netlink: bridge: fix nf_bridge->physindev use after free
Date: Thu, 11 Jan 2024 23:06:36 +0800 [thread overview]
Message-ID: <20240111150645.85637-1-ptikhomirov@virtuozzo.com> (raw)
Code processing skb from neigh->arp_queue can access its
nf_bridge->physindev, which can already be freed, leading to crash.
So, as Florian suggests, we can put physinif on nf_bridge and peek into
the original device with dev_get_by_index_rcu(), so that we can be sure
that device is not freed under us.
This is a second attempt to fix this issue, first attempt:
"neighbour: purge nf_bridged skb from foreign device neigh"
https://lore.kernel.org/netdev/20240108085232.95437-1-ptikhomirov@virtuozzo.com/
v3: resend it to proper lists and recipients
Pavel Tikhomirov (4):
netfilter: nfnetlink_log: use proper helper for fetching physinif
netfilter: nf_queue: remove excess nf_bridge variable
netfilter: propagate net to nf_bridge_get_physindev
netfilter: bridge: replace physindev with physinif in nf_bridge_info
include/linux/netfilter_bridge.h | 6 ++--
include/linux/skbuff.h | 2 +-
net/bridge/br_netfilter_hooks.c | 42 +++++++++++++++++-----
net/bridge/br_netfilter_ipv6.c | 14 +++++---
net/ipv4/netfilter/nf_reject_ipv4.c | 9 +++--
net/ipv6/netfilter/nf_reject_ipv6.c | 11 ++++--
net/netfilter/ipset/ip_set_hash_netiface.c | 8 ++---
net/netfilter/nf_log_syslog.c | 13 +++----
net/netfilter/nf_queue.c | 6 ++--
net/netfilter/nfnetlink_log.c | 8 ++---
net/netfilter/xt_physdev.c | 2 +-
11 files changed, 80 insertions(+), 41 deletions(-)
--
2.43.0
next reply other threads:[~2024-01-11 15:07 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-01-11 15:06 Pavel Tikhomirov [this message]
2024-01-11 15:06 ` [PATCH v3 1/4] netfilter: nfnetlink_log: use proper helper for fetching physinif Pavel Tikhomirov
2024-01-15 10:51 ` Simon Horman
2024-01-11 15:06 ` [PATCH v3 2/4] netfilter: nf_queue: remove excess nf_bridge variable Pavel Tikhomirov
2024-01-15 10:52 ` Simon Horman
2024-01-11 15:06 ` [PATCH v3 3/4] netfilter: propagate net to nf_bridge_get_physindev Pavel Tikhomirov
2024-01-15 10:52 ` Simon Horman
2024-01-11 15:06 ` [PATCH v3 4/4] netfilter: bridge: replace physindev with physinif in nf_bridge_info Pavel Tikhomirov
2024-01-17 12:43 ` [PATCH v3 0/4] netlink: bridge: fix nf_bridge->physindev use after free Pablo Neira Ayuso
2024-01-17 14:15 ` Florian Westphal
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20240111150645.85637-1-ptikhomirov@virtuozzo.com \
--to=ptikhomirov@virtuozzo.com \
--cc=bridge@lists.linux.dev \
--cc=coreteam@netfilter.org \
--cc=davem@davemloft.net \
--cc=dsahern@kernel.org \
--cc=edumazet@google.com \
--cc=fw@strlen.de \
--cc=kadlec@netfilter.org \
--cc=keescook@chromium.org \
--cc=kernel@openvz.org \
--cc=kuba@kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=netdev@vger.kernel.org \
--cc=netfilter-devel@vger.kernel.org \
--cc=pabeni@redhat.com \
--cc=pablo@netfilter.org \
--cc=razor@blackwall.org \
--cc=roopa@nvidia.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).