From: Simon Horman <horms@kernel.org>
To: Lin Ma <linma@zju.edu.cn>
Cc: roopa@nvidia.com, razor@blackwall.org, davem@davemloft.net,
edumazet@google.com, kuba@kernel.org, pabeni@redhat.com,
horatiu.vultur@microchip.com, henrik.bjoernlund@microchip.com,
bridge@lists.linux.dev, netdev@vger.kernel.org,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH v1] bridge: cfm: fix enum typo in br_cc_ccm_tx_parse
Date: Wed, 20 Dec 2023 17:53:52 +0100 [thread overview]
Message-ID: <20231220165352.GO882741@kernel.org> (raw)
In-Reply-To: <55cdc6e4.49734.18c880f5a2f.Coremail.linma@zju.edu.cn>
On Thu, Dec 21, 2023 at 12:29:16AM +0800, Lin Ma wrote:
> Hello Simon,
>
> >
> > Thanks Lin Ma,
> >
> > I agree with your analysis, that the problem was introduced in the
> > cited commit, and that it is resolved by your patch.
> >
>
> Thanks for the encouragement.
>
> > However, as there is no user-visible bug I don't believe this reaches
> > the bar for a 'fix' for Networking code. Accordingly, I think that
> > the Fixes tag should be dropped. And, instead cited commit can be mentioned
> > using something like "This problem was introduced by commit ...".
> >
> > Also, as I don't think it is a fix I think it should be targeted at the
> > net-next tree:
> >
> > Subject: [PATCH net-next vX] ...
> >
>
> Copy that. Yeah, once the enum IFLA_BRIDGE_CFM_CC_RDI_INSTANCE and the
> IFLA_BRIDGE_CFM_CC_CCM_TX_INSTANCE keeps the value 1, everything should work
> as usual. I will resend the patch as told.
Thanks, much appreciated.
v2 looks good to me.
>
> > The above nits notwithstanding,
> >
> > Reviewed-by: Simon Horman <horms@kernel.org>
> >
>
> Regards
> Lin
prev parent reply other threads:[~2023-12-20 16:54 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-12-20 7:59 [PATCH v1] bridge: cfm: fix enum typo in br_cc_ccm_tx_parse Lin Ma
2023-12-20 16:17 ` Simon Horman
2023-12-20 16:29 ` Lin Ma
2023-12-20 16:53 ` Simon Horman [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20231220165352.GO882741@kernel.org \
--to=horms@kernel.org \
--cc=bridge@lists.linux.dev \
--cc=davem@davemloft.net \
--cc=edumazet@google.com \
--cc=henrik.bjoernlund@microchip.com \
--cc=horatiu.vultur@microchip.com \
--cc=kuba@kernel.org \
--cc=linma@zju.edu.cn \
--cc=linux-kernel@vger.kernel.org \
--cc=netdev@vger.kernel.org \
--cc=pabeni@redhat.com \
--cc=razor@blackwall.org \
--cc=roopa@nvidia.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).