From: Vladimir Oltean <vladimir.oltean@nxp.com>
To: Ido Schimmel <idosch@nvidia.com>
Cc: Vlad Yasevich <vyasevic@redhat.com>,
"Michael S. Tsirkin" <mst@redhat.com>,
netdev@vger.kernel.org, Nikolay Aleksandrov <razor@blackwall.org>,
bridge@lists.linux-foundation.org, linux-kernel@vger.kernel.org,
Eric Dumazet <edumazet@google.com>,
Roopa Prabhu <roopa@nvidia.com>, Jakub Kicinski <kuba@kernel.org>,
Paolo Abeni <pabeni@redhat.com>,
"David S. Miller" <davem@davemloft.net>
Subject: Re: [Bridge] [PATCH net] net: bridge: keep ports without IFF_UNICAST_FLT in BR_PROMISC mode
Date: Mon, 3 Jul 2023 19:08:26 +0300 [thread overview]
Message-ID: <20230703160826.5wx5mmszr67hvjmw@skbuf> (raw)
In-Reply-To: <ZKKADtxlXyPmBvbr@shredder>
On Mon, Jul 03, 2023 at 11:00:14AM +0300, Ido Schimmel wrote:
> On Fri, Jun 30, 2023 at 07:41:18PM +0300, Vladimir Oltean wrote:
> > diff --git a/net/bridge/br_if.c b/net/bridge/br_if.c
> > index 3f04b40f6056..2450690f98cf 100644
> > --- a/net/bridge/br_if.c
> > +++ b/net/bridge/br_if.c
> > @@ -166,8 +166,9 @@ void br_manage_promisc(struct net_bridge *br)
> > * This lets us disable promiscuous mode and write
> > * this config to hw.
> > */
> > - if (br->auto_cnt == 0 ||
> > - (br->auto_cnt == 1 && br_auto_port(p)))
> > + if ((p->dev->priv_flags & IFF_UNICAST_FLT) &&
> > + (br->auto_cnt == 0 ||
> > + (br->auto_cnt == 1 && br_auto_port(p))))
> > br_port_clear_promisc(p);
> > else
> > br_port_set_promisc(p);
>
> IIUC, you are basically saying "If the port does not support unicast
> filtering, then set it to promiscuous mode right away instead of waiting
> for the addition of the first FDB entry to trigger it."
Correct.
> If so, LGTM.
>
> Reviewed-by: Ido Schimmel <idosch@nvidia.com>
>
> Tested using [1].
>
> Before:
>
> # ~/tmp/promisc_repo.sh
> 0
>
> After:
>
> # ~/tmp/promisc_repo.sh
> 1
>
> [1]
> #!/bin/bash
>
> ip link add name swp1 type dummy
> ip link add name br1 type bridge vlan_filtering 1
> ip link set dev swp1 master br1
> ip -d -j -p link show dev swp1 | jq '.[]["promiscuity"]'
Thanks for testing.
next prev parent reply other threads:[~2023-07-03 16:08 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-06-30 16:41 [Bridge] [PATCH net] net: bridge: keep ports without IFF_UNICAST_FLT in BR_PROMISC mode Vladimir Oltean
2023-07-03 8:00 ` Ido Schimmel
2023-07-03 16:08 ` Vladimir Oltean [this message]
2023-07-03 8:20 ` patchwork-bot+netdevbpf
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20230703160826.5wx5mmszr67hvjmw@skbuf \
--to=vladimir.oltean@nxp.com \
--cc=bridge@lists.linux-foundation.org \
--cc=davem@davemloft.net \
--cc=edumazet@google.com \
--cc=idosch@nvidia.com \
--cc=kuba@kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=mst@redhat.com \
--cc=netdev@vger.kernel.org \
--cc=pabeni@redhat.com \
--cc=razor@blackwall.org \
--cc=roopa@nvidia.com \
--cc=vyasevic@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).