From: Jakub Kicinski <kuba@kernel.org>
To: xu xin <xu.xin.sc@gmail.com>
Cc: netdev@vger.kernel.org, razor@blackwall.org,
bridge@lists.linux-foundation.org, linux-kernel@vger.kernel.org,
yang.yang29@zte.com.cn, edumazet@google.com,
zhang.yunkai@zte.com.cn, xu.xin16@zte.com.cn,
jiang.xuexin@zte.com.cn, roopa@nvidia.com, pabeni@redhat.com,
davem@davemloft.net
Subject: Re: [Bridge] [PATCH net-next] net/bridge: add drop reasons for bridge forwarding
Date: Tue, 11 Apr 2023 18:49:52 -0700 [thread overview]
Message-ID: <20230411184952.1657b8c9@kernel.org> (raw)
In-Reply-To: <20230412013310.174561-1-xu.xin16@zte.com.cn>
On Wed, 12 Apr 2023 09:33:10 +0800 xu xin wrote:
> >You can return the reason from this function. That's the whole point of
> >SKB_NOT_DROPPED_YET existing and being equal to 0.
>
> If returning the reasons, then the funtion will have to be renamed because
> 'should_deliever()' is expected to return a non-zero value when it's ok to
> deliever. I don't want to change the name here, and it's better to keep its
> name and use the pointer to store the reasons.
Sure. You have to touch all callers, anyway, you can as well adjust
the name.
next prev parent reply other threads:[~2023-04-12 1:49 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-04-06 11:30 [Bridge] [PATCH net-next] net/bridge: add drop reasons for bridge forwarding yang.yang29
2023-04-08 3:03 ` Jakub Kicinski
2023-04-12 1:33 ` xu xin
2023-04-12 1:49 ` Jakub Kicinski [this message]
2023-04-11 8:03 ` Nikolay Aleksandrov
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20230411184952.1657b8c9@kernel.org \
--to=kuba@kernel.org \
--cc=bridge@lists.linux-foundation.org \
--cc=davem@davemloft.net \
--cc=edumazet@google.com \
--cc=jiang.xuexin@zte.com.cn \
--cc=linux-kernel@vger.kernel.org \
--cc=netdev@vger.kernel.org \
--cc=pabeni@redhat.com \
--cc=razor@blackwall.org \
--cc=roopa@nvidia.com \
--cc=xu.xin.sc@gmail.com \
--cc=xu.xin16@zte.com.cn \
--cc=yang.yang29@zte.com.cn \
--cc=zhang.yunkai@zte.com.cn \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).