From: Shuah Khan <skhan@linuxfoundation.org>
To: Tejun Heo <tj@kernel.org>
Cc: "Edward Liaw" <edliaw@google.com>,
shuah@kernel.org, "Mickaël Salaün" <mic@digikod.net>,
"Günther Noack" <gnoack@google.com>,
"Christian Brauner" <brauner@kernel.org>,
"Richard Cochran" <richardcochran@gmail.com>,
"Paul Walmsley" <paul.walmsley@sifive.com>,
"Palmer Dabbelt" <palmer@dabbelt.com>,
"Albert Ou" <aou@eecs.berkeley.edu>,
"Alexei Starovoitov" <ast@kernel.org>,
"Daniel Borkmann" <daniel@iogearbox.net>,
"David S. Miller" <davem@davemloft.net>,
"Jakub Kicinski" <kuba@kernel.org>,
"Jesper Dangaard Brouer" <hawk@kernel.org>,
"John Fastabend" <john.fastabend@gmail.com>,
"Zefan Li" <lizefan.x@bytedance.com>,
"Johannes Weiner" <hannes@cmpxchg.org>,
"Muchun Song" <muchun.song@linux.dev>,
"Michal Hocko" <mhocko@kernel.org>,
"Roman Gushchin" <roman.gushchin@linux.dev>,
"Shakeel Butt" <shakeel.butt@linux.dev>,
"Yosry Ahmed" <yosryahmed@google.com>,
"Nhat Pham" <nphamcs@gmail.com>,
"Chengming Zhou" <chengming.zhou@linux.dev>,
linux-kernel@vger.kernel.org, linux-kselftest@vger.kernel.org,
kernel-team@android.com, linux-security-module@vger.kernel.org,
netdev@vger.kernel.org, linux-riscv@lists.infradead.org,
bpf@vger.kernel.org, cgroups@vger.kernel.org, linux-mm@kvack.org,
"Linus Torvalds" <torvalds@linux-foundation.org>,
"Shuah Khan" <skhan@linuxfoundation.org>
Subject: Re: [PATCH v4 08/66] selftests/cgroup: Drop define _GNU_SOURCE
Date: Thu, 16 May 2024 12:05:48 -0600 [thread overview]
Message-ID: <a8702e6b-0360-493d-bf8b-94dd7f17e7f1@linuxfoundation.org> (raw)
In-Reply-To: <ZkZGP9Io6o9Dhh36@slm.duckdns.org>
On 5/16/24 11:45, Tejun Heo wrote:
> Hello,
>
> On Thu, May 16, 2024 at 10:31:13AM -0600, Shuah Khan wrote:
>> I am exploring options and leaning towards reverting the patch
>>
>> daef47b89efd ("selftests: Compile kselftest headers with -D_GNU_SOURCE")
>>
>> Your amending the PR helps me if I have to send revert. I am sorry
>> for the trouble.
>>
>> I can all of them together in a second update or after the merge window
>> closes.
>
> The cgroup commit is already pulled in unfortunately. Can you please handle
> the revert and whatever's necessary to fix up the situation? I'll ask you
> what to do with selftest patches from now on.
>
Thanks for the update. Yes I am working on fixing the situation and
will send revert for cgroup test patch as well if necessary.
No worries. It is not a problem for you to handle cgroup test patches
in general. I will need your review anyway and letting you handle them
reduces the overhead.
This kind of framework change causes needs to be coordinated.
I should have held back on the framework change on my part.
thanks,
-- Shuah
next prev parent reply other threads:[~2024-05-16 18:05 UTC|newest]
Thread overview: 79+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-05-10 0:06 [PATCH v4 00/66] Define _GNU_SOURCE for sources using Edward Liaw
2024-05-10 0:06 ` [PATCH v4 01/66] selftests: Compile with -D_GNU_SOURCE when including lib.mk Edward Liaw
2024-05-10 0:06 ` [PATCH v4 02/66] selftests/arm64: Drop define _GNU_SOURCE Edward Liaw
2024-05-10 0:06 ` [PATCH v4 03/66] selftests/arm64: Drop duplicate -D_GNU_SOURCE Edward Liaw
2024-05-10 0:06 ` [PATCH v4 04/66] selftests/bpf: Drop define _GNU_SOURCE Edward Liaw
2024-05-10 0:06 ` [PATCH v4 05/66] selftests/breakpoints: " Edward Liaw
2024-05-10 0:06 ` [PATCH v4 06/66] selftests/cachestat: " Edward Liaw
2024-05-10 0:06 ` [PATCH v4 07/66] selftests/capabilities: " Edward Liaw
2024-05-10 0:06 ` [PATCH v4 08/66] selftests/cgroup: " Edward Liaw
2024-05-13 17:02 ` Tejun Heo
2024-05-16 15:50 ` Shuah Khan
2024-05-16 16:21 ` Tejun Heo
2024-05-16 16:31 ` Shuah Khan
2024-05-16 17:45 ` Tejun Heo
2024-05-16 18:05 ` Shuah Khan [this message]
2024-05-17 3:47 ` Shuah Khan
2024-05-10 0:06 ` [PATCH v4 09/66] selftests/clone3: " Edward Liaw
2024-05-10 0:06 ` [PATCH v4 10/66] selftests/core: " Edward Liaw
2024-05-10 0:06 ` [PATCH v4 11/66] selftests/damon: " Edward Liaw
2024-05-10 0:06 ` [PATCH v4 12/66] selftests/drivers: " Edward Liaw
2024-05-10 0:06 ` [PATCH v4 13/66] selftests/exec: Drop duplicate -D_GNU_SOURCE Edward Liaw
2024-05-10 17:44 ` Kees Cook
2024-05-10 0:06 ` [PATCH v4 14/66] selftests/fchmodat2: Drop define _GNU_SOURCE Edward Liaw
2024-05-10 0:06 ` [PATCH v4 15/66] selftests/filelock: " Edward Liaw
2024-05-10 0:06 ` [PATCH v4 16/66] selftests/filesystems: " Edward Liaw
2024-05-10 0:06 ` [PATCH v4 17/66] selftests/firmware: " Edward Liaw
2024-05-10 0:06 ` [PATCH v4 18/66] selftests/fpu: " Edward Liaw
2024-05-10 0:06 ` [PATCH v4 19/66] selftests/futex: " Edward Liaw
2024-05-10 0:06 ` [PATCH v4 20/66] selftests/futex: Drop duplicate -D_GNU_SOURCE Edward Liaw
2024-05-10 0:06 ` [PATCH v4 21/66] selftests/intel_pstate: " Edward Liaw
2024-05-10 0:06 ` [PATCH v4 22/66] selftests/iommu: " Edward Liaw
2024-05-10 0:06 ` [PATCH v4 23/66] selftests/ipc: Drop define _GNU_SOURCE Edward Liaw
2024-05-10 0:06 ` [PATCH v4 24/66] selftests/kcmp: " Edward Liaw
2024-05-10 0:06 ` [PATCH v4 25/66] selftests/landlock: " Edward Liaw
2024-05-10 0:06 ` [PATCH v4 26/66] selftests/lsm: " Edward Liaw
2024-05-10 0:06 ` [PATCH v4 27/66] selftests/membarrier: " Edward Liaw
2024-05-10 0:06 ` [PATCH v4 28/66] selftests/memfd: " Edward Liaw
2024-05-10 0:06 ` [PATCH v4 29/66] selftests/mincore: " Edward Liaw
2024-05-10 0:06 ` [PATCH v4 30/66] selftests/mm: " Edward Liaw
2024-05-10 0:06 ` [PATCH v4 31/66] selftests/mount: " Edward Liaw
2024-05-10 0:06 ` [PATCH v4 32/66] selftests/mount_setattr: " Edward Liaw
2024-05-10 0:06 ` [PATCH v4 33/66] selftests/move_mount_set_group: " Edward Liaw
2024-05-10 0:06 ` [PATCH v4 34/66] selftests/mqueue: " Edward Liaw
2024-05-10 0:06 ` [PATCH v4 35/66] selftests/net: " Edward Liaw
2024-05-10 0:06 ` [PATCH v4 36/66] selftests/net: Drop duplicate -D_GNU_SOURCE Edward Liaw
2024-05-10 0:06 ` [PATCH v4 37/66] selftests/nolibc: Drop define _GNU_SOURCE Edward Liaw
2024-05-10 6:58 ` Thomas Weißschuh
2024-05-10 0:06 ` [PATCH v4 38/66] selftests/nsfs: " Edward Liaw
2024-05-10 0:06 ` [PATCH v4 39/66] selftests/openat2: " Edward Liaw
2024-05-10 0:06 ` [PATCH v4 40/66] selftests/perf_events: " Edward Liaw
2024-05-10 0:06 ` [PATCH v4 41/66] selftests/pid_namespace: " Edward Liaw
2024-05-10 0:06 ` [PATCH v4 42/66] selftests/pidfd: " Edward Liaw
2024-05-10 0:07 ` [PATCH v4 43/66] selftests/ptrace: " Edward Liaw
2024-05-10 0:07 ` [PATCH v4 44/66] selftests/powerpc: " Edward Liaw
2024-05-10 0:07 ` [PATCH v4 45/66] selftests/proc: " Edward Liaw
2024-05-10 0:07 ` [PATCH v4 46/66] selftests/proc: Drop duplicate -D_GNU_SOURCE Edward Liaw
2024-05-10 0:07 ` [PATCH v4 47/66] selftests/ptp: Drop define _GNU_SOURCE Edward Liaw
2024-05-10 0:07 ` [PATCH v4 48/66] selftests/resctrl: Drop duplicate -D_GNU_SOURCE Edward Liaw
2024-05-10 0:07 ` [PATCH v4 49/66] selftests/riscv: Drop define _GNU_SOURCE Edward Liaw
2024-05-10 0:07 ` [PATCH v4 50/66] selftests/riscv: Drop duplicate -D_GNU_SOURCE Edward Liaw
2024-05-10 0:07 ` [PATCH v4 51/66] selftests/rlimits: Drop define _GNU_SOURCE Edward Liaw
2024-05-10 0:07 ` [PATCH v4 52/66] selftests/rseq: " Edward Liaw
2024-05-10 0:07 ` [PATCH v4 53/66] selftests/safesetid: " Edward Liaw
2024-05-10 0:07 ` [PATCH v4 54/66] selftests/sched: " Edward Liaw
2024-05-10 0:07 ` [PATCH v4 55/66] selftests/seccomp: " Edward Liaw
2024-05-10 17:45 ` Kees Cook
2024-05-10 0:07 ` [PATCH v4 56/66] selftests/sigaltstack: " Edward Liaw
2024-05-10 0:07 ` [PATCH v4 57/66] selftests/splice: " Edward Liaw
2024-05-10 0:07 ` [PATCH v4 58/66] selftests/syscall_user_dispatch: " Edward Liaw
2024-05-10 0:07 ` [PATCH v4 59/66] selftests/thermal: " Edward Liaw
2024-05-10 0:07 ` [PATCH v4 60/66] selftests/timens: " Edward Liaw
2024-05-10 0:07 ` [PATCH v4 61/66] selftests/tmpfs: Drop duplicate -D_GNU_SOURCE Edward Liaw
2024-05-10 0:07 ` [PATCH v4 62/66] selftests/uevent: Drop define _GNU_SOURCE Edward Liaw
2024-05-10 0:07 ` [PATCH v4 63/66] selftests/user_events: " Edward Liaw
2024-05-10 0:07 ` [PATCH v4 64/66] selftests/vDSO: " Edward Liaw
2024-05-10 0:07 ` [PATCH v4 65/66] selftests/wireguard: " Edward Liaw
2024-05-17 14:48 ` Jason A. Donenfeld
2024-05-10 0:07 ` [PATCH v4 66/66] selftests/x86: " Edward Liaw
2024-05-16 15:55 ` [PATCH v4 00/66] Define _GNU_SOURCE for sources using Shuah Khan
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=a8702e6b-0360-493d-bf8b-94dd7f17e7f1@linuxfoundation.org \
--to=skhan@linuxfoundation.org \
--cc=aou@eecs.berkeley.edu \
--cc=ast@kernel.org \
--cc=bpf@vger.kernel.org \
--cc=brauner@kernel.org \
--cc=cgroups@vger.kernel.org \
--cc=chengming.zhou@linux.dev \
--cc=daniel@iogearbox.net \
--cc=davem@davemloft.net \
--cc=edliaw@google.com \
--cc=gnoack@google.com \
--cc=hannes@cmpxchg.org \
--cc=hawk@kernel.org \
--cc=john.fastabend@gmail.com \
--cc=kernel-team@android.com \
--cc=kuba@kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-kselftest@vger.kernel.org \
--cc=linux-mm@kvack.org \
--cc=linux-riscv@lists.infradead.org \
--cc=linux-security-module@vger.kernel.org \
--cc=lizefan.x@bytedance.com \
--cc=mhocko@kernel.org \
--cc=mic@digikod.net \
--cc=muchun.song@linux.dev \
--cc=netdev@vger.kernel.org \
--cc=nphamcs@gmail.com \
--cc=palmer@dabbelt.com \
--cc=paul.walmsley@sifive.com \
--cc=richardcochran@gmail.com \
--cc=roman.gushchin@linux.dev \
--cc=shakeel.butt@linux.dev \
--cc=shuah@kernel.org \
--cc=tj@kernel.org \
--cc=torvalds@linux-foundation.org \
--cc=yosryahmed@google.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).