From: Cupertino Miranda <cupertino.miranda@oracle.com>
To: Eduard Zingerman <eddyz87@gmail.com>
Cc: Alexei Starovoitov <alexei.starovoitov@gmail.com>,
bpf <bpf@vger.kernel.org>, Andrii Nakryiko <andrii@kernel.org>,
"Jose E. Marchesi" <jose.marchesi@oracle.com>
Subject: Re: [PATCH bpf-next v4 0/7] bpf/verifier: range computation improvements
Date: Fri, 03 May 2024 20:33:17 +0100 [thread overview]
Message-ID: <875xvuu1vm.fsf@oracle.com> (raw)
In-Reply-To: <402d482b9681aa29f0714d9855a3348a78751343.camel@gmail.com>
Eduard Zingerman writes:
> On Fri, 2024-05-03 at 17:42 +0100, Cupertino Miranda wrote:
>> Is it Ok to reduce all this to 2 patches.
>> One with the verifier changes and another with selftests.
>
> Hi Miranda,
>
> I think Alexei meant that patch #7 could be moved to the beginning of the patch-set.
> Which would simplify patch #2.
> The main logical structure of the series makes sense to me, I think we should keep it:
> - replace calls to mark_reg_unknown
>>> do equivalent of patch #7 here, remove unnecessary checks <<
> - refactor checks for range computation (factor out is_safe_to_compute_dst_reg_range)
> - improve XOR and OR range computation
> - XOR and OR range computation tests
> - relax MUL range computation check
> - MUL range computation tests
Ok, I will reorganize the code for this.
Thanks,
Cupertino
prev parent reply other threads:[~2024-05-03 19:33 UTC|newest]
Thread overview: 19+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-04-29 21:22 [PATCH bpf-next v4 0/7] bpf/verifier: range computation improvements Cupertino Miranda
2024-04-29 21:22 ` [PATCH bpf-next v4 1/7] bpf/verifier: replace calls to mark_reg_unknown Cupertino Miranda
2024-04-29 21:22 ` [PATCH bpf-next v4 2/7] bpf/verifier: refactor checks for range computation Cupertino Miranda
2024-04-29 23:18 ` Eduard Zingerman
2024-04-30 7:17 ` Cupertino Miranda
2024-04-30 14:52 ` Alexei Starovoitov
2024-04-29 21:22 ` [PATCH bpf-next v4 3/7] bpf/verifier: improve XOR and OR " Cupertino Miranda
2024-04-29 21:22 ` [PATCH bpf-next v4 4/7] selftests/bpf: XOR and OR range computation tests Cupertino Miranda
2024-04-29 21:22 ` [PATCH bpf-next v4 5/7] bpf/verifier: relax MUL range computation check Cupertino Miranda
2024-04-29 21:22 ` [PATCH bpf-next v4 6/7] selftests/bpf: MUL range computation tests Cupertino Miranda
2024-04-29 21:22 ` [PATCH bpf-next v4 7/7] bpf/verifier: improve code after range computation recent changes Cupertino Miranda
2024-04-29 23:16 ` Eduard Zingerman
2024-04-29 23:29 ` Eduard Zingerman
2024-04-30 16:48 ` Eduard Zingerman
2024-05-03 14:14 ` [PATCH bpf-next v4 0/7] bpf/verifier: range computation improvements Cupertino Miranda
2024-05-03 16:20 ` Alexei Starovoitov
2024-05-03 16:42 ` Cupertino Miranda
2024-05-03 18:18 ` Eduard Zingerman
2024-05-03 19:33 ` Cupertino Miranda [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=875xvuu1vm.fsf@oracle.com \
--to=cupertino.miranda@oracle.com \
--cc=alexei.starovoitov@gmail.com \
--cc=andrii@kernel.org \
--cc=bpf@vger.kernel.org \
--cc=eddyz87@gmail.com \
--cc=jose.marchesi@oracle.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).