From: Yabin Cui <yabinc@google.com>
To: Peter Zijlstra <peterz@infradead.org>,
Ingo Molnar <mingo@redhat.com>,
Arnaldo Carvalho de Melo <acme@kernel.org>,
Namhyung Kim <namhyung@kernel.org>,
Mark Rutland <mark.rutland@arm.com>,
Alexander Shishkin <alexander.shishkin@linux.intel.com>,
Jiri Olsa <jolsa@kernel.org>, Ian Rogers <irogers@google.com>,
Adrian Hunter <adrian.hunter@intel.com>
Cc: linux-perf-users@vger.kernel.org, linux-kernel@vger.kernel.org,
bpf@vger.kernel.org, Yabin Cui <yabinc@google.com>
Subject: [PATCH v4 0/3] perf/core: Check sample_type in sample data saving helper functions
Date: Fri, 10 May 2024 12:14:20 -0700 [thread overview]
Message-ID: <20240510191423.2297538-1-yabinc@google.com> (raw)
Hello,
We use helper functions to save raw data, callchain and branch stack in
perf_sample_data. These functions update perf_sample_data->dyn_size without
checking event->attr.sample_type, which may result in unused space allocated in
sample records. To prevent this from happening, this patchset enforces checking
sample_type of an event in these helper functions.
Thanks,
Yabin
Changes since v1:
- Check event->attr.sample_type & PERF_SAMPLE_RAW before
calling perf_sample_save_raw_data().
- Subject has been changed to reflect the change of solution.
Changes since v2:
- Move sample_type check into perf_sample_save_raw_data().
- (New patch) Move sample_type check into perf_sample_save_callchain().
- (New patch) Move sample_type check into perf_sample_save_brstack().
Changes since v3:
- Fix -Werror=implicit-function-declaration by moving has_branch_stack().
Original commit message from v1:
perf/core: Trim dyn_size if raw data is absent
Original commit message from v2/v3:
perf/core: Save raw sample data conditionally based on sample type
Yabin Cui (3):
perf/core: Save raw sample data conditionally based on sample type
perf/core: Check sample_type in perf_sample_save_callchain
perf/core: Check sample_type in perf_sample_save_brstack
arch/s390/kernel/perf_cpum_cf.c | 2 +-
arch/s390/kernel/perf_pai_crypto.c | 2 +-
arch/s390/kernel/perf_pai_ext.c | 2 +-
arch/x86/events/amd/core.c | 3 +--
arch/x86/events/amd/ibs.c | 5 ++---
arch/x86/events/core.c | 3 +--
arch/x86/events/intel/ds.c | 9 +++-----
include/linux/perf_event.h | 20 ++++++++++++-----
kernel/events/core.c | 35 +++++++++++++++---------------
kernel/trace/bpf_trace.c | 11 +++++-----
10 files changed, 49 insertions(+), 43 deletions(-)
--
2.45.0.118.g7fe29c98d7-goog
next reply other threads:[~2024-05-10 19:14 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-05-10 19:14 Yabin Cui [this message]
2024-05-10 19:14 ` [PATCH v4 1/3] perf/core: Save raw sample data conditionally based on sample type Yabin Cui
2024-05-15 8:57 ` Peter Zijlstra
2024-05-15 17:39 ` Yabin Cui
2024-05-10 19:14 ` [PATCH v4 2/3] perf/core: Check sample_type in perf_sample_save_callchain Yabin Cui
2024-05-10 19:14 ` [PATCH v4 3/3] perf/core: Check sample_type in perf_sample_save_brstack Yabin Cui
2024-05-10 21:29 ` Namhyung Kim
2024-05-13 18:31 ` Yabin Cui
2024-05-13 20:39 ` Namhyung Kim
2024-05-15 8:58 ` Peter Zijlstra
2024-05-15 17:47 ` Yabin Cui
2024-05-10 19:30 ` [PATCH v4 0/3] perf/core: Check sample_type in sample data saving helper functions Ian Rogers
2024-05-10 21:26 ` Namhyung Kim
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20240510191423.2297538-1-yabinc@google.com \
--to=yabinc@google.com \
--cc=acme@kernel.org \
--cc=adrian.hunter@intel.com \
--cc=alexander.shishkin@linux.intel.com \
--cc=bpf@vger.kernel.org \
--cc=irogers@google.com \
--cc=jolsa@kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-perf-users@vger.kernel.org \
--cc=mark.rutland@arm.com \
--cc=mingo@redhat.com \
--cc=namhyung@kernel.org \
--cc=peterz@infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).