* [PATCH v1 4/4] perf record: Dump off-cpu samples directly
@ 2024-04-22 8:09 Howard Chu
0 siblings, 0 replies; 2+ messages in thread
From: Howard Chu @ 2024-04-22 8:09 UTC (permalink / raw
To: peterz
Cc: mingo, acme, namhyung, mark.rutland, alexander.shishkin, jolsa,
irogers, adrian.hunter, kan.liang, yangjihong1, zegao2021,
leo.yan, ravi.bangoria, linux-perf-users, linux-kernel, bpf,
Howard Chu
Since `--off-cpu` uses the same ring buffer as hardware samples, and `perf
record --off-cpu -e dummy sleep 1` does not enable evlist, off-cpu samples
cannot be read.`test_offcpu_basic` fails and is no longer necessary.
Signed-off-by: Howard Chu <howardchu95@gmail.com>
---
tools/perf/tests/shell/record_offcpu.sh | 29 -------------------------
1 file changed, 29 deletions(-)
diff --git a/tools/perf/tests/shell/record_offcpu.sh b/tools/perf/tests/shell/record_offcpu.sh
index 67c925f3a15a..c446c0cdee4f 100755
--- a/tools/perf/tests/shell/record_offcpu.sh
+++ b/tools/perf/tests/shell/record_offcpu.sh
@@ -36,30 +36,6 @@ test_offcpu_priv() {
fi
}
-test_offcpu_basic() {
- echo "Basic off-cpu test"
-
- if ! perf record --off-cpu -e dummy -o ${perfdata} sleep 1 2> /dev/null
- then
- echo "Basic off-cpu test [Failed record]"
- err=1
- return
- fi
- if ! perf evlist -i ${perfdata} | grep -q "offcpu-time"
- then
- echo "Basic off-cpu test [Failed no event]"
- err=1
- return
- fi
- if ! perf report -i ${perfdata} -q --percent-limit=90 | grep -E -q sleep
- then
- echo "Basic off-cpu test [Failed missing output]"
- err=1
- return
- fi
- echo "Basic off-cpu test [Success]"
-}
-
test_offcpu_child() {
echo "Child task off-cpu test"
@@ -88,13 +64,8 @@ test_offcpu_child() {
echo "Child task off-cpu test [Success]"
}
-
test_offcpu_priv
-if [ $err = 0 ]; then
- test_offcpu_basic
-fi
-
if [ $err = 0 ]; then
test_offcpu_child
fi
--
2.44.0
^ permalink raw reply related [flat|nested] 2+ messages in thread
* [PATCH v1 4/4] perf record: Dump off-cpu samples directly
@ 2024-04-22 8:40 Howard Chu
0 siblings, 0 replies; 2+ messages in thread
From: Howard Chu @ 2024-04-22 8:40 UTC (permalink / raw
To: peterz
Cc: mingo, acme, namhyung, mark.rutland, alexander.shishkin, jolsa,
irogers, adrian.hunter, kan.liang, zegao2021, leo.yan,
ravi.bangoria, linux-perf-users, linux-kernel, bpf, Howard Chu
Since `--off-cpu` uses the same ring buffer as hardware samples, and `perf
record --off-cpu -e dummy sleep 1` does not enable evlist, off-cpu samples
cannot be read.`test_offcpu_basic` fails and is no longer necessary.
Signed-off-by: Howard Chu <howardchu95@gmail.com>
---
tools/perf/tests/shell/record_offcpu.sh | 29 -------------------------
1 file changed, 29 deletions(-)
diff --git a/tools/perf/tests/shell/record_offcpu.sh b/tools/perf/tests/shell/record_offcpu.sh
index 67c925f3a15a..c446c0cdee4f 100755
--- a/tools/perf/tests/shell/record_offcpu.sh
+++ b/tools/perf/tests/shell/record_offcpu.sh
@@ -36,30 +36,6 @@ test_offcpu_priv() {
fi
}
-test_offcpu_basic() {
- echo "Basic off-cpu test"
-
- if ! perf record --off-cpu -e dummy -o ${perfdata} sleep 1 2> /dev/null
- then
- echo "Basic off-cpu test [Failed record]"
- err=1
- return
- fi
- if ! perf evlist -i ${perfdata} | grep -q "offcpu-time"
- then
- echo "Basic off-cpu test [Failed no event]"
- err=1
- return
- fi
- if ! perf report -i ${perfdata} -q --percent-limit=90 | grep -E -q sleep
- then
- echo "Basic off-cpu test [Failed missing output]"
- err=1
- return
- fi
- echo "Basic off-cpu test [Success]"
-}
-
test_offcpu_child() {
echo "Child task off-cpu test"
@@ -88,13 +64,8 @@ test_offcpu_child() {
echo "Child task off-cpu test [Success]"
}
-
test_offcpu_priv
-if [ $err = 0 ]; then
- test_offcpu_basic
-fi
-
if [ $err = 0 ]; then
test_offcpu_child
fi
--
2.44.0
^ permalink raw reply related [flat|nested] 2+ messages in thread
end of thread, other threads:[~2024-04-22 8:39 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2024-04-22 8:09 [PATCH v1 4/4] perf record: Dump off-cpu samples directly Howard Chu
-- strict thread matches above, loose matches on Subject: below --
2024-04-22 8:40 Howard Chu
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).