BPF Archive mirror
 help / color / mirror / Atom feed
From: patchwork-bot+netdevbpf@kernel.org
To: Jose E. Marchesi <jose.marchesi@oracle.com>
Cc: bpf@vger.kernel.org, david.faust@oracle.com,
	cupertino.miranda@oracle.com, eddyz87@gmail.com,
	yonghong.song@linux.dev, andrii.nakryiko@gmail.com
Subject: Re: [PATCH bpf-next V2] bpf: avoid uninitialized value in BPF_CORE_READ_BITFIELD
Date: Wed, 08 May 2024 22:10:29 +0000	[thread overview]
Message-ID: <171520622957.7593.2662904887895439011.git-patchwork-notify@kernel.org> (raw)
In-Reply-To: <20240508101313.16662-1-jose.marchesi@oracle.com>

Hello:

This patch was applied to bpf/bpf-next.git (master)
by Andrii Nakryiko <andrii@kernel.org>:

On Wed,  8 May 2024 12:13:13 +0200 you wrote:
> [Changes from V1:
>  - Use a default branch in the switch statement to initialize `val'.]
> 
> GCC warns that `val' may be used uninitialized in the
> BPF_CRE_READ_BITFIELD macro, defined in bpf_core_read.h as:
> 
> 	[...]
> 	unsigned long long val;						      \
> 	[...]								      \
> 	switch (__CORE_RELO(s, field, BYTE_SIZE)) {			      \
> 	case 1: val = *(const unsigned char *)p; break;			      \
> 	case 2: val = *(const unsigned short *)p; break;		      \
> 	case 4: val = *(const unsigned int *)p; break;			      \
> 	case 8: val = *(const unsigned long long *)p; break;		      \
>         }       							      \
> 	[...]
> 	val;								      \
> 	}								      \
> 
> [...]

Here is the summary with links:
  - [bpf-next,V2] bpf: avoid uninitialized value in BPF_CORE_READ_BITFIELD
    https://git.kernel.org/bpf/bpf-next/c/009367099eb6

You are awesome, thank you!
-- 
Deet-doot-dot, I am a bot.
https://korg.docs.kernel.org/patchwork/pwbot.html



      reply	other threads:[~2024-05-08 22:10 UTC|newest]

Thread overview: 2+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2024-05-08 10:13 [PATCH bpf-next V2] bpf: avoid uninitialized value in BPF_CORE_READ_BITFIELD Jose E. Marchesi
2024-05-08 22:10 ` patchwork-bot+netdevbpf [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=171520622957.7593.2662904887895439011.git-patchwork-notify@kernel.org \
    --to=patchwork-bot+netdevbpf@kernel.org \
    --cc=andrii.nakryiko@gmail.com \
    --cc=bpf@vger.kernel.org \
    --cc=cupertino.miranda@oracle.com \
    --cc=david.faust@oracle.com \
    --cc=eddyz87@gmail.com \
    --cc=jose.marchesi@oracle.com \
    --cc=yonghong.song@linux.dev \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).