From: Richard Purdie <richard.purdie@linuxfoundation.org>
To: michael.opdenacker@bootlin.com, bitbake-devel@lists.openembedded.org
Cc: Joshua Watt <JPEWhacker@gmail.com>, Tim Orling <ticotimo@gmail.com>
Subject: Re: [bitbake-devel] [PATCH 07/12] prserv: fix read_only test
Date: Wed, 03 Apr 2024 21:32:56 +0100 [thread overview]
Message-ID: <fb967b22dda9bb9f36f4540461f3782bf2096c56.camel@linuxfoundation.org> (raw)
In-Reply-To: <17C2CF7EC9CE2E93.4513@lists.openembedded.org>
On Wed, 2024-04-03 at 16:42 +0100, Richard Purdie via
lists.openembedded.org wrote:
> On Fri, 2024-03-29 at 15:39 +0100, Michael Opdenacker via
> lists.openembedded.org wrote:
> > From: Michael Opdenacker <michael.opdenacker@bootlin.com>
> >
> > read_only is an attribute of the parent server object, not of the
> > client.
> >
> > Signed-off-by: Michael Opdenacker <michael.opdenacker@bootlin.com>
> > Cc: Joshua Watt <JPEWhacker@gmail.com>
> > Cc: Tim Orling <ticotimo@gmail.com>
> > ---
> > lib/prserv/serv.py | 2 +-
> > 1 file changed, 1 insertion(+), 1 deletion(-)
> >
> > diff --git a/lib/prserv/serv.py b/lib/prserv/serv.py
> > index 242cd11a5a..efb2e0cf93 100644
> > --- a/lib/prserv/serv.py
> > +++ b/lib/prserv/serv.py
> > @@ -61,7 +61,7 @@ class
> > PRServerClient(bb.asyncrpc.AsyncServerConnection):
> >
> > async def handle_import_one(self, request):
> > response = None
> > - if not self.read_only:
> > + if not self.server.read_only:
> > version = request["version"]
> > pkgarch = request["pkgarch"]
> > checksum = request["checksum"]
> >
>
> Isn't this a missing piece of "prserv: simplify the PRServerClient()
> interface" and should be squashed there?
For testing purposes I squashed this in.
It also shows why I detest things like the quotes patch since that
cosmetic change broke trying to sort out this more important bisection
breaking issue.
Cheers,
Richard
next prev parent reply other threads:[~2024-04-03 20:33 UTC|newest]
Thread overview: 19+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-03-29 14:39 [PATCH 00/12] prserv: add support for an "upstream" server michael.opdenacker
2024-03-29 14:39 ` [PATCH 01/12] prserv: simplify the PRServerClient() interface michael.opdenacker
2024-03-29 14:39 ` [PATCH 02/12] prserv: use double quotes by default michael.opdenacker
2024-03-29 14:39 ` [PATCH 03/12] bitbake-prserv: replace deprecated optparse by argparse michael.opdenacker
2024-03-29 14:39 ` [PATCH 04/12] prserv: use self.logger instead of logger directly michael.opdenacker
2024-03-29 14:39 ` [PATCH 05/12] asyncrpc: include parse_address from hashserv michael.opdenacker
2024-03-29 14:39 ` [PATCH 06/12] prserv: capitalization and spacing improvements michael.opdenacker
2024-03-29 14:39 ` [PATCH 07/12] prserv: fix read_only test michael.opdenacker
2024-04-03 15:42 ` [bitbake-devel] " Richard Purdie
2024-04-03 16:19 ` Michael Opdenacker
[not found] ` <17C2CF7EC9CE2E93.4513@lists.openembedded.org>
2024-04-03 20:32 ` Richard Purdie [this message]
2024-03-29 14:39 ` [PATCH 08/12] prserv: add extra requests michael.opdenacker
2024-03-29 14:39 ` [PATCH 09/12] prserv: remove redundant exception handler michael.opdenacker
2024-03-29 14:39 ` [PATCH 10/12] prserv: correct error message michael.opdenacker
2024-03-29 14:39 ` [PATCH 11/12] prserv: remove unnecessary code michael.opdenacker
2024-03-29 14:39 ` [PATCH 12/12] prserv: add "upstream" server support michael.opdenacker
2024-04-03 15:09 ` [bitbake-devel] [PATCH 00/12] prserv: add support for an "upstream" server Richard Purdie
2024-04-03 15:33 ` Michael Opdenacker
2024-04-03 15:54 ` Richard Purdie
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=fb967b22dda9bb9f36f4540461f3782bf2096c56.camel@linuxfoundation.org \
--to=richard.purdie@linuxfoundation.org \
--cc=JPEWhacker@gmail.com \
--cc=bitbake-devel@lists.openembedded.org \
--cc=michael.opdenacker@bootlin.com \
--cc=ticotimo@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).