From: Richard Purdie <richard.purdie@linuxfoundation.org>
To: JPEWhacker@gmail.com, bitbake-devel@lists.openembedded.org
Subject: Re: [bitbake-devel][PATCH] asyncrpc: Check websockets version
Date: Wed, 08 May 2024 14:33:00 +0100 [thread overview]
Message-ID: <9945e07b120de0b8a33b12e73aa46b0f2b425023.camel@linuxfoundation.org> (raw)
In-Reply-To: <20240502183516.1216885-1-JPEWhacker@gmail.com>
On Thu, 2024-05-02 at 12:35 -0600, Joshua Watt via lists.openembedded.org wrote:
> Checks that the minimum version of the websockets module is present, and
> if not raises an ImportError. This allows the user to get earlier
> feedback if using websockets is going to succeed
>
> Signed-off-by: Joshua Watt <JPEWhacker@gmail.com>
> ---
> bitbake/lib/bb/asyncrpc/client.py | 22 ++++++++++++++++++++++
> 1 file changed, 22 insertions(+)
>
> diff --git a/bitbake/lib/bb/asyncrpc/client.py b/bitbake/lib/bb/asyncrpc/client.py
> index a350b4fb126..65f3f8964da 100644
> --- a/bitbake/lib/bb/asyncrpc/client.py
> +++ b/bitbake/lib/bb/asyncrpc/client.py
> @@ -24,6 +24,9 @@ ADDR_TYPE_UNIX = 0
> ADDR_TYPE_TCP = 1
> ADDR_TYPE_WS = 2
>
> +WEBSOCKETS_MIN_VERSION = (9, 1)
> +
> +
>
I think 9.1 breaks with some versions of python so we need something
later in some cases (like ubuntu 22.04).
Cheers,
Richard
prev parent reply other threads:[~2024-05-08 13:33 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-05-02 18:35 [bitbake-devel][PATCH] asyncrpc: Check websockets version Joshua Watt
2024-05-08 13:33 ` Richard Purdie [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=9945e07b120de0b8a33b12e73aa46b0f2b425023.camel@linuxfoundation.org \
--to=richard.purdie@linuxfoundation.org \
--cc=JPEWhacker@gmail.com \
--cc=bitbake-devel@lists.openembedded.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).