From: Quentin Schulz <quentin.schulz@cherry.de>
To: liezhi.yang@windriver.com, bitbake-devel@lists.openembedded.org
Subject: Re: [bitbake-devel] [PATCH 1/1] fetch2/git.py: Try without '.git' suffix firstly
Date: Wed, 15 May 2024 12:15:21 +0200 [thread overview]
Message-ID: <811a8c5a-747f-4331-8d8d-ccf6324961e9@cherry.de> (raw)
In-Reply-To: <b1399680-6f22-4477-ada4-8a718f807237@windriver.com>
Hi Robert,
On 5/15/24 11:57 AM, Robert Yang via lists.openembedded.org wrote:
> Hi Quentin,
>
> On 5/15/24 17:35, Quentin Schulz wrote:
>> Hi Robert,
>>
>> On 5/15/24 11:26 AM, Robert Yang via lists.openembedded.org wrote:
>>> From: Robert Yang <liezhi.yang@windriver.com>
>>>
>>> If the repo on server is foo.git, both of the following commands
>>> will work:
>>> 1) $ git clone <url>/foo.git
>>> 2) $ git clone <url>/foo
>>> But only the second command works if the repo server is foo
>>> (without .git suffix), so try without '.git' suffix firstly.
>>>
>>
>> Shouldn't the SRC_URI in the recipe be fixed instead of the git
>> fetcher? Which use case do we need to support here? Something to do
>> with mirroring maybe
> The usage is related to repo command + http/https mirror:
>
> * The foo.git on http/https MIRROR works with do_fetch
> * But 'repo' command always add a '.git' suffix to the reponame, the
> foo.git
> will be saved as foo.git.git on local disk, and do_fetch would not work
> with
> the local mirror.
>
> Our solution is rename foo.git to foo on http/https mirror, and apply
> this patch
> to make both http(s) and local mirror work with repo command.
>
> It's a little special to our Wind River Linux, and we need send the
> patch to
> mailing list for Yocto compliance.
>
I'm not sure this is something we should fix in BitBake since it's
related to the use of some external setup tool? I'll let more
knowledgeable people discuss this :)
In any case, I would suggest to really provide more info (the one as
above for example) at the very least in the commit log, and even better
in-code comment so that we don't remove it the day we want to de-clutter
code. The issue is that this looks very much like code we don't need,
without proper explanation of the use case (which you now provided).
Cheers,
Quentin
> // Robert
>
>>
>> Cheers,
>> Quentin
>
>
> -=-=-=-=-=-=-=-=-=-=-=-
> Links: You receive all messages sent to this group.
> View/Reply Online (#16222): https://lists.openembedded.org/g/bitbake-devel/message/16222
> Mute This Topic: https://lists.openembedded.org/mt/106110992/6293953
> Group Owner: bitbake-devel+owner@lists.openembedded.org
> Unsubscribe: https://lists.openembedded.org/g/bitbake-devel/unsub [quentin.schulz@cherry.de]
> -=-=-=-=-=-=-=-=-=-=-=-
>
next prev parent reply other threads:[~2024-05-15 10:15 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-05-15 9:26 [PATCH 0/1] fetch2/git.py: Try without '.git' suffix firstly liezhi.yang
2024-05-15 9:26 ` [PATCH 1/1] " liezhi.yang
2024-05-15 9:35 ` [bitbake-devel] " Quentin Schulz
2024-05-15 9:57 ` Robert Yang
2024-05-15 10:15 ` Quentin Schulz [this message]
2024-05-15 15:47 ` Richard Purdie
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=811a8c5a-747f-4331-8d8d-ccf6324961e9@cherry.de \
--to=quentin.schulz@cherry.de \
--cc=bitbake-devel@lists.openembedded.org \
--cc=liezhi.yang@windriver.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).