From: Marlon Rodriguez Garcia <marlon.rodriguez-garcia@savoirfairelinux.com>
To: richard purdie <richard.purdie@linuxfoundation.org>
Cc: bitbake-devel <bitbake-devel@lists.openembedded.org>,
toaster <toaster@lists.yoctoproject.org>
Subject: Re: [bitbake-devel] [Toaster] [PATCH] toaster: Added dataTables library to include sorting and pagination for table element
Date: Wed, 13 Dec 2023 10:00:36 -0500 (EST) [thread overview]
Message-ID: <321518811.78825.1702479636580.JavaMail.zimbra@savoirfairelinux.com> (raw)
In-Reply-To: <a4075d7dacd13a9c974c227c987ac112093204d7.camel@linuxfoundation.org>
The image missing is a version issue, i will update with a new patch with the latest version, the default value of entries for page in the table seems correct , i will include that on the patch as well.
In relation to the queue i will work on that in a different patch
----- Original Message -----
From: "richard purdie" <richard.purdie@linuxfoundation.org>
To: "Marlon Rodriguez Garcia" <marlon.rodriguez-garcia@savoirfairelinux.com>, "bitbake-devel" <bitbake-devel@lists.openembedded.org>, "toaster" <toaster@lists.yoctoproject.org>
Sent: Wednesday, December 13, 2023 8:11:06 AM
Subject: Re: [bitbake-devel] [Toaster] [PATCH] toaster: Added dataTables library to include sorting and pagination for table element
On Tue, 2023-12-12 at 16:57 -0500, Marlon Rodriguez Garcia wrote:
> Added jquery.dataTables to customize table rendering in section
> "Import eventlogs".
> This library includes the following: sorting, pagination, search and
> CSS styles.
Thanks, this looks good. I noticed that there are a couple of static
images missing:
http://localhost:8000/static/images/sort_asc.png
http://localhost:8000/static/images/sort_both.png
I also wondered about something like this:
diff --git a/bitbake/lib/toaster/toastergui/templates/command_line_builds.html b/bitbake/lib/toaster/toastergui/templates/command_line_builds.html
index 25a5e8062fb..c9fefef01a2 100644
--- a/bitbake/lib/toaster/toastergui/templates/command_line_builds.html
+++ b/bitbake/lib/toaster/toastergui/templates/command_line_builds.html
@@ -197,7 +197,7 @@ $( "#form_file").on( "submit", function( event ) {
});
$(document).ready( function () {
- $('#eventlog-table').DataTable();
+ $('#eventlog-table').DataTable({order: [[0, 'desc']], "pageLength": 50})
});
</script>
to set the default sort and show a few more file entries per page. Not
sure if I have that in the right place!
I did also realise the issue I was trying to explain yesterday.
If you start an import of a commandline build, then try and import a
second one whilst the first is still running, it crashes. Is there
something we can do about that so they queue?
Cheers,
Richard
-=-=-=-=-=-=-=-=-=-=-=-
Links: You receive all messages sent to this group.
View/Reply Online (#15659): https://lists.openembedded.org/g/bitbake-devel/message/15659
Mute This Topic: https://lists.openembedded.org/mt/103148397/7896800
Group Owner: bitbake-devel+owner@lists.openembedded.org
Unsubscribe: https://lists.openembedded.org/g/bitbake-devel/leave/12674656/7896800/2042766072/xyzzy [marlon.rodriguez-garcia@savoirfairelinux.com]
-=-=-=-=-=-=-=-=-=-=-=-
prev parent reply other threads:[~2023-12-13 15:00 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-12-12 21:57 [PATCH] toaster: Added dataTables library to include sorting and pagination for table element Marlon Rodriguez Garcia
2023-12-13 13:11 ` [Toaster] " Richard Purdie
2023-12-13 15:00 ` Marlon Rodriguez Garcia [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=321518811.78825.1702479636580.JavaMail.zimbra@savoirfairelinux.com \
--to=marlon.rodriguez-garcia@savoirfairelinux.com \
--cc=bitbake-devel@lists.openembedded.org \
--cc=richard.purdie@linuxfoundation.org \
--cc=toaster@lists.yoctoproject.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).