From: patchwork-bot+netdevbpf@kernel.org
To: Sven Eckelmann <sven@narfation.org>
Cc: davem@davemloft.net, edumazet@google.com, kuba@kernel.org,
pabeni@redhat.com, b.a.t.m.a.n@lists.open-mesh.org,
netdev@vger.kernel.org, stable@vger.kernel.org,
syzbot+f8812454d9b3ac00d282@syzkaller.appspotmail.com
Subject: Re: [PATCH net] batman-adv: Hold rtnl lock during MTU update via netlink
Date: Wed, 23 Aug 2023 00:30:24 +0000 [thread overview]
Message-ID: <169275062461.22438.15672454677210639225.git-patchwork-notify@kernel.org> (raw)
In-Reply-To: <20230821-batadv-missing-mtu-rtnl-lock-v1-1-1c5a7bfe861e@narfation.org>
Hello:
This patch was applied to netdev/net.git (main)
by Jakub Kicinski <kuba@kernel.org>:
On Mon, 21 Aug 2023 21:48:48 +0200 you wrote:
> The automatic recalculation of the maximum allowed MTU is usually triggered
> by code sections which are already rtnl lock protected by callers outside
> of batman-adv. But when the fragmentation setting is changed via
> batman-adv's own batadv genl family, then the rtnl lock is not yet taken.
>
> But dev_set_mtu requires that the caller holds the rtnl lock because it
> uses netdevice notifiers. And this code will then fail the check for this
> lock:
>
> [...]
Here is the summary with links:
- [net] batman-adv: Hold rtnl lock during MTU update via netlink
https://git.kernel.org/netdev/net/c/987aae75fc10
You are awesome, thank you!
--
Deet-doot-dot, I am a bot.
https://korg.docs.kernel.org/patchwork/pwbot.html
prev parent reply other threads:[~2023-08-23 6:26 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-08-21 19:48 [PATCH net] batman-adv: Hold rtnl lock during MTU update via netlink Sven Eckelmann
2023-08-22 7:55 ` Simon Horman
2023-08-23 0:30 ` patchwork-bot+netdevbpf [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=169275062461.22438.15672454677210639225.git-patchwork-notify@kernel.org \
--to=patchwork-bot+netdevbpf@kernel.org \
--cc=b.a.t.m.a.n@lists.open-mesh.org \
--cc=davem@davemloft.net \
--cc=edumazet@google.com \
--cc=kuba@kernel.org \
--cc=netdev@vger.kernel.org \
--cc=pabeni@redhat.com \
--cc=stable@vger.kernel.org \
--cc=sven@narfation.org \
--cc=syzbot+f8812454d9b3ac00d282@syzkaller.appspotmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).