From: Mathy Vanhoef <Mathy.Vanhoef@kuleuven.be>
To: Johannes Berg <johannes@sipsolutions.net>
Cc: backports@vger.kernel.org
Subject: Re: [PATCHv2] backports: Update hwsim defconfig
Date: Wed, 18 May 2022 15:52:38 +0200 [thread overview]
Message-ID: <20220518155238.42d1d464@zbook-mathy> (raw)
In-Reply-To: <d7f450afc9877b06cba8f5e6b4083b34f0733ef5.camel@sipsolutions.net>
On Mon, 11 Apr 2022 09:58:31 +0200
Johannes Berg <johannes@sipsolutions.net> wrote:
> On Mon, 2022-04-11 at 15:39 +0800, Mathy Vanhoef wrote:
> > In the current hwsim config no rate control algorithm is enabled.
> > This means that, when using defconfig-hwsim, the mac80211_hwsim
> > fails to load with the following error:
> >
> > [ 132.155183] ieee80211 phy0: Failed to select rate
> > control algorithm [ 132.155196] ieee80211 phy0: Failed to
> > initialize rate control algorithm
> >
> > Fix this by enabling rate control algorithms in the provided hwsim
> > config.
>
> Makes sense, thanks.
>
> > Experiments were also less reliable when WEXT was enabled. So this
> > patch also disables WEXT when using defconfig-hwsim to make the
> > default more reliable for users.
> >
>
> Huh? How so? Maybe some other tool was present on the system that was
> using wext, and disabling wext made that tool no longer detect the
> wireless or so? I cannot see how else it would be "less reliable" with
> wext enabled, if you don't really use it.
I checked this in more detail: when using kernel 5.13.0-30-generic on
Ubuntu 20.04 with backports-5.15.5-1 the kernel crashes when adding
interfaces in case WEXT has been enabled in backports (in my case when
inserting mac80211_hwsim in a virtual machine). The problem is that
wdev->netdev is NULL inside the function cfg80211_init_wdev, causing
the kernel to hang. The same happens on kernel 5.15.40-1-lts on Arch
Linux (this is currently the most up-to-date LTS kernel on Arch Linux).
Interestingly, on kernel 5.13.0-41-generic on Ubuntu 20.04 this isn't a
problem because the field wdev->netdev is then initialized.
--
To unsubscribe from this list: send the line "unsubscribe backports" in
prev parent reply other threads:[~2022-05-18 13:58 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-04-11 7:39 [PATCHv2] backports: Update hwsim defconfig Mathy Vanhoef
2022-04-11 7:58 ` Johannes Berg
2022-05-18 13:52 ` Mathy Vanhoef [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20220518155238.42d1d464@zbook-mathy \
--to=mathy.vanhoef@kuleuven.be \
--cc=backports@vger.kernel.org \
--cc=johannes@sipsolutions.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).