From: Johannes Berg <johannes@sipsolutions.net>
To: Hauke Mehrtens <hauke@hauke-m.de>,
"backports@vger.kernel.org" <backports@vger.kernel.org>
Cc: aspriel@gmail.com, John Crispin <john@phrozen.org>
Subject: Re: .coredump spatch
Date: Wed, 19 Sep 2018 10:49:28 +0200 [thread overview]
Message-ID: <1537346968.10305.4.camel@sipsolutions.net> (raw)
In-Reply-To: <a1e69bd7-132b-124b-d36c-b9cae361a9ff@hauke-m.de>
On Mon, 2018-09-17 at 23:39 +0200, Hauke Mehrtens wrote:
> The device structure now has this .coredump member which is also used by
> some wireless drivers, see here for example:
> https://git.kernel.org/linus/8e072168f75ebce85b96cbcefea2b10ddbd5913f
>
> I tried to create a spatch for this
How did you try? This seems to work for me:
@@
identifier drv, fn;
@@
static struct pci_driver drv = {
.driver = {
+#if LINUX_VERSION_IS_GEQ(4,16,0)
.coredump = fn,
+#endif
...
},
...
};
@@
identifier drv, fn;
@@
static struct pci_driver drv = {
+#if LINUX_VERSION_IS_GEQ(4,16,0)
.driver.coredump = fn,
+#endif
...
};
johannes
--
To unsubscribe from this list: send the line "unsubscribe backports" in
prev parent reply other threads:[~2018-09-19 14:26 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-09-17 21:39 .coredump spatch Hauke Mehrtens
2018-09-18 6:28 ` Omer Efrat
2018-09-18 6:28 ` Omer Efrat
2018-09-18 21:49 ` Hauke Mehrtens
2018-09-19 8:49 ` Johannes Berg [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1537346968.10305.4.camel@sipsolutions.net \
--to=johannes@sipsolutions.net \
--cc=aspriel@gmail.com \
--cc=backports@vger.kernel.org \
--cc=hauke@hauke-m.de \
--cc=john@phrozen.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).