From: Simon Horman <simon.horman@corigine.com>
To: Natalia Petrova <n.petrova@fintech.ru>
Cc: Larry Finger <Larry.Finger@lwfinger.net>,
Kalle Valo <kvalo@kernel.org>,
"David S. Miller" <davem@davemloft.net>,
Eric Dumazet <edumazet@google.com>,
Jakub Kicinski <kuba@kernel.org>, Paolo Abeni <pabeni@redhat.com>,
linux-wireless@vger.kernel.org, b43-dev@lists.infradead.org,
netdev@vger.kernel.org, linux-kernel@vger.kernel.org,
lvc-project@linuxtesting.org
Subject: Re: [PATCH] b43legacy: Add checking for null for ssb_get_devtypedata(dev)
Date: Sat, 11 Feb 2023 14:45:26 +0100 [thread overview]
Message-ID: <Y+eb9mZntfe6rO3v@corigine.com> (raw)
In-Reply-To: <20230210111228.370513-1-n.petrova@fintech.ru>
On Fri, Feb 10, 2023 at 02:12:28PM +0300, Natalia Petrova wrote:
> Function ssb_get_devtypedata(dev) may return null (next call
> B43legacy_WARN_ON(!wl) is used for error handling, including null-value).
> Therefore, a check is added before calling b43legacy_wireless_exit(),
> where the argument containing this value is expected to be dereferenced.
I see that is true, however, in that case are resources leaked
due to the ieee80211_free_hw() call in b43legacy_wireless_exit()
not being made?
Moreover, aren't there also unguarded dereferences of wl:
1. In the call to b43legacy_one_core_attach(),
which would branch to err_wireless_exit on failure.
2. In the call to schedule_work() just about the out: label.
For the record, and because it seems relevant to give contexxt,
b43legacy_probe() looks like this:
static int b43legacy_probe(struct ssb_device *dev,
const struct ssb_device_id *id)
{
struct b43legacy_wl *wl;
int err;
int first = 0;
wl = ssb_get_devtypedata(dev);
if (!wl) {
/* Probing the first core - setup common struct b43legacy_wl */
first = 1;
err = b43legacy_wireless_init(dev);
if (err)
goto out;
wl = ssb_get_devtypedata(dev);
B43legacy_WARN_ON(!wl);
}
err = b43legacy_one_core_attach(dev, wl);
if (err)
goto err_wireless_exit;
/* setup and start work to load firmware */
INIT_WORK(&wl->firmware_load, b43legacy_request_firmware);
schedule_work(&wl->firmware_load);
out:
return err;
err_wireless_exit:
if (first)
b43legacy_wireless_exit(dev, wl);
return err;
}
>
> Found by Linux Verification Center (linuxtesting.org) with SVACE
>
> Fixes: 75388acd0cd8 ("[B43LEGACY]: add mac80211-based driver for legacy BCM43xx devices")
> Signed-off-by: Natalia Petrova <n.petrova@fintech.ru>
> ---
> drivers/net/wireless/broadcom/b43legacy/main.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/net/wireless/broadcom/b43legacy/main.c b/drivers/net/wireless/broadcom/b43legacy/main.c
> index 760136638a95..1ae65679d704 100644
> --- a/drivers/net/wireless/broadcom/b43legacy/main.c
> +++ b/drivers/net/wireless/broadcom/b43legacy/main.c
> @@ -3871,7 +3871,7 @@ static int b43legacy_probe(struct ssb_device *dev,
> return err;
>
> err_wireless_exit:
> - if (first)
> + if (first && wl)
> b43legacy_wireless_exit(dev, wl);
> return err;
> }
> --
> 2.34.1
>
_______________________________________________
b43-dev mailing list
b43-dev@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/b43-dev
prev parent reply other threads:[~2023-02-11 13:46 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-02-10 11:12 [PATCH] b43legacy: Add checking for null for ssb_get_devtypedata(dev) Natalia Petrova
2023-02-10 19:17 ` Larry Finger
2023-02-11 13:45 ` Simon Horman [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=Y+eb9mZntfe6rO3v@corigine.com \
--to=simon.horman@corigine.com \
--cc=Larry.Finger@lwfinger.net \
--cc=b43-dev@lists.infradead.org \
--cc=davem@davemloft.net \
--cc=edumazet@google.com \
--cc=kuba@kernel.org \
--cc=kvalo@kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-wireless@vger.kernel.org \
--cc=lvc-project@linuxtesting.org \
--cc=n.petrova@fintech.ru \
--cc=netdev@vger.kernel.org \
--cc=pabeni@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).