From: Kalle Valo <kvalo@codeaurora.org>
To: b43-dev@lists.infradead.org
Subject: [PATCH v2 04/16] b43: Remove uninitialized_var() usage
Date: Wed, 15 Jul 2020 10:37:01 +0000 (UTC) [thread overview]
Message-ID: <20200715103701.52C31C433B7@smtp.codeaurora.org> (raw)
In-Reply-To: <20200620033007.1444705-5-keescook@chromium.org>
Kees Cook <keescook@chromium.org> wrote:
> Using uninitialized_var() is dangerous as it papers over real bugs[1]
> (or can in the future), and suppresses unrelated compiler warnings (e.g.
> "unused variable"). If the compiler thinks it is uninitialized, either
> simply initialize the variable or make compiler changes. As a precursor
> to removing[2] this[3] macro[4], just initialize this variable to NULL.
> No later NULL deref is possible due to the early returns outside of the
> (phy->rev >= 7 && phy->rev < 19) case, which explicitly tests for NULL.
>
> [1] https://lore.kernel.org/lkml/20200603174714.192027-1-glider at google.com/
> [2] https://lore.kernel.org/lkml/CA+55aFw+Vbj0i=1TGqCR5vQkCzWJ0QxK6CernOU6eedsudAixw at mail.gmail.com/
> [3] https://lore.kernel.org/lkml/CA+55aFwgbgqhbp1fkxvRKEpzyR5J8n1vKT1VZdz9knmPuXhOeg at mail.gmail.com/
> [4] https://lore.kernel.org/lkml/CA+55aFz2500WfbKXAx8s67wrm9=yVJu65TpLgN_ybYNv0VEOKA at mail.gmail.com/
>
> Fixes: 58619b14d106 ("b43: move under broadcom vendor directory")
> Signed-off-by: Kees Cook <keescook@chromium.org>
> Reviewed-by: Nick Desaulniers <ndesaulniers@google.com>
2 patches applied to wireless-drivers-next.git, thanks.
800e7a205a0f b43: Remove uninitialized_var() usage
f8279dad4e36 rtlwifi: rtl8192cu: Remove uninitialized_var() usage
--
https://patchwork.kernel.org/patch/11615573/
https://wireless.wiki.kernel.org/en/developers/documentation/submittingpatches
prev parent reply other threads:[~2020-07-15 10:37 UTC|newest]
Thread overview: 16+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <20200620033007.1444705-1-keescook@chromium.org>
[not found] ` <20200620033007.1444705-8-keescook@chromium.org>
2020-06-22 9:03 ` [PATCH v2 07/16] clk: st: Remove uninitialized_var() usage Stephen Boyd
[not found] ` <20200620033007.1444705-10-keescook@chromium.org>
2020-06-22 9:03 ` [PATCH v2 09/16] clk: spear: " Stephen Boyd
[not found] ` <CA+icZUWpHRR7ukyepiUH1dR3r4GMi-s2crfwR5vTszdt1SUTQw@mail.gmail.com>
[not found] ` <202006200854.B2D8F21@keescook>
2020-06-22 9:07 ` [PATCH v2 00/16] Remove uninitialized_var() macro Sedat Dilek
[not found] ` <20200620033007.1444705-2-keescook@chromium.org>
2020-06-22 16:59 ` [PATCH v2 01/16] docs: deprecated.rst: Add uninitialized_var() Nick Desaulniers
[not found] ` <20200620033007.1444705-11-keescook@chromium.org>
2020-06-22 17:22 ` [PATCH v2 10/16] KVM: PPC: Book3S PR: Remove uninitialized_var() usage Nick Desaulniers
[not found] ` <20200620033007.1444705-17-keescook@chromium.org>
2020-06-22 17:27 ` [PATCH v2 13/16] mm/debug_vm_pgtable: " Nick Desaulniers
[not found] ` <20200620033007.1444705-12-keescook@chromium.org>
2020-06-22 18:39 ` [PATCH v2 11/16] media: sur40: " Nick Desaulniers
[not found] ` <20200620033007.1444705-9-keescook@chromium.org>
2020-07-01 20:39 ` [PATCH v2 08/16] spi: davinci: " Mark Brown
2020-07-02 15:21 ` Kees Cook
2020-07-02 15:23 ` Mark Brown
2020-07-02 15:42 ` Kees Cook
2020-07-02 16:23 ` Joe Perches
[not found] ` <20200620033007.1444705-5-keescook@chromium.org>
2020-06-22 17:04 ` [PATCH v2 04/16] b43: " Nick Desaulniers
2020-06-22 21:04 ` Kees Cook
2020-06-23 18:29 ` Nick Desaulniers
2020-07-15 10:37 ` Kalle Valo [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20200715103701.52C31C433B7@smtp.codeaurora.org \
--to=kvalo@codeaurora.org \
--cc=b43-dev@lists.infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).