From: "Michael Büsch" <m@bues.ch>
To: Jia-Ju Bai <baijiaju1990@163.com>
Cc: Jonathan Corbet <corbet@lwn.net>,
netdev@vger.kernel.org, linux-wireless@vger.kernel.org,
linux-kernel@vger.kernel.org, b43-dev@lists.infradead.org,
kvalo@codeaurora.org, Larry Finger <Larry.Finger@lwfinger.net>
Subject: [PATCH] b43legacy: Fix a sleep-in-atomic bug in b43legacy_attr_interfmode_store
Date: Sun, 30 Jul 2017 12:24:04 +0200 [thread overview]
Message-ID: <20170730122404.63efba2c@wiggum> (raw)
In-Reply-To: <5930BCD6.9010306@163.com>
On Fri, 02 Jun 2017 09:18:14 +0800
Jia-Ju Bai <baijiaju1990@163.com> wrote:
> On 06/02/2017 12:11 AM, Jonathan Corbet wrote:
> > On Thu, 01 Jun 2017 09:05:07 +0800
> > Jia-Ju Bai<baijiaju1990@163.com> wrote:
> >
> >> I admit my patches are not well tested, and they may not well fix the bugs.
> >> I am looking forward to opinions and suggestions :)
> > May I politely suggest that sending out untested locking changes is a
> > dangerous thing to do? You really should not be changing the locking in a
> > piece of kernel code without understanding very well what the lock is
> > protecting and being able to say why your changes are safe. Without that,
> > the risk of introducing subtle bugs is very high.
> >
> > It looks like you have written a useful tool that could help us to make
> > the kernel more robust. If you are interested in my suggestion, I would
> > recommend that you post the sleep-in-atomic scenarios that you are
> > finding, but refrain from "fixing" them in any case where you cannot offer
> > a strong explanation of why your fix is correct.
> >
> > Thanks for working to find bugs in the kernel!
> >
> > jon
> Hi,
>
> Thanks for your good and helpful advice. I am sorry for my improper patches.
> I will only report bugs instead of sending improper patches when I have
> no good solution of fixing the bugs.
Is somebody still working on these fixes?
I think I found my old b43-legacy based 4306, so that I will
be able to get these patches into properly tested shape.
--
Michael
-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 833 bytes
Desc: OpenPGP digital signature
URL: <http://lists.infradead.org/pipermail/b43-dev/attachments/20170730/f87a6ac3/attachment.sig>
next prev parent reply other threads:[~2017-07-30 10:24 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-05-31 10:29 [PATCH] b43legacy: Fix a sleep-in-atomic bug in b43legacy_attr_interfmode_store Jia-Ju Bai
2017-05-31 15:17 ` Michael Büsch
2017-05-31 17:33 ` Larry Finger
2017-06-01 1:05 ` Jia-Ju Bai
2017-06-01 4:15 ` Kalle Valo
2017-06-01 16:11 ` Jonathan Corbet
2017-06-01 17:43 ` Larry Finger
2017-06-02 1:18 ` Jia-Ju Bai
2017-07-30 10:24 ` Michael Büsch [this message]
2017-06-01 23:24 ` kbuild test robot
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20170730122404.63efba2c@wiggum \
--to=m@bues.ch \
--cc=Larry.Finger@lwfinger.net \
--cc=b43-dev@lists.infradead.org \
--cc=baijiaju1990@163.com \
--cc=corbet@lwn.net \
--cc=kvalo@codeaurora.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-wireless@vger.kernel.org \
--cc=netdev@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).