From: Kalle Valo <kvalo@codeaurora.org>
To: Dan Carpenter <dan.carpenter@oracle.com>
Cc: Larry Finger <Larry.Finger@lwfinger.net>,
linux-wireless@vger.kernel.org, b43-dev@lists.infradead.org,
kernel-janitors@vger.kernel.org
Subject: Re: [PATCH 1/2] b43legacy: fix a lower bounds test
Date: Mon, 11 Oct 2021 06:09:53 +0000 (UTC) [thread overview]
Message-ID: <163393258963.11913.9834603879232230405.kvalo@codeaurora.org> (raw)
In-Reply-To: <20211006073542.GD8404@kili>
Dan Carpenter <dan.carpenter@oracle.com> wrote:
> The problem is that "channel" is an unsigned int, when it's less 5 the
> value of "channel - 5" is not a negative number as one would expect but
> is very high positive value instead.
>
> This means that "start" becomes a very high positive value. The result
> of that is that we never enter the "for (i = start; i <= end; i++) {"
> loop. Instead of storing the result from b43legacy_radio_aci_detect()
> it just uses zero.
>
> Fixes: 75388acd0cd8 ("[B43LEGACY]: add mac80211-based driver for legacy BCM43xx devices")
> Signed-off-by: Dan Carpenter <dan.carpenter@oracle.com>
> Acked-by: Michael Büsch <m@bues.ch>
2 patches applied to wireless-drivers-next.git, thanks.
c1c8380b0320 b43legacy: fix a lower bounds test
9b793db5fca4 b43: fix a lower bounds test
--
https://patchwork.kernel.org/project/linux-wireless/patch/20211006073542.GD8404@kili/
https://wireless.wiki.kernel.org/en/developers/documentation/submittingpatches
_______________________________________________
b43-dev mailing list
b43-dev@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/b43-dev
prev parent reply other threads:[~2021-10-11 6:10 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-10-06 7:35 [PATCH 1/2] b43legacy: fix a lower bounds test Dan Carpenter
2021-10-06 7:36 ` [PATCH 2/2] b43: " Dan Carpenter
2021-10-06 16:13 ` Michael Büsch
2021-10-06 16:13 ` [PATCH 1/2] b43legacy: " Michael Büsch
2021-10-11 6:09 ` Kalle Valo [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=163393258963.11913.9834603879232230405.kvalo@codeaurora.org \
--to=kvalo@codeaurora.org \
--cc=Larry.Finger@lwfinger.net \
--cc=b43-dev@lists.infradead.org \
--cc=dan.carpenter@oracle.com \
--cc=kernel-janitors@vger.kernel.org \
--cc=linux-wireless@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).