From: Johannes Berg <johannes@sipsolutions.net>
To: wuyonggang001@208suo.com, Larry.Finger@lwfinger.net, kvalo@kernel.org
Cc: linux-wireless@vger.kernel.org, b43-dev@lists.infradead.org,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH] b43legacy: Remove unneeded variable
Date: Wed, 14 Jun 2023 10:16:57 +0200 [thread overview]
Message-ID: <058dd31ef48495f8641f5b66839aaea039af0f08.camel@sipsolutions.net> (raw)
In-Reply-To: <12c1079d6e73f8f62c33b8a53dff7ff4de0728dc.camel@sipsolutions.net>
On Wed, 2023-06-14 at 10:02 +0200, Johannes Berg wrote:
> On Wed, 2023-06-14 at 15:55 +0800, wuyonggang001@208suo.com wrote:
> > Fix the following coccicheck warning:
> >
> > drivers/net/wireless/broadcom/b43legacy/debugfs.c:68:9-14: Unneeded
> > variable: "count".
>
> Hey, no. Please stop it already. This won't even _compile_. Just don't.
> There's really not much value in cleaning up those coccicheck warnings
> in the first place. You're just wasting everyone's time (including your
> own).
And BTW, I've just looked at all your other contributions to other areas
of the kernel, and heard from others as well - not doing any better!
I can only suggest that you stop all of your patch submissions and re-
evaluate what you're even trying to do. And not just you personally, but
all of the @208suo.com folks who popped up recently.
johannes
_______________________________________________
b43-dev mailing list
b43-dev@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/b43-dev
prev parent reply other threads:[~2023-06-14 8:17 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <20230614075250.29097-1-zhanglibing@cdjrlc.com>
2023-06-14 7:55 ` [PATCH] b43legacy: Remove unneeded variable wuyonggang001
2023-06-14 8:02 ` Johannes Berg
2023-06-14 8:16 ` Johannes Berg [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=058dd31ef48495f8641f5b66839aaea039af0f08.camel@sipsolutions.net \
--to=johannes@sipsolutions.net \
--cc=Larry.Finger@lwfinger.net \
--cc=b43-dev@lists.infradead.org \
--cc=kvalo@kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-wireless@vger.kernel.org \
--cc=wuyonggang001@208suo.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).