From: Janne Grunau <j@jannau.net>
To: Anatolij Gustschin <agust@denx.de>,
Heinrich Schuchardt <xypron.glpk@gmx.de>,
Ilias Apalodimas <ilias.apalodimas@linaro.org>
Cc: Simon Glass <sjg@chromium.org>,
Andre Przywara <andre.przywara@arm.com>,
u-boot@lists.denx.de, Janne Grunau <j@jannau.net>
Subject: [PATCH v3 0/7] video: Add UTF-8 support for UEFI applications
Date: Sat, 16 Mar 2024 22:50:17 +0100 [thread overview]
Message-ID: <20240316-vidconsole-utf8-uefi-v3-0-4e8a3d349447@jannau.net> (raw)
Andre submitted 2 years ago DM_VIDEO improvements for UEFI applications
using UEFI's EFI_SIMPLE_TEXT_OUTPUT_PROTOCOL but did not follow with
suggested changes. This series takes care of the UTF-8 support which
required to draw symbol and box drawing characters used by UEFI
applications like grub2 and sd-boot correctly.
Compared to Andre's version this version has the following changes:
- use and extend existing conversion functions from lib/charset.c
- convert to Unicode code points for truetype console support
- conversion is conditional on CONFIG_CHARSET
- use escape sequences in tests as proposed by Heinrich
Link: https://lore.kernel.org/u-boot/20220110005638.21599-1-andre.przywara@arm.com/
Signed-off-by: Janne Grunau <j@jannau.net>
---
Changes in v3:
- added Reviewed-by tag
- removed unnecessary u8 casts
- limited utf-8 conversion buffer to 5 bytes as documented
- added missing console_utf_to_cp437() documentation
- adapted EFI text output self-tests according to review comments
- dropped wait after EFI text output self tests
- added StrToFat EFI self test to ensure Unicode code points which map
to code page 437 code points 1-31 are converted to '_'
- Link to v2: https://lore.kernel.org/r/20240210-vidconsole-utf8-uefi-v2-0-88c03db60de2@jannau.net
Changes in v2:
- use "CONFIG_IS_ENABLED(CHARSET)" instead of EFI_LOADER
- rewritten commit message for mapping CP437 cp 1-31
- extended utf8_to_utf32_stream() documentation as suggested by
Heinrich
- Link to RFC: https://lore.kernel.org/r/20240117-vidconsole-utf8-uefi-v1-0-539f7ce74fb9@jannau.net
---
Andre Przywara (2):
efi_selftest: Add international characters test
efi_selftest: Add box drawing character selftest
Janne Grunau (5):
lib: charset: Fix and extend utf8_to_utf32_stream() documentation
video: console: Parse UTF-8 character sequences
lib/charset: Map Unicode code points to CP437 code points 1-31
efi_selftest: Add geometric shapes character selftest
efi_selftest: Update StrToFat() unit test after CP473 map extension
drivers/video/console_normal.c | 6 ++-
drivers/video/console_rotate.c | 16 ++++---
drivers/video/console_truetype.c | 8 ++--
drivers/video/vidconsole-uclass.c | 18 +++++---
drivers/video/vidconsole_internal.h | 19 ++++++++
include/charset.h | 16 +++++--
include/cp1250.h | 12 ++++-
include/cp437.h | 12 ++++-
include/video_console.h | 10 +++--
lib/charset.c | 9 ++--
lib/efi_loader/efi_unicode_collation.c | 2 +-
lib/efi_selftest/efi_selftest_textoutput.c | 54 +++++++++++++++++++++++
lib/efi_selftest/efi_selftest_unicode_collation.c | 12 +++++
13 files changed, 162 insertions(+), 32 deletions(-)
---
base-commit: 866ca972d6c3cabeaf6dbac431e8e08bb30b3c8e
change-id: 20240117-vidconsole-utf8-uefi-fa23b4ac65d6
Best regards,
--
Janne Grunau <j@jannau.net>
next reply other threads:[~2024-03-16 21:50 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-03-16 21:50 Janne Grunau [this message]
2024-03-16 21:50 ` [PATCH v3 1/7] lib: charset: Fix and extend utf8_to_utf32_stream() documentation Janne Grunau
2024-03-16 21:50 ` [PATCH v3 2/7] video: console: Parse UTF-8 character sequences Janne Grunau
2024-03-16 21:50 ` [PATCH v3 3/7] lib/charset: Map Unicode code points to CP437 code points 1-31 Janne Grunau
2024-03-16 21:50 ` [PATCH v3 4/7] efi_selftest: Add international characters test Janne Grunau
2024-03-16 21:50 ` [PATCH v3 5/7] efi_selftest: Add box drawing character selftest Janne Grunau
2024-03-16 21:50 ` [PATCH v3 6/7] efi_selftest: Add geometric shapes " Janne Grunau
2024-03-16 21:50 ` [PATCH v3 7/7] efi_selftest: Update StrToFat() unit test after CP473 map extension Janne Grunau
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20240316-vidconsole-utf8-uefi-v3-0-4e8a3d349447@jannau.net \
--to=j@jannau.net \
--cc=agust@denx.de \
--cc=andre.przywara@arm.com \
--cc=ilias.apalodimas@linaro.org \
--cc=sjg@chromium.org \
--cc=u-boot@lists.denx.de \
--cc=xypron.glpk@gmx.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).