From: Tomohiro Kusumi <kusumi.tomohiro@gmail.com>
To: Ian Kent <raven@themaw.net>
Cc: autofs@vger.kernel.org
Subject: Re: [PATCH] automount: Fix compiler warning
Date: Wed, 6 Jul 2016 18:27:55 +0900 [thread overview]
Message-ID: <CAHndrBkCkUSPd0oQ83G-rY_zOC_hdCFHmgrjw2kFXJsQp4-7iA@mail.gmail.com> (raw)
In-Reply-To: <1467797074.4580.51.camel@themaw.net>
Thank you.
Sure, feel free to commit it whenever you can, as it's just a cleanup.
2016-07-06 18:24 GMT+09:00 Ian Kent <raven@themaw.net>:
> On Mon, 2016-07-04 at 18:32 +0900, Tomohiro Kusumi wrote:
>> Fix below compiler (gcc5) warning which isn't autoconf result dependent.
>> mounts.c:1779:7: warning: variable 'ret' set but not used [-Wunused-but-set
>> -variable]
>
> Indeed, I've been meaning to fix that but I like to have a return assigned even
> when it's not used so I can easily identify functions that return status when
> changes are needed, so I've left it alone.
>
> I'm adding this to my list of patches (as is).
>
> Unless there is a pressing need for this to be committed to the upstream
> repository it will be done the next time I push changes and I can't say when
> that will be.
>
>>
>> Signed-off-by: Tomohiro Kusumi <kusumi.tomohiro@gmail.com>
>> ---
>> lib/mounts.c | 5 ++---
>> 1 file changed, 2 insertions(+), 3 deletions(-)
>>
>> diff --git a/lib/mounts.c b/lib/mounts.c
>> index 1d1b4da..c67548e 100644
>> --- a/lib/mounts.c
>> +++ b/lib/mounts.c
>> @@ -1776,16 +1776,15 @@ static int remount_active_mount(struct autofs_point
>> *ap,
>> *ioctlfd = -1;
>> }
>> } else {
>> - int ret;
>> /*
>> * What can I do if we can't remount the existing
>> * mount(s) (possibly a partial failure), everything
>> * following will be broken?
>> */
>> if (type == t_indirect)
>> - ret = do_remount_indirect(ap, fd, path);
>> + do_remount_indirect(ap, fd, path);
>> else
>> - ret = do_remount_direct(ap, fd, path);
>> + do_remount_direct(ap, fd, path);
>> }
>>
>> debug(ap->logopt, "re-connected to mount %s", path);
--
To unsubscribe from this list: send the line "unsubscribe autofs" in
prev parent reply other threads:[~2016-07-06 9:27 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-07-04 9:32 [PATCH] automount: Fix compiler warning Tomohiro Kusumi
2016-07-06 9:24 ` Ian Kent
2016-07-06 9:27 ` Tomohiro Kusumi [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=CAHndrBkCkUSPd0oQ83G-rY_zOC_hdCFHmgrjw2kFXJsQp4-7iA@mail.gmail.com \
--to=kusumi.tomohiro@gmail.com \
--cc=autofs@vger.kernel.org \
--cc=raven@themaw.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).