From: Jeff Mahoney <jeffm@suse.com>
To: Ian Kent <raven@themaw.net>, autofs@vger.kernel.org
Subject: Re: [PATCH 0/2] autofs: fix two related bugs with lookup + expired yp maps
Date: Thu, 5 May 2016 09:06:10 -0400 [thread overview]
Message-ID: <4fc33892-3d17-e2bb-b1bb-dda54f8f99d8@suse.com> (raw)
In-Reply-To: <1462443706.3011.15.camel@themaw.net>
[-- Attachment #1.1: Type: text/plain, Size: 2702 bytes --]
On 5/5/16 6:21 AM, Ian Kent wrote:
> On Thu, 2016-05-05 at 16:35 +0800, Ian Kent wrote:
>> On Wed, 2016-05-04 at 20:03 -0400, jeffm@suse.com wrote:
>>> From: Jeff Mahoney <jeffm@suse.com>
>>>
>>> Hi Ian -
>>>
>>> We recently encountered an issue where a client would all of a sudden
>>> start returning ELOOP for anything involving crossing an autofs mount.
>>> We tracked it down to two bugs, one which obscured the other. The
>>> first
>>> is that we were not properly updating the map age for yp maps when we
>>> retry
>>> the lookup with dots instead of underscores. The second is that it is
>>> possible under several situations to return success when there was a
>>> failure in lookup_nss_mount. In this particular case, it was the only
>>> map in the list and since the age wasn't update, it was skipped. Then
>>> we exit the while loop with ret == 0, ultimately returning success to
>>> the caller. Autofs would tell the kernel it succeeded, the kernel
>>> would
>>> retry the lookup, and we'd loop until we hit the kernel loop limit
>>> (40).
>>>
>>> These two patches fix each of the issues.
>>
>> OK, that sounds good.
>>
>> I'll have a look at the code to make sure I understand what's going on
>> before adding these to the list of patches I have.
>>
>> That list is getting a bit large now so I'll likely be committing them
>> soonish but I can't say yet when I'll release 5.1.2.
>>
>> Up until now I thought that the source of the ELOOP returns that some
>> people have seen were due to incorrect returns of in kernel mounted
>> checks where mounts were present in other namespaces.
>>
>> My most recent attempt at resolving that had a positive response from a
>> tester here on the list but another tester experienced file system
>> corruption. I'm totally at mystified by this so I'm a bit stuck at the
>> moment.
>
> When importing these I've made a couple of changes I hope you will be ok with.
> The content of the patches remains the same (assuming I have no other questions
> when I properly review them).
>
> Due to my convention of trying to always have the patch title the same as the
> patch name I had to change the first patch.
>
> I changed the patch name (and title with "-" changed to " ") to:
> autofs-5.1.1-fix-yp-map-age-not-updated-during-map-lookup.patch
>
> The description remains the same and I think still conveys the intent of the
> change.
>
> I changed only autofs: to autofs-5.1.1 in the second patch.
>
> Finally I assume your ok with me adding your "Signed-off-by:" to both patches,
> along with mine.
Yep, sounds good to me.
Thanks,
-Jeff
--
Jeff Mahoney
SUSE Labs
[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 881 bytes --]
prev parent reply other threads:[~2016-05-05 13:06 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-05-05 0:03 [PATCH 0/2] autofs: fix two related bugs with lookup + expired yp maps jeffm
2016-05-05 0:03 ` [PATCH 1/2] autofs: fix yp map age not updated in s/_/./g case jeffm
2016-05-05 0:03 ` [PATCH 2/2] autofs: properly handle errors in lookup_nss_mount jeffm
2016-05-05 8:35 ` [PATCH 0/2] autofs: fix two related bugs with lookup + expired yp maps Ian Kent
2016-05-05 10:21 ` Ian Kent
2016-05-05 13:06 ` Jeff Mahoney [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4fc33892-3d17-e2bb-b1bb-dda54f8f99d8@suse.com \
--to=jeffm@suse.com \
--cc=autofs@vger.kernel.org \
--cc=raven@themaw.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).